Skip to contentSkip to conversation

cpufreq driver + wrong cpu time

DISCUSSION Alexander Shaposhnikov 2 participants 3 messages Oct 30, 2005 – Oct 31, 2005

lore
Share & tools
lore
#0 lore raw

Hello to everyone.

I have written cpufreq_nForce4 kernel driver for cpufreq subsystem. It allows for CPU frequency changing by adjusting FSB speed, for nForce4 based motherboards.
Works for single-cpu systems, as well as for SMP.
The problem is, after changing CPU(s) speed on SMP systems, programs report wrong cpu time (wall time is OK).
What would be the best way to fix this, and shouldn't this be done by the cpufreq subsystem, rather than by hardware driver?

P.S
Please include me in the CC explicitly!

Best Regards,
Alexander Shaposhnikov

#1 lore raw
Quoted 2 lines · Alexander Shaposhnikov

Hello to everyone.

Hello Alexander,

Quoted 5 lines

I have written cpufreq_nForce4 kernel driver for cpufreq subsystem. It allows for CPU frequency changing by adjusting FSB speed, for nForce4 based motherboards. Works for single-cpu systems, as well as for SMP. The problem is, after changing CPU(s) speed on SMP systems, programs report wrong cpu time (wall time is OK).

What do you mean by CPU time? Do you mean the output of "time foo" ? How do you know the *right* CPU time? Could you provide some examples :-)

Well, anyway, by _rough_ guess, if on UP it works and on SMP it doesn't, we could imagine that the difference comes from the fact the tick interrupt source is not the same on those systems. You could try to boot a UP kernel with local APIC (selectable in the .config) on the multi-processor computer to check. Then it might mean that after changing the FSB speed, the interrupt source has to be re-programmed...

Quoted 3 lines

What would be the best way to fix this, and shouldn't this be done by the cpufreq subsystem, rather than by hardware driver?

Probably the best place to discuss about cpufreq is the dedicated mailing list : [email protected] . If you don't mind, you could
continue there.

Also please, provide the sources of your driver to have a look :-)

cu,
Eric

#2 lore raw

Hello Eric,

Its my first foray into kernel driver programming, so please don't be too hard on me:)

The total elapsed time (by "time foo") is OK.
The problem is, cputime reported by, for example, "top" utility, is wrong. The same problem with fortran intrinsic routine "ETIME", so quantum chemistry codes i use (all written in fortran) reports wrong cputime, but correct "wall(elapsed) time".

I've attached the code. I was able to test it only on my own dual Opteron system, so have no idea about other MB.

P.S.
Please include me in CC explicitly!

Best Regards,
Alexander Shaposhnikov

Quoted 32 lines · Eric Piel
Quoted 2 lines · Alexander Shaposhnikov

Hello to everyone.

Hello Alexander,

Quoted 6 lines

I have written cpufreq_nForce4 kernel driver for cpufreq subsystem. It allows for CPU frequency changing by adjusting FSB speed, for nForce4 based motherboards.
Works for single-cpu systems, as well as for SMP.
The problem is, after changing CPU(s) speed on SMP systems, programs report wrong cpu time (wall time is OK).

What do you mean by CPU time? Do you mean the output of "time foo" ? How do you know the *right* CPU time? Could you provide some examples :-)

Well, anyway, by _rough_ guess, if on UP it works and on SMP it doesn't, we could imagine that the difference comes from the fact the tick interrupt source is not the same on those systems. You could try to boot a UP kernel with local APIC (selectable in the .config) on the multi-processor computer to check. Then it might mean that after changing the FSB speed, the interrupt source has to be re-programmed...

Quoted 3 lines

What would be the best way to fix this, and shouldn't this be done by the cpufreq subsystem, rather than by hardware driver?

Probably the best place to discuss about cpufreq is the dedicated mailing list : [email protected] . If you don't mind, you could
continue there.

Also please, provide the sources of your driver to have a look :-)

cu,
Eric