Skip to contentSkip to conversation

pci_ids: remove non-referenced symbols from pci_ids.h

PATCH Dave Jones 3 participants 6 messages Oct 31, 2005 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Dave Jones

author
#1 lore raw
Quoted 5 lines · Linux Kernel

tree 68609a74c3bc43e510f58f9c808a0a74e9d23452
parent 4153812fc10ea91cb1a7b6ea4f4337dd211c1ef7
author Grant Coady <[email protected]> Thu, 29 Sep 2005 11:06:40 +1000 committer Greg Kroah-Hartman <[email protected]> Sat, 29 Oct 2005 05:36:59 -0700

Quoted 7 lines

[PATCH] pci_ids: remove non-referenced symbols from pci_ids.h

pci_ids.h cleanup: removed non-referenced symbols, compile tested with 'make allmodconfig'

This patch is removing some PCI idents from drivers that are currently marked BROKEN on some/all architectures. It seems counterproductive to create even more work to get those drivers fixed.

Especially in the case of for eg, the advansys scsi driver, which actually works for some people, even though it isn't updated to use modern scsi layer interfaces.

Dave

#2 lore raw
Quoted 11 lines · Dave Jones
Quoted 10 lines · Linux Kernel

tree 68609a74c3bc43e510f58f9c808a0a74e9d23452
parent 4153812fc10ea91cb1a7b6ea4f4337dd211c1ef7
author Grant Coady <[email protected]> Thu, 29 Sep 2005 11:06:40 +1000 committer Greg Kroah-Hartman <[email protected]> Sat, 29 Oct 2005 05:36:59 -0700

[PATCH] pci_ids: remove non-referenced symbols from pci_ids.h

pci_ids.h cleanup: removed non-referenced symbols, compile tested with 'make allmodconfig'

Quoted 6 lines
Quoted 2 lines

This patch is removing some PCI idents from drivers that are currently marked BROKEN on some/all architectures. It seems counterproductive to create even more work to get those drivers fixed.

Nobody cares, the drivers are dying of bit-rot :)

Quoted 3 lines

Especially in the case of for eg, the advansys scsi driver, which actually works for some people, even though it isn't updated to use modern scsi layer interfaces.

Any positive suggestions? How many years does a driver remain broken before it gets removed? These drivers don't compile cleanly thus are not in use, no? Perhaps a set of patches scheduling removal is in order.

Grant.

author
#3 lore raw
Quoted 5 lines · Grant Coady
Quoted 3 lines

This patch is removing some PCI idents from drivers that are currently marked BROKEN on some/all architectures. It seems counterproductive to create even more work to get those drivers fixed.

Nobody cares, the drivers are dying of bit-rot :)

Remove the BROKEN, and it builds, and runs just fine on most systems. (Or it least it did, until this intentional breakage occured).

Quoted 5 lines
Quoted 3 lines

Especially in the case of for eg, the advansys scsi driver, which actually works for some people, even though it isn't updated to use modern scsi layer interfaces.

Any positive suggestions?

Yes. Don't remove symbols that are referenced by code in the rest of the tree (even if it isn't buildable). It's not as though leaving those symbols there breaks anything, or even bloats the kernel.

Quoted 3 lines

How many years does a driver remain broken before it gets removed? These drivers don't compile cleanly thus are not in use, no? Perhaps a set of patches scheduling removal is in order.

At least 2 distros are carrying patches removing the BROKEN attribute on the advansys Kconfig for some architectures. The users of those kernels using their advansys controllers without any issue at all.

Even if this were not the case, randomly removing bits of a driver so that it has no chance of working isn't how we schedule removal.

Dave

#4 lore raw
Quoted 3 lines · Dave Jones

At least 2 distros are carrying patches removing the BROKEN attribute on the advansys Kconfig for some architectures. The users of those kernels using their advansys controllers without any issue at all.

So why are your driver patches not in mainline then?

Grant.

author
#5 lore raw
Quoted 6 lines · Grant Coady
Quoted 3 lines · Dave Jones

At least 2 distros are carrying patches removing the BROKEN attribute on the advansys Kconfig for some architectures. The users of those kernels using their advansys controllers without any issue at all.

So why are your driver patches not in mainline then?

Because it serves as a reminder that it needs fixing.

Dave

#6 lore raw
In reply to Grant Coady
Quoted 5 lines · Grant Coady
Quoted 3 lines

This patch is removing some PCI idents from drivers that are currently marked BROKEN on some/all architectures. It seems counterproductive to create even more work to get those drivers fixed.

Nobody cares, the drivers are dying of bit-rot :)

If you look at the -mm tree you will see various drivers are getting fixed eventually.