Skip to contentSkip to conversation

PCI PM: create pm.c and relocate PM functions

RFC PATCH In review Adam Belay 2 participants 3 messages Nov 16, 2005 PCI

lore
Share & tools
lore

Adam Belay

author
#0 lore raw

RFC PATCH 1/6 PCI PM: create pm.c and relocate PM functions

pci_save_state(), pci_restore_state(), pci_enable_wake(), pci_choose_state(), and pci_set_power_state() are moved to drivers/pci/pm.c.

This patch makes several code cleanups but no functional changes.

drivers/pci/Makefile +1 -1
@@ -2,7 +2,7 @@
 # Makefile for the PCI bus specific drivers.
 #
 
-obj-y		+= access.o bus.o probe.o remove.o pci.o quirks.o \
+obj-y		+= access.o bus.o probe.o remove.o pci.o pm.o quirks.o \
 			pci-driver.o search.o pci-sysfs.o rom.o setup-res.o
 obj-$(CONFIG_PROC_FS) += proc.o
 
drivers/pci/pci.c +1 -271

307 lines not on this page · raw message

drivers/pci/pm.c +296 -0

296 lines not on this page · raw message

#1 lore raw
Quoted 5 lines · Adam Belay

pci_save_state(), pci_restore_state(), pci_enable_wake(), pci_choose_state(), and pci_set_power_state() are moved to drivers/pci/pm.c.

This patch makes several code cleanups but no functional changes.

Looks good but:

drivers/pci/pm.c line 3

Quoted 6 lines
drivers/pci/pm.c +3 -0
@@ -0,0 +1,296 @@
+/*
+ * pm.c - PCI Device Power Management
+ */ 

You should say where this came from, and the copyrights for that file.

thanks,

greg k-h

author
#2 lore raw
Quoted 9 lines · Greg KH
Quoted 5 lines · Adam Belay

pci_save_state(), pci_restore_state(), pci_enable_wake(), pci_choose_state(), and pci_set_power_state() are moved to drivers/pci/pm.c.

This patch makes several code cleanups but no functional changes.

Looks good but:

Quoted 9 lines

drivers/pci/pm.c line 3

Quoted 6 lines
drivers/pci/pm.c +3 -0
@@ -0,0 +1,296 @@
+/*
+ * pm.c - PCI Device Power Management
+ */ 

You should say where this came from, and the copyrights for that file.

To be honest I'm not entirely sure where they came from. As with most of the PCI files, I'm guessing dozens of patches have touched them. In any case, I'll include the original header from pci.c.

Thanks,
Adam