Skip to contentSkip to conversation

orinoco: fix setting power management parameters

PATCH Applied Pavel Roskin 2 participants 2 messages Nov 29, 2005 – Dec 1, 2005

Subsystems (3)
Networking Network drivers Networking drivers (wireless)
lore
Share & tools
lore

Pavel Roskin

author
#0 lore raw

PATCH 1/1 orinoco: fix setting power management parameters

Power management parameters could not be set by iwconfig due to incorrect error handling.

Signed-off-by Pavel Roskin <proski-mXXj517/[email protected]>

---
This is a very simple bugfix, and the bug is serious enough, so I'll appreciate if the patch gets priority handling and goes to 2.6.15. I have lots of other stuff that can wait until 2.6.16.

(quoted diff) +0 -0

b/drivers/net/wireless/orinoco.c
index 2032c56..708b146 100644

drivers/net/wireless/orinoco.c +1 -2
@@ -3492,9 +3492,8 @@ static int orinoco_ioctl_setpower(struct
 			break;
 		default:
 			err = -EINVAL;
-		}
-		if (err)
 			goto out;
+		}
 		
 		if (prq->flags & IW_POWER_TIMEOUT) {
 			priv->pm_on = 1;
Signature · 10 lines
Regards,
Pavel Roskin



-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
Applied
#1 lore raw

applied

-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click