iscsi: add rdma attr
PATCH 1/8 iscsi: add rdma attr
Quoted 1 line
From Erez Zilber:
Add AF and RDMA provider properties.
drivers/scsi/iscsi_tcp.c +2 -0
@@ -3590,6 +3590,8 @@ static struct iscsi_transport iscsi_tcp_ .name = "tcp", .caps =CAP_RECOVERY_L0 |CAP_MULTI_R2T |CAP_HDRDGST | CAP_DATADGST, + .af = AF_INET, + .rdma = 0, .host_template = &iscsi_sht, .hostdata_size = sizeof(struct iscsi_session), .max_conn = 1,
drivers/scsi/scsi_transport_iscsi.c +4 -0
@@ -117,6 +117,8 @@ show_transport_attr(caps, "0x%x");show_transport_attr (max_lun,"%d" );show_transport_attr (max_conn,"%d" );show_transport_attr (max_cmd_len,"%d" ); +show_transport_attr (af,"%d" ); +show_transport_attr (rdma,"%d" );static struct attribute *iscsi_transport_attrs[] = { &class_device_attr_handle.attr,
@@ -124,6 +126,8 @@ static struct attribute *iscsi_transport &class_device_attr_max_lun.attr, &class_device_attr_max_conn.attr, &class_device_attr_max_cmd_len.attr, + &class_device_attr_af.attr, + &class_device_attr_rdma.attr, NULL, };
include/scsi/scsi_transport_iscsi.h +2 -0
@@ -47,6 +47,8 @@ struct iscsi_transport {struct module *owner;char *name;unsigned int caps; +unsigned short af; +unsigned short rdma;struct scsi_host_template *host_template;int hostdata_size;int max_lun;
Quoted 3 lines · Mike Christie
Quoted 1 line
From Erez Zilber:
Add AF and RDMA provider properties.
NACK, they're totally useless with the current kernel.
Quoted 9 lines · Christoph Hellwig
Quoted 3 lines · Mike Christie
Quoted 1 line
From Erez Zilber:
Add AF and RDMA provider properties.
NACK, they're totally useless with the current kernel.
This patchset works without those two patches. Kinda suspected you and Dimitry and Alex would not agree on those patches, so already tested without them :) Open-iscsi will need to just fixup userspace to account for this which has been brought up before so no biggie. Do you guys want me to make up a new patchset or will you just pick up the patchset without this patch and "[PATCH 4/8] iscsi: add rdma extensions"? Not merging those patches, makes this a all bug fix patchset so maybe it is 2.6.15 worthy.