Adaptive read-ahead V9
Subsystems (12)
cover Adaptive read-ahead V9
The current read-ahead logic uses an inflexible algorithm with 128KB VM_MAX_READAHEAD. Less memory leads to thrashing, more memory helps no throughput. The new logic is simply safer and faster. It makes sure every single read-ahead request is safe for the current load. Memory tight systems are expected to benefit a lot: no thrashing any more. It can also help boost I/O throughput for large memory systems, for VM_MAX_READAHEAD now defaults to 1MB. The value is no longer tightly coupled with the thrashing problem, and therefore constrainted by it.
Changelog
=========
V9 2005-12-3
- standalone mmap read-around code, a little more smart and tunable
- make stateful method sensible of request size
- decouple readahead_ratio from live pages protection
- let readahead_ratio contribute to ra_size grow speed in stateful method
- account variance of ra_size
V8 2005-11-25
- balance zone aging only in page relaim paths and do it right
- do the aging of slabs in the same way as zones
- add debug code to dump the detailed page reclaim steps
- undo exposing of struct radix_tree_node and uninline related functions
- work better with nfsd
- generalize accelerated context based read-ahead
- account smooth read-ahead aging based on page referenced/activate bits
- avoid divide error in compute_thrashing_threshold()
- more low lantency efforts
- update some comments
- rebase debug actions on debugfs entries instead of magic readahead_ratio values
V7 2005-11-09
- new tunable parameters: readahead_hit_rate/readahead_live_chunk
- support sparse sequential accesses
- delay look-ahead if drive is spinned down in laptop mode
- disable look-ahead for loopback file
- make mandatory thrashing protection more simple and robust
- attempt to improve responsiveness on large read-ahead size
V6 2005-11-01
- cancel look-ahead in laptop mode
- increase read-ahead limit to 0xFFFF pages
V5 2005-10-28
- rewrite context based method to make it clean and robust
- improved accuracy of stateful thrashing threshold estimation
- make page aging equal to the number of code pages scanned
- sort out the thrashing protection logic
- enhanced debug/accounting facilities
V4 2005-10-15
- detect and save live chunks on page reclaim
- support database workload
- support reading backward
- radix tree lookup look-aside cache
V3 2005-10-06
- major code reorganization and documention
- stateful estimation of thrashing-threshold
- context method with accelerated grow up phase
- adaptive look-ahead
- early detection and rescue of pages in danger
- statitics data collection
- synchronized page aging between zones
V2 2005-09-15
- delayed page activation
- look-ahead: towards pipelined read-ahead
V1 2005-09-13
Initial release which features:
o stateless (for now)
o adapts to available memory / read speed
o free of thrashing (in theory)
And handles:
o large number of slow streams (FTP server)
o open/read/close access patterns (NFS server)
o multiple interleaved, sequential streams in one file (multithread / multimedia / database)
Thanks,
Wu Fengguang
--
Dept. Automation University of Science and Technology of China
PATCH 1/16 mm: delayed page activation
When a page is referenced the second time in inactive_list, mark it with PG_activate instead of moving it into active_list immediately. The actual moving work is delayed to vmscan time.
This implies two essential changes:
- keeps the adjecency of pages in lru;
- lifts the page reference counter max from 1 to 3.
And leads to the following improvements:
- read-ahead for a leading reader will not be disturbed by a following reader;
- enables the thrashing protection logic to save pages for following readers;
- keeping relavant pages together helps improve I/O efficiency;
- and also helps decrease vm fragmantation;
- increased refcnt space might help page replacement algorithms.
---
include/linux/page-flags.h | 31 +++++++++++++++++++++++++++++++ mm/page_alloc.c | 1 + mm/swap.c | 9 ++++----- mm/vmscan.c | 6 ++++++ 4 files changed, 42 insertions(+), 5 deletions(-)
include/linux/page-flags.h +31 -0
@@ -76,6 +76,7 @@#define PG_reclaim 17/* To be reclaimed asap */ #define PG_nosave_free 18/* Free, should not be written */ #define PG_uncached 19/* Page has been mapped as uncached */ +#define PG_activate 20/* delayed activate */ /* * Global page accounting. One instance per CPU. Only unsigned longs are
@@ -314,6 +315,12 @@ extern void __mod_page_state(unsigned lo#define SetPageUncached (page) set_bit(PG_uncached, &(page)->flags)#define ClearPageUncached (page) clear_bit(PG_uncached, &(page)->flags) +#define PageActivate (page) test_bit(PG_activate, &(page)->flags) +#define SetPageActivate (page) set_bit(PG_activate, &(page)->flags) +#define ClearPageActivate (page) clear_bit(PG_activate, &(page)->flags) +#define TestClearPageActivate (page) test_and_clear_bit(PG_activate, &(page)->flags) +#define TestSetPageActivate (page) test_and_set_bit(PG_activate, &(page)->flags) +struct page ;/* forward declaration */ int test_clear_page_dirty (struct page *page);
@@ -339,4 +346,28 @@ static inline void set_page_writeback(st#define ClearPageFsMisc (page) clear_bit(PG_fs_misc, &(page)->flags)#define TestClearPageFsMisc (page) test_and_clear_bit(PG_fs_misc, &(page)->flags) +#if PG_activate < PG_referenced +#error unexpected page flags order +#endif + +#define PAGE_REFCNT_0 0 +#define PAGE_REFCNT_1 (1 << PG_referenced) +#define PAGE_REFCNT_2 (1 << PG_activate) +#define PAGE_REFCNT_3 ((1 << PG_activate) | (1 << PG_referenced)) +#define PAGE_REFCNT_MASK PAGE_REFCNT_3 + +/* +* STATUS REFERENCE COUNT +* __ 0 +* _R PAGE_REFCNT_1 +* A_ PAGE_REFCNT_2 +* AR PAGE_REFCNT_3 +* +* A/R: Active / Referenced +*/ +static inline unsigned long page_refcnt (struct page *page) +{ +return page->flags &PAGE_REFCNT_MASK ; +} +#endif /* PAGE_FLAGS_H */
mm/page_alloc.c +1 -0
@@ -543,6 +543,7 @@ static int prep_new_page(struct page *pa page->flags &= ~(1 << PG_uptodate |1 << PG_error |1 << PG_referenced |1 << PG_arch_1 | +1 << PG_activate |1 << PG_checked |1 << PG_mappedtodisk);set_page_private (page,0 );set_page_refs (page, order);
mm/swap.c +4 -5
@@ -29,7 +29,6 @@#include <linux/percpu.h> #include <linux/cpu.h> #include <linux/notifier.h> -#include <linux/init.h> /* How many pages do we try to swap or page in/out together? */ int page_cluster;
@@ -115,13 +114,13 @@ void fastcall activate_page(struct page* Mark a page as having seen activity. * * inactive,unreferenced -> inactive,referenced -* inactive,referenced -> active,unreferenced -* active,unreferenced -> active,referenced +* inactive,referenced -> activate,unreferenced +* activate,unreferenced -> activate,referenced */ void fastcall mark_page_accessed(struct page *page) { -if (!PageActive (page) &&PageReferenced (page) &&PageLRU (page)) { -activate_page (page); +if (!PageActivate (page) &&PageReferenced (page) &&PageLRU (page)) { +SetPageActivate (page);ClearPageReferenced (page); }else if (!PageReferenced (page)) {SetPageReferenced (page);
mm/vmscan.c +6 -0
@@ -454,6 +454,12 @@ static int shrink_list(struct list_headif (PageWriteback (page)) goto keep_locked; +if (PageActivate (page)) { +ClearPageActivate (page); +ClearPageReferenced (page); + goto activate_locked; + } + referenced =page_referenced (page,1 );/* In active use or really unfreeable? Activate it. */ if (referenced &&page_mapping_inuse (page))
--
Re: [PATCH 01/16] mm: delayed page activation
Quoted 6 lines · Wu Fengguang
When a page is referenced the second time in
inactive_list, mark it withPG_activateinstead of moving it intoactive_listimmediately. The actual moving work is delayed to vmscan time.This implies two essential changes:
- keeps the adjecency of pages in lru;
But this change destroys LRU ordering: at the time when shrink_list() inspects PG_activate bit, information about order in which mark_page_accessed() was called against pages is lost. E.g., suppose inactive list initially contained pages
/* head */ (P1, P2, P3) /* tail */
all of them referenced. Then mark_page_accessed(), is called against P1, P2, and P3 (in that order). With the old code active list would end up
/* head */ (P3, P2, P1) /* tail */
which corresponds to LRU. With delayed page activation, pages are moved to head of the active list in the order they are analyzed by shrink_list(), which gives
/* head */ (P1, P2, P3) /* tail */
on the active list, that is _inverse_ LRU order.
Nikita.
Re: [PATCH 01/16] mm: delayed page activation
Quoted 11 lines · Nikita Danilov
Quoted 6 lines · Wu Fengguang
When a page is referenced the second time in
inactive_list, mark it withPG_activateinstead of moving it intoactive_listimmediately. The actual moving work is delayed to vmscan time.This implies two essential changes:
- keeps the adjecency of pages in lru;But this change destroys LRU ordering: at the time when
shrink_list()inspectsPG_activatebit, information about order in whichmark_page_accessed()was called against pages is lost. E.g., suppose
Thanks.
But this order of re-access time may be pointless. In fact the original mark_page_accessed() is doing another inversion: inversion of page lifetime. In the word of CLOCK-Pro, a page first being re-accessed has lower inter-reference distance, and therefore should be better protected(if ignore possible read-ahead effects). If we move re-accessed pages immediately into active_list, we are pushing them closer to danger of eviction.
btw, the current vmscan code clears PG_referenced flag when moving pages to active_list. I followed the convention by doing this in the patch:
mm/vmscan.c +6 -0
@@ -454,6 +454,12 @@ static int shrink_list(struct list_headif (PageWriteback (page)) goto keep_locked; +if (PageActivate (page)) { +ClearPageActivate (page); +ClearPageReferenced (page); + goto activate_locked; + } + referenced =page_referenced (page,1 , sc->priority <=0 );/* In active use or really unfreeable? Activate it. */ if (referenced &&page_mapping_inuse (page))
Though I have a strong feeling that with the extra PG_activate bit, the
+ ClearPageReferenced(page);
line should be removed. That is, let the extra reference record live through it. The point is to smooth out the inter-reference distance. Imagine the following situation:
- + - + + - - + - 1 2 3 4 5
+: reference time
-: shrink_list time
One page have an average inter-reference distance that is smaller than the inter-scan distance. But the distances vary a bit. Here we'd better let the reference count accumulate, or at the 3rd shrink_list time it will be evicted. Though it has a side effect of favoriting non-mmaped file a bit more than before, and I was not quite sure about it.
Quoted 9 lines
inactive list initially contained pages
/* head */ (P1, P2, P3) /* tail */all of them referenced. Then
mark_page_accessed(), is called against P1, P2, and P3 (in that order). With the old code active list would end up/* head */ (P3, P2, P1) /* tail */
Quoted 7 lines
which corresponds to LRU. With delayed page activation, pages are moved to head of the active list in the order they are analyzed by
shrink_list(), which gives/* head */ (P1, P2, P3) /* tail */on the active list, that is _inverse_ LRU order.
Thanks,
Wu
Re: [PATCH 01/16] mm: delayed page activation
Quoted 9 lines · Wu Fengguang
Quoted 8 lines · Nikita Danilov
Quoted 6 lines · Wu Fengguang
When a page is referenced the second time in
inactive_list, mark it withPG_activateinstead of moving it intoactive_listimmediately. The actual moving work is delayed to vmscan time.This implies two essential changes:
- keeps the adjecency of pages in lru;
Quoted 8 lines
Quoted 3 lines
But this change destroys LRU ordering: at the time when
shrink_list()inspectsPG_activatebit, information about order in whichmark_page_accessed()was called against pages is lost. E.g., supposeThanks.
But this order of re-access time may be pointless. In fact the originalmark_page_accessed()is doing another inversion: inversion of page lifetime. In the word of CLOCK-Pro, a page first being re-accessed has lower
The brave new world of CLOCK-Pro is still yet to happen, right?
Quoted 3 lines
inter-reference distance, and therefore should be better protected(if ignore possible read-ahead effects). If we move re-accessed pages immediately into
active_list, we are pushing them closer to danger of eviction.
Huh? Pages in the active list are closer to the eviction? If it is really so, then CLOCK-pro hijacks the meaning of active list in a very unintuitive way. In the current MM active list is supposed to contain hot pages that will be evicted last.
Anyway, these issues should be addressed in CLOCK-pro implementation. Current MM tries hard to maintain LRU approximation in both active and inactive lists.
[...]
Quoted 7 lines
Though I have a strong feeling that with the extra
PG_activatebit, the
+ ClearPageReferenced(page);
line should be removed. That is, let the extra reference record live through it. The point is to smooth out the inter-reference distance. Imagine the following situation:
Quoted 8 lines
- + - + + - - + - 1 2 3 4 5+: reference time
-:shrink_listtimeOne page have an average inter-reference distance that is smaller than the inter-scan distance. But the distances vary a bit. Here we'd better let the reference count accumulate, or at the 3rd
shrink_listtime it will be evicted.
I think this is pretty normal and acceptable variance. Idea is that when system is short on memory scan rate increases together with the precision of reference tracking.
[...]
Quoted 2 lines
Thanks,
Che-che,
Quoted 1 line
Wu
Nikita.
Help!Unable to handle kernel NULL pointer...
hi,
Recently I met some trouble, and need your help. My system is Redhat linux 2.4.20, and crash every few days. There are some messages in '/var/log/messages'as following:
I have had searched the archives and found that some guys met this problem before, but i didn't find the way to fix the trouble.
Is there anybody who would like give me a hand?
Messages:
Nov 27 21:34:54 SHZX-WG04 kernel: <1>Unable to handle kernel NULL pointer dereference at virtual address 00000080 Nov 27 21:34:54 SHZX-WG04 kernel: printing eip: Nov 27 21:34:54 SHZX-WG04 kernel: c012cd07 Nov 27 21:34:54 SHZX-WG04 kernel: *pde = 06a47001 Nov 27 21:34:54 SHZX-WG04 kernel: *pte = 00000000 Nov 27 21:34:54 SHZX-WG04 kernel: Oops: 0000 Nov 27 21:34:54 SHZX-WG04 kernel: ide-cd cdrom lp parport autofs e1000 microcode keybdev mousedev hid input usb-uhci usbcore ext3 jbd aic79xx sd_mod scsi_mod Nov 27 21:34:54 SHZX-WG04 kernel: CPU: 2 Nov 27 21:34:54 SHZX-WG04 kernel: EIP: 0060:[<c012cd07>] Not tainted Nov 27 21:34:54 SHZX-WG04 kernel: EFLAGS: 00010202 Nov 27 21:34:54 SHZX-WG04 kernel: Nov 27 21:34:54 SHZX-WG04 kernel: EIP is at access_process_vm [kernel] 0x27 (2.4.20-8bigmem) Nov 27 21:34:54 SHZX-WG04 kernel: eax: 00000000 ebx: d8d93280 ecx: 00000017 edx: e9910000 Nov 27 21:34:54 SHZX-WG04 kernel: esi: 00000000 edi: e992c000 ebp: e992c000 esp: edde9ef0 Nov 27 21:34:54 SHZX-WG04 kernel: ds: 0068 es: 0068 ss: 0068 Nov 27 21:34:54 SHZX-WG04 kernel: Process ps (pid: 18326, stackpage=edde9000) Nov 27 21:34:54 SHZX-WG04 kernel: Stack: c0160996 e0b9f180 edde9f10 00000202 00000001 00000000 edde9f84 cac05580 Nov 27 21:34:54 SHZX-WG04 kernel: f421800c 00000202 00000000 e992c000 00000000 00000500 000001f0 d8d93280 Nov 27 21:34:54 SHZX-WG04 kernel: 00000000 e992c000 e9910000 c017b334 e9910000 bffffac8 e992c000 00000017 Nov 27 21:34:54 SHZX-WG04 kernel: Call Trace: [<c0160996>] link_path_walk [kernel] 0x656 (0xedde9ef0)) Nov 27 21:34:54 SHZX-WG04 kernel: [<c017b334>] proc_pid_cmdline [kernel] 0x74 (0xedde9f3c)) Nov 27 21:34:54 SHZX-WG04 kernel: [<c017b747>] proc_info_read [kernel] 0x77 (0xedde9f6c)) Nov 27 21:34:54 SHZX-WG04 kernel: [<c0153453>] sys_read [kernel] 0xa3 (0xedde9f94)) Nov 27 21:34:54 SHZX-WG04 kernel: [<c01527d2>] sys_open [kernel] 0xa2 (0xedde9fa8)) Nov 27 21:34:54 SHZX-WG04 kernel: [<c01098bf>] system_call [kernel] 0x33 (0xedde9fc0)) Nov 27 21:34:54 SHZX-WG04 kernel: Nov 27 21:34:54 SHZX-WG04 kernel: Nov 27 21:34:54 SHZX-WG04 kernel: Code: f6 80 80 00 00 00 01 74 2d 81 7c 24
30 40 b7 33 c0 74 23 f0
Tony howe
2005-12-04
Re: [PATCH 01/16] mm: delayed page activation
In reply to Nikita DanilovQuoted 14 lines · Nikita Danilov
Quoted 13 lines · Wu Fengguang
Quoted 11 lines · Nikita Danilov
Quoted 6 lines · Wu Fengguang
When a page is referenced the second time in
inactive_list, mark it withPG_activateinstead of moving it intoactive_listimmediately. The actual moving work is delayed to vmscan time.This implies two essential changes:
- keeps the adjecency of pages in lru;But this change destroys LRU ordering: at the time when
shrink_list()inspectsPG_activatebit, information about order in whichmark_page_accessed()was called against pages is lost. E.g., suppose
Quoted 6 lines
Quoted 4 lines
Thanks.
But this order of re-access time may be pointless. In fact the originalmark_page_accessed()is doing another inversion: inversion of page lifetime. In the word of CLOCK-Pro, a page first being re-accessed has lowerThe brave new world of CLOCK-Pro is still yet to happen, right?
Well, I have an implementation that is showing very promising results. I plan to polish the code a bit and post the code somewhere this week. (current state available at: http://linux-mm.org/PeterZClockPro2)
Quoted 8 lines
Quoted 3 lines
inter-reference distance, and therefore should be better protected(if ignore possible read-ahead effects). If we move re-accessed pages immediately into
active_list, we are pushing them closer to danger of eviction.Huh? Pages in the active list are closer to the eviction? If it is really so, then CLOCK-pro hijacks the meaning of active list in a very unintuitive way. In the current MM active list is supposed to contain hot pages that will be evicted last.
Actually, CLOCK-pro does not have an active list. Pure CLOCK-pro has but one clock. It is possible to create approximations that have more lists/clocks, and in those the meaning of active list are indeed somewhat different, but I agree with nikita here, this is odd.
Quoted 3 lines
Anyway, these issues should be addressed in CLOCK-pro implementation. Current MM tries hard to maintain LRU approximation in both active and inactive lists.
nod.
Peter Zijlstra
(he who has dedicated his spare time to the eradication of LRU ;-)
Re: [PATCH 01/16] mm: delayed page activation
In reply to Nikita DanilovQuoted 8 lines · Nikita Danilov
Quoted 3 lines
inter-reference distance, and therefore should be better protected(if ignore possible read-ahead effects). If we move re-accessed pages immediately into
active_list, we are pushing them closer to danger of eviction.Huh? Pages in the active list are closer to the eviction? If it is really so, then CLOCK-pro hijacks the meaning of active list in a very unintuitive way. In the current MM active list is supposed to contain hot pages that will be evicted last.
The page is going to active list anyway. So its remaining lifetime in inactive list is killed by the early move.
Thanks,
Wu
Re: [PATCH 01/16] mm: delayed page activation
Quoted 5 lines · Wu Fengguang
Quoted 4 lines · Nikita Danilov
Quoted 3 lines
inter-reference distance, and therefore should be better protected(if ignore possible read-ahead effects). If we move re-accessed pages immediately into
active_list, we are pushing them closer to danger of eviction.
Quoted 7 lines
Quoted 4 lines
Huh? Pages in the active list are closer to the eviction? If it is really so, then CLOCK-pro hijacks the meaning of active list in a very unintuitive way. In the current MM active list is supposed to contain hot pages that will be evicted last.
The page is going to active list anyway. So its remaining lifetime in inactive list is killed by the early move.
But this change increased lifetimes of _all_ pages, so this is irrelevant. Consequently, it has a chance of increasing scanning activity, because there will be more referenced pages at the cold tail of the inactive list.
And --again-- this erases information about relative order of references, and this is important. In the past, several VM modifications (like split inactive_clean and inactive_dirty lists) were tried that had various advantages over current scanner, but maintained weaker LRU, and they all were found to degrade horribly under certain easy triggerable conditions.
Quoted 3 lines
Thanks,
Wu
Nikita.
Re: [PATCH 01/16] mm: delayed page activation
Quoted 11 lines · Nikita Danilov
Quoted 10 lines · Wu Fengguang
Quoted 8 lines · Nikita Danilov
Quoted 3 lines
inter-reference distance, and therefore should be better protected(if ignore possible read-ahead effects). If we move re-accessed pages immediately into
active_list, we are pushing them closer to danger of eviction.Huh? Pages in the active list are closer to the eviction? If it is really so, then CLOCK-pro hijacks the meaning of active list in a very unintuitive way. In the current MM active list is supposed to contain hot pages that will be evicted last.
Quoted 4 lines
Quoted 2 lines
The page is going to active list anyway. So its remaining lifetime in inactive list is killed by the early move.
But this change increased lifetimes of _all_ pages, so this is
Yes, it also increased the lifetimes by meaningful values: first re-accessed pages are prolonged more lifetime. Immediately removing them from inactive_list is basicly doing MRU eviction.
Quoted 3 lines
irrelevant. Consequently, it has a chance of increasing scanning activity, because there will be more referenced pages at the cold tail of the inactive list.
Delayed activation increased scanning activity, while immediate activation increased the locking activity. Early profiling data on a 2 CPU Xeon box showed that the delayed activation acctually cost less time.
Quoted 6 lines
And --again-- this erases information about relative order of references, and this is important. In the past, several VM modifications (like split
inactive_cleanandinactive_dirtylists) were tried that had various advantages over current scanner, but maintained weaker LRU, and they all were found to degrade horribly under certain easy triggerable conditions.
Yeah, the patch does need more testing.
It has been in -ck tree for a while, and there's no negative report about it.
Andrew, and anyone in the lkml, do you feel ok to test it in -mm tree? It is there because some readahead code test the PG_actvation bit explicitly. If the answer is 'not for now', I'll strip it out from the readahead patchset in the next version.
Thanks,
Wu
Re: [PATCH 01/16] mm: delayed page activation
Quoted 2 lines · Wu Fengguang
Andrew, and anyone in the lkml, do you feel ok to test it in -mm tree?
Nope, sorry. I am wildly uninterested in large changes to page reclaim. Or to readahead, come to that.
That code has had years of testing, tweaking, tuning and poking. Large changes such as these will take as long as a year to get settled into the same degree of maturity. Both of these parts of the kernel are similar in that they are hit with an extraordinarly broad range of usage patterns and they both implement various predict-the-future heuristics. They are subtle and there is a lot of historical knowledge embedded in there.
What I would encourage you to do is to stop developing and testing new code. Instead, devote more time to testing, understanding and debugging the current code. If you find and fix a problem and can help us gain a really really really good understanding of the problem and the fix then great, we can run with that minimal-sized, minimal-impact, well-understood, well-tested fix.
See where I'm coming from? Experience teaches us to be super-cautious here. In these code areas especially we cannot afford to go making larger-than-needed changes because those changes will probably break things in ways which will take a long time to discover, and longer to re-fix.
Re: [PATCH 01/16] mm: delayed page activation
Quoted 21 lines · Andrew Morton
Quoted 2 lines · Wu Fengguang
Andrew, and anyone in the lkml, do you feel ok to test it in -mm tree?
Nope, sorry. I am wildly uninterested in large changes to page reclaim. Or to readahead, come to that.
That code has had years of testing, tweaking, tuning and poking. Large changes such as these will take as long as a year to get settled into the same degree of maturity. Both of these parts of the kernel are similar in that they are hit with an extraordinarly broad range of usage patterns and they both implement various predict-the-future heuristics. They are subtle and there is a lot of historical knowledge embedded in there.
What I would encourage you to do is to stop developing and testing new code. Instead, devote more time to testing, understanding and debugging the current code. If you find and fix a problem and can help us gain a really really really good understanding of the problem and the fix then great, we can run with that minimal-sized, minimal-impact, well-understood, well-tested fix.
Quoted 4 lines
See where I'm coming from? Experience teaches us to be super-cautious here. In these code areas especially we cannot afford to go making larger-than-needed changes because those changes will probably break things in ways which will take a long time to discover, and longer to re-fix.
Ok, thanks for the advise.
My main concern is in read-ahead. The new development stopped roughly from V8. Various parts have been improving based on user feedbacks since V6. The future work would be more testings/tunings and user interactions. Till now I have received many user reports on both server/desktop, things are going on well :)
Regards,
Wu
Re: [PATCH 01/16] mm: delayed page activation
In reply to Wu FengguangQuoted 1 line · Wu Fengguang
On Tue, Dec 06, 2005 at 08:55:13PM +0300, Nikita Danilov wrote:
[...]
Quoted 6 lines
Quoted 2 lines
But this change increased lifetimes of _all_ pages, so this is
Yes, it also increased the lifetimes by meaningful values: first re-accessed pages are prolonged more lifetime. Immediately removing them from
inactive_listis basicly doing MRU eviction.
Are you talking about CLOCK-pro here? I don't understand your statement in the context of current VM: if the "first re-accessed" page was close to the cold tail of the inactive list, and "second re-accessed" page was close to the head of the inactive list, then life-time of second one is increased by larger amount.
Quoted 8 lines
Quoted 4 lines
irrelevant. Consequently, it has a chance of increasing scanning activity, because there will be more referenced pages at the cold tail of the inactive list.
Delayed activation increased scanning activity, while immediate activation increased the locking activity. Early profiling data on a 2 CPU Xeon box showed that the delayed activation acctually cost less time.
That's great, but current mark_page_accessed() has an important
advantage: the work is done by the process that accessed the page in read/write path, or at page fault. By delegating activation to the VM scanner, the burden of work is shifted to the innocent thread that happened to trigger scanning during page allocation.
It's basically always useful to follow the principle that the thread that used resources pays the overhead. This leads to more balanced behavior with better worst-case.
Compare this with balance_dirty_pages() that throttles heavy writers by forcing them to do the write-out. In the same vein, mark_page_accessed() throttles thread (a bit) by forcing it to book-keep VM lists. Ideally, threads doing a lot of page allocations, should be forced to do some scanning, even if there is no memory shortage, etc.
As for locking overhead, mark_page_accessed() can be batched (I even have a patch to do this, but it doesn't show any improvement).
Quoted 3 lines
Thanks,
Wu
Nikita.
Re: [PATCH 01/16] mm: delayed page activation
Quoted 10 lines · Nikita Danilov
Quoted 3 lines · Wu Fengguang
Yes, it also increased the lifetimes by meaningful values: first re-accessed pages are prolonged more lifetime. Immediately removing them from
inactive_listis basicly doing MRU eviction.Are you talking about CLOCK-pro here? I don't understand your statement in the context of current VM: if the "first re-accessed" page was close to the cold tail of the inactive list, and "second re-accessed" page was close to the head of the inactive list, then life-time of second one is increased by larger amount.
Sorry, I fail to mention that I'm comparing two pages that are read in at the same time, therefore they are in the same place in inactive_list. But their re-access time can be quite different.
There are roughly two kinds of reads: almost instantly and slowly forward. For the former one, read-in-time = first-access-time, unless for initial cache misses. The latter one is the original purpose of of the patch: to keep one chunk of read-ahead pages together, instead of let them littering throughout the lru list.
Quoted 9 lines
Quoted 3 lines
Delayed activation increased scanning activity, while immediate activation increased the locking activity. Early profiling data on a 2 CPU Xeon box showed that the delayed activation acctually cost less time.
That's great, but current
mark_page_accessed()has an important
advantage: the work is done by the process that accessed the page in read/write path, or at page fault. By delegating activation to the VM scanner, the burden of work is shifted to the innocent thread that happened to trigger scanning during page allocation.
Thanks to notice it. It will happen in the direct page reclaim path. But I have just made interesting tests of the patch, in which direct page reclaims were reduced to zero. Till now I have no hint of why this is happening :)
Wu
PATCH 2/16 radixtree: sync with mainline
In reply to Wu FengguangThe patch from Christoph Lameter:
[PATCH] radix-tree: Remove unnecessary indirections and clean up code
is only partially merged into -mm tree. This patch completes it.
---
lib/radix-tree.c | 12 +++++------- 1 files changed, 5 insertions(+), 7 deletions(-)
lib/radix-tree.c +5 -7
@@ -291,27 +291,25 @@ static inline void **__lookup_slot(struc unsigned long index) {unsigned int height, shift; -struct radix_tree_node **slot; +struct radix_tree_node *slot; height = root->height;if (index >radix_tree_maxindex (height))return NULL ; shift = (height-1 ) *RADIX_TREE_MAP_SHIFT ; - slot = &root->rnode; + slot = root->rnode;while (height >0 ) { -if (*slot ==NULL ) +if (slot ==NULL )return NULL ; - slot = (struct radix_tree_node **) - ((*slot)->slots + - ((index >> shift) &RADIX_TREE_MAP_MASK )); + slot = slot->slots[(index >> shift) &RADIX_TREE_MAP_MASK ]; shift -=RADIX_TREE_MAP_SHIFT ; height--; } -return (void **)slot; +return slot; }/**
--
Re: [PATCH 02/16] radixtree: sync with mainline
Quoted 4 lines · Wu Fengguang
[PATCH] radix-tree: Remove unnecessary indirections and clean up code
is only partially merged into -mm tree. This patch completes it.
md: autorun ...
md: ... autorun DONE.
Unable to handle kernel paging request at virtual address 8000003c printing eip: c013e16f *pde = 00000000 Oops: 0000 [#1] SMP Modules linked in: CPU: 1 EIP: 0060:[<c013e16f>] Not tainted VLI EFLAGS: 00010086 (2.6.15-rc5-mm1)
EIP is at find_get_page+0x2e/0x4e
eax: 8000003c ebx: cff867e8 ecx: 8000003c edx: 8000003c
esi: cff867e8 edi: 00000000 ebp: cffafd44 esp: cffafd38
ds: 007b es: 007b ss: 0068
Process swapper (pid: 1, threadinfo=cffae000 task=cffa1a90)
Stack: <0>cff867ec 00000000 00042454 cffafdcc c013e5e7 cff867e8 00000000 cfcc62
<0>00000000 00000001 cffafdcc c02406b3 00001000 00000000 00042454 000000
<0>ffffffff 00000001 00000001 00000000 00000042 cff8673c 00000000 000000
Call Trace:
[<c0103b3b>] show_stack+0x8c/0xa2
[<c0103cd0>] show_registers+0x15d/0x1c5
[<c0103ed2>] die+0x10e/0x196
[<c048073a>] do_page_fault+0x34c/0x6b5
[<c01037ef>] error_code+0x4f/0x54
[<c013e5e7>] do_generic_mapping_read+0x13a/0x4ad
[<c013ec14>] __generic_file_aio_read+0x1c8/0x20c
[<c013ed63>] generic_file_read+0xa2/0xbb
[<c015ec94>] vfs_read+0xd4/0x19e
[<c015f02e>] sys_read+0x4b/0x75
[<c060f118>] identify_ramdisk_image+0x78/0x1ca
[<c060f2e3>] rd_load_image+0x79/0x317
[<c06119a9>] initrd_load+0x43/0x7d
[<c060ef4b>] prepare_namespace+0x3d/0x131
[<c01003f1>] init+0xe6/0x1d9
[<c01010dd>] kernel_thread_helper+0x5/0xb
Code: 83 ec 0c 89 5d fc 8b 5d 08 8d 43 10 e8 05 1d 34 00 8b 45 0c 89 44 24 04 8
<0>Kernel panic - not syncing: Attempted to kill init! Re: [PATCH 02/16] radixtree: sync with mainline
Quoted 18 lines · Andrew Morton
Quoted 4 lines · Wu Fengguang
[PATCH] radix-tree: Remove unnecessary indirections and clean up code
is only partially merged into -mm tree. This patch completes it.
md: autorun ...
md: ... autorun DONE.Unable to handle kernel paging request at virtual address 8000003c printing eip: c013e16f *pde = 00000000 Oops: 0000 [#1] SMP Modules linked in: CPU: 1 EIP: 0060:[<c013e16f>] Not tainted VLI EFLAGS: 00010086 (2.6.15-rc5-mm1)
Quoted 1 line
EIP is at
find_get_page+0x2e/0x4e
It has been running ok on several machines for over a month. A mysterious bug mysteriously corrected by the following radix-tree look-aside cache patch? I'll test this single patch against -mm tree, thanks.
Wu
Re: [PATCH 02/16] radixtree: sync with mainline
In reply to Andrew MortonQuoted 18 lines · Andrew Morton
Quoted 4 lines · Wu Fengguang
[PATCH] radix-tree: Remove unnecessary indirections and clean up code
is only partially merged into -mm tree. This patch completes it.
md: autorun ...
md: ... autorun DONE.Unable to handle kernel paging request at virtual address 8000003c printing eip: c013e16f *pde = 00000000 Oops: 0000 [#1] SMP Modules linked in: CPU: 1 EIP: 0060:[<c013e16f>] Not tainted VLI EFLAGS: 00010086 (2.6.15-rc5-mm1)
Quoted 1 line
EIP is at
find_get_page+0x2e/0x4e
It is reproduced here on linux-2.6.15-rc3-mm1 with this single patch. I'm using qemu, and its screen outputs are not accessible. So I added some delays to the dump code, and grabbed two screen shots.
Wu
arch/i386/kernel/traps.c +4 -0
@@ -158,6 +158,7 @@ static inline unsigned long print_contexprintk (" [<%08lx>] " , addr);print_symbol ("%s" , addr);printk ("\n" ); +mdelay (1000 ); ebp = *(unsigned long *)ebp; }#else
@@ -167,6 +168,7 @@ static inline unsigned long print_contexprintk (" [<%08lx>]" , addr);print_symbol (" %s" , addr);printk ("\n" ); + mdelay(1000); } }#endif
@@ -257,6 +259,7 @@ void show_registers(struct pt_regs *regssmp_processor_id (),0xffff & regs->xcs, regs->eip, print_tainted(), regs->eflags, system_utsname.release);print_symbol ("EIP is at %s\n" , regs->eip); +mdelay (5000 );printk ("eax: %08lx ebx: %08lx ecx: %08lx edx: %08lx\n" , regs->eax, regs->ebx, regs->ecx, regs->edx); printk("esi: %08lx edi: %08lx ebp: %08lx esp: %08lx\n",
@@ -265,6 +268,7 @@ void show_registers(struct pt_regs *regs regs->xds & 0xffff, regs->xes & 0xffff, ss);printk ("Process %s (pid: %d, threadinfo=%p task=%p)" , current->comm, current->pid,current_thread_info (), current); +mdelay (5000 );/* * When in-kernel, we also print out the stack and code at the * time of the fault..
Re: [PATCH 02/16] radixtree: sync with mainline
Quoted 3 lines · Wu Fengguang
It is reproduced here on linux-2.6.15-rc3-mm1 with this single patch. I'm using qemu, and its screen outputs are not accessible. So I added some delays to the dump code, and grabbed two screen shots.
Lets drop this patch. __lookup_slot returns a pointer to the slot element and this patch changes the behavior of __lookup_slot making it return the contents of the slot. Without the indirection the address of the slot is not available so we need to keep the indirections in __lookup_slot.
Re: [PATCH 02/16] radixtree: sync with mainline
In reply to Andrew MortonQuoted 9 lines · Andrew Morton
Quoted 4 lines · Wu Fengguang
[PATCH] radix-tree: Remove unnecessary indirections and clean up code
is only partially merged into -mm tree. This patch completes it.
md: autorun ...
md: ... autorun DONE.Unable to handle kernel paging request at virtual address 8000003c
Sorry, the bug is caused by the returning line:
return slot;
It should be
return &slot;
The patch originally applies to
void *radix_tree_lookup()
But in -mm the function turns into
void **__lookup_slot()
And in my radixtree patch, it is
void *radix_tree_lookup_node()
The prototypes changed forth and back, so the problem was never discovered.
Wu
Subject: radixtree: sync with mainline
Cc: Christoph Lameter <[email protected]>
The patch from Christoph Lameter:
[PATCH] radix-tree: Remove unnecessary indirections and clean up code
is only partially merged into -mm tree. This patch completes it.
lib/radix-tree.c | 12 +++++------- 1 files changed, 5 insertions(+), 7 deletions(-)
lib/radix-tree.c +5 -7
@@ -291,27 +291,25 @@ static inline void **__lookup_slot(struc unsigned long index) {unsigned int height, shift; -struct radix_tree_node **slot; +struct radix_tree_node *slot; height = root->height;if (index >radix_tree_maxindex (height))return NULL ; shift = (height-1 ) *RADIX_TREE_MAP_SHIFT ; - slot = &root->rnode; + slot = root->rnode;while (height >0 ) { -if (*slot ==NULL ) +if (slot ==NULL )return NULL ; - slot = (struct radix_tree_node **) - ((*slot)->slots + - ((index >> shift) &RADIX_TREE_MAP_MASK )); + slot = slot->slots[(index >> shift) &RADIX_TREE_MAP_MASK ]; shift -=RADIX_TREE_MAP_SHIFT ; height--; } -return (void **)slot; +return &slot; }/**
Re: [PATCH 02/16] radixtree: sync with mainline
Quoted 5 lines · Wu Fengguang
return slot;It should be
return &slot;
That wont work. slot is a local variable. Drop this patch please.
Re: [PATCH 02/16] radixtree: sync with mainline
Quoted 9 lines · Christoph Lameter
Quoted 5 lines · Wu Fengguang
return slot;It should be
return &slot;That wont work. slot is a local variable. Drop this patch please.
Thanks. Sorry for the careless mistake.
But your patch do fit well in my patch :)
void *radix_tree_lookup_node(struct radix_tree_root *root,
unsigned long index, unsigned int level)
{
unsigned int height, shift;
struct radix_tree_node *slot;
height = root->height;
if (index > radix_tree_maxindex(height))
return NULL;
shift = (height-1) * RADIX_TREE_MAP_SHIFT;
slot = root->rnode;
while (height > level) {
if (slot == NULL)
return NULL;
slot = slot->slots[(index >> shift) & RADIX_TREE_MAP_MASK];
shift -= RADIX_TREE_MAP_SHIFT;
height--;
}
return slot;
}void **radix_tree_lookup_slot(struct radix_tree_root *root, unsigned long index)
{
struct radix_tree_node *node;
node = radix_tree_lookup_node(root, index, 1);
return node->slots + (index & RADIX_TREE_MAP_MASK);
}PATCH 3/16 radixtree: look-aside cache
In reply to Wu FengguangThis introduces a set of lookup functions to radix tree for the read-ahead logic. Other access patterns with high locality may also benefit from them.
- radix_tree_lookup_node(root, index, level)
Perform partial lookup, return the @level'th parent of the slot at @index.
- radix_tree_cache_xxx()
Init/Query the cache.
- radix_tree_cache_lookup(root, cache, index)
Perform lookup with the aid of a look-aside cache.
For sequential scans, it has a time complexity of 64*O(1) + 1*O(logn).
Typical usage:
void func() {
+ struct radix_tree_cache cache;
+
+ radix_tree_cache_init(&cache);
read_lock_irq(&mapping->tree_lock);
for(;;) {
- page = radix_tree_lookup(&mapping->page_tree, index);
+ page = radix_tree_cache_lookup(&mapping->page_tree, &cache, index);
}
read_unlock_irq(&mapping->tree_lock);
} - radix_tree_lookup_head(root, index, max_scan)
- radix_tree_lookup_tail(root, index, max_scan)
Assume [head, tail) to be a segment with continuous pages. The two functions search for the head and tail index of the segment at @index.
---
include/linux/radix-tree.h | 80 +++++++++++++++++- lib/radix-tree.c | 196 ++++++++++++++++++++++++++++++++++++++++----- 2 files changed, 254 insertions(+), 22 deletions(-)
include/linux/radix-tree.h +78 -2
@@ -22,12 +22,24 @@#include <linux/preempt.h> #include <linux/types.h> +#define RADIX_TREE_MAP_SHIFT 6 +#define RADIX_TREE_MAP_SIZE (1UL << RADIX_TREE_MAP_SHIFT) +#define RADIX_TREE_MAP_MASK (RADIX_TREE_MAP_SIZE-1) +struct radix_tree_root {unsigned int height;gfp_t gfp_mask;struct radix_tree_node *rnode; }; +/* +* Support access patterns with strong locality. +*/ +struct radix_tree_cache { +unsigned long first_index; +struct radix_tree_node *tree_node; +}; +#define RADIX_TREE_INIT (mask) { \ .height = 0, \ .gfp_mask = (mask), \
@@ -45,9 +57,18 @@ do { \ }while (0 ) int radix_tree_insert(struct radix_tree_root *, unsigned long, void *); -void *radix_tree_lookup (struct radix_tree_root *,unsigned long ); -void **radix_tree_lookup_slot (struct radix_tree_root *,unsigned long ); +void *radix_tree_lookup_node (struct radix_tree_root *,unsigned long , +unsigned int ); +void **radix_tree_lookup_slot (struct radix_tree_root *root,unsigned long );void *radix_tree_delete (struct radix_tree_root *,unsigned long ); +int radix_tree_cache_count (struct radix_tree_cache *cache); +void *radix_tree_cache_lookup_node (struct radix_tree_root *root, +struct radix_tree_cache *cache, +unsigned long index,unsigned int level); +unsigned long radix_tree_lookup_head (struct radix_tree_root *root, +unsigned long index,unsigned int max_scan); +unsigned long radix_tree_lookup_tail (struct radix_tree_root *root, +unsigned long index,unsigned int max_scan);unsigned int radix_tree_gang_lookup (struct radix_tree_root *root,void **results,unsigned long first_index,unsigned int max_items);
@@ -69,4 +90,59 @@ static inline void radix_tree_preload_en preempt_enable(); } +/** +* radix_tree_lookup - perform lookup operation on a radix tree +* @root: radix tree root +* @index: index key +* +* Lookup the item at the position @index in the radix tree @root. +*/ +static inline void *radix_tree_lookup (struct radix_tree_root *root, +unsigned long index) +{ +return radix_tree_lookup_node (root, index,0 ); +} + +/** +* radix_tree_cache_init - init the cache +* @cache: look-aside cache +* +* Init the @cache. +*/ +static inline void radix_tree_cache_init (struct radix_tree_cache *cache) +{ + cache->first_index =RADIX_TREE_MAP_MASK ; + cache->tree_node =NULL ; +} + +/** +* radix_tree_cache_lookup - cached lookup page +* @root: radix tree root +* @cache: look-aside cache +* @index: index key +* +* Lookup the item at the position @index in the radix tree @root. +*/ +static inline void *radix_tree_cache_lookup (struct radix_tree_root *root, +struct radix_tree_cache *cache, +unsigned long index) +{ +return radix_tree_cache_lookup_node (root, cache, index,0 ); +} + +static inline int radix_tree_cache_size (struct radix_tree_cache *cache) +{ +return RADIX_TREE_MAP_SIZE ; +} + +static inline int radix_tree_cache_full (struct radix_tree_cache *cache) +{ +return radix_tree_cache_count (cache) ==radix_tree_cache_size (cache); +} + +static inline int radix_tree_cache_first_index (struct radix_tree_cache *cache) +{ +return cache->first_index; +} +#endif /* _LINUX_RADIX_TREE_H */
lib/radix-tree.c +176 -20
238 lines not on this page · raw message
--
PATCH 4/16 readahead: some preparation
In reply to Wu FengguangSome random changes that do not fit in elsewhere.
---
include/linux/mm.h | 7 + mm/filemap.c | 4 + mm/readahead.c | 198 ++++++++++++++++++++++++++++++++++++++++++++++++++--- 3 files changed, 200 insertions(+), 9 deletions(-)
include/linux/mm.h +7 -0
@@ -1009,6 +1009,13 @@ void handle_ra_miss(struct address_space struct file_ra_state *ra, pgoff_t offset);unsigned long max_sane_readahead (unsigned long nr); +#ifdef CONFIG_DEBUG_FS +extern u32 readahead_debug_level; +#define READAHEAD_DEBUG_LEVEL (n) (readahead_debug_level >= n) +#else +#define READAHEAD_DEBUG_LEVEL (n) (0) +#endif +/* Do stack extension */ extern int expand_stack (struct vm_area_struct *vma,unsigned long address);#ifdef CONFIG_IA64
mm/readahead.c +189 -9
264 lines not on this page · raw message
mm/filemap.c +4 -0
@@ -780,6 +780,10 @@ void do_generic_mapping_read(struct addrif (!isize) goto out; +if (READAHEAD_DEBUG_LEVEL (5 )) +printk (KERN_DEBUG "read-file(ino=%lu, req=%lu+%lu)\n" , + inode->i_ino, index, last_index - index); + end_index = (isize -1 ) >>PAGE_CACHE_SHIFT ;for (;;) {struct page *page;
--
PATCH 5/16 readahead: call scheme
In reply to Wu FengguangAn new page flag PG_readahead is introduced as a look-ahead mark. The look-ahead mark corresponds to `ahead_start' of the current logic.
The read-ahead logic is called when
- read reaches a look-ahead mark;
- read on a non-present page.
And ra_access() is called on every page reference to maintain the cache_hit counter.
This scheme has the following benefits:
- makes all stateful/stateless methods happy;
- eliminates the cache hit problem naturally;
- lives in harmony with application managed read-aheads via fadvise/madvise.
---
include/linux/mm.h | 13 +++ include/linux/page-flags.h | 5 + mm/filemap.c | 73 ++++++++++++++++-- mm/page_alloc.c | 2 mm/readahead.c | 176 +++++++++++++++++++++++++++++++++++++++++++++ 5 files changed, 258 insertions(+), 11 deletions(-)
include/linux/page-flags.h +5 -0
@@ -77,6 +77,7 @@#define PG_nosave_free 18/* Free, should not be written */ #define PG_uncached 19/* Page has been mapped as uncached */ #define PG_activate 20/* delayed activate */ +#define PG_readahead 21/* check readahead when reading this page */ /* * Global page accounting. One instance per CPU. Only unsigned longs are
@@ -321,6 +322,10 @@ extern void __mod_page_state(unsigned lo#define TestClearPageActivate (page) test_and_clear_bit(PG_activate, &(page)->flags)#define TestSetPageActivate (page) test_and_set_bit(PG_activate, &(page)->flags) +#define PageReadahead (page) test_bit(PG_readahead, &(page)->flags) +#define SetPageReadahead (page) set_bit(PG_readahead, &(page)->flags) +#define TestClearPageReadahead (page) test_and_clear_bit(PG_readahead, &(page)->flags) +struct page ;/* forward declaration */ int test_clear_page_dirty (struct page *page);
include/linux/mm.h +13 -0
@@ -1008,6 +1008,13 @@ unsigned long page_cache_readahead(strucvoid handle_ra_miss (struct address_space *mapping,struct file_ra_state *ra,pgoff_t offset);unsigned long max_sane_readahead (unsigned long nr); +unsigned long +page_cache_readahead_adaptive (struct address_space *mapping, +struct file_ra_state *ra,struct file *filp, +struct page *prev_page,struct page *page, +pgoff_t first_index, +pgoff_t index,pgoff_t last_index); +void fastcall ra_access(struct file_ra_state *ra, struct page *page);#ifdef CONFIG_DEBUG_FS extern u32 readahead_debug_level;
@@ -1016,6 +1023,12 @@ extern u32 readahead_debug_level;#define READAHEAD_DEBUG_LEVEL (n) (0)#endif +extern int readahead_ratio; +static inline int prefer_adaptive_readahead (void ) +{ +return readahead_ratio >9 ; +} +/* Do stack extension */ extern int expand_stack (struct vm_area_struct *vma,unsigned long address);#ifdef CONFIG_IA64
mm/page_alloc.c +1 -1
@@ -543,7 +543,7 @@ static int prep_new_page(struct page *pa page->flags &= ~(1 << PG_uptodate |1 << PG_error |1 << PG_referenced |1 << PG_arch_1 | -1 << PG_activate | +1 << PG_activate |1 << PG_readahead |1 << PG_checked |1 << PG_mappedtodisk);set_page_private (page,0 );set_page_refs (page, order);
mm/filemap.c +63 -10
177 lines not on this page · raw message
mm/readahead.c +176 -0
185 lines not on this page · raw message
--
PATCH 6/16 readahead: parameters
In reply to Wu Fengguang- new sysctl entries in /proc/sys/vm:
- readahead_ratio = 50
- readahead_hit_rate = 2
- readahead_live_chunk = 0
- dynamic minimal/initial read-ahead size.
For now, different ranges of readahead_ratio select different read-ahead code path:
condition action
===================================================================readahead_ratio == 0 disable read-aheadreadahead_ratio < 9 select old read-ahead logicreadahead_ratio >= 9 select new read-ahead logic
---
Documentation/sysctl/vm.txt | 46 ++++++++++++++++++++++++++++++++++++++++++++ include/linux/mm.h | 2 - include/linux/sysctl.h | 3 ++ kernel/sysctl.c | 34 ++++++++++++++++++++++++++++++++ mm/readahead.c | 39 +++++++++++++++++++++++++++++++++++++ 5 files changed, 123 insertions(+), 1 deletion(-)
Documentation/sysctl/vm.txt +46 -0
@@ -27,6 +27,9 @@ Currently, these files are in /proc/sys/ - laptop_mode - block_dump - swap_prefetch +- readahead_ratio +- readahead_hit_rate +- readahead_live_chunk ==============================================================
@@ -114,3 +117,46 @@ except when laptop_mode is enabled and t Setting it to 0 disables prefetching entirely. The default value is dependant on ramsize. + +============================================================== + +readahead_ratio + +This limits read-ahead size to percent of the thrashing-threshold. +The thrashing-threshold is dynamicly estimated according to the +_history_ read speed and system load, and used to limit the +_future_ read-ahead request size. + +Set it to a low value if you have not enough memory to counteract +the I/O load fluctuations. But if there's plenty of memory, set it +to a larger value might help increase read speed. + +The default value is 50. + +============================================================== + +readahead_hit_rate + +This is the max allowed value of (read-ahead-pages : accessed-pages). +If the previous read-ahead request has bad hit rate, kernel will be +very conservative to issue the next read-ahead. + +A large value helps speedup some sparse access patterns, at the cost +of more memory consumption. It is recommended to keep the value below +(max-readahead-pages / 8). + +The default value is 2. + +============================================================== + +readahead_live_chunk + +In a file server, there are typically one or more sequential +readers working on a file. The kernel can detect most live +chunks(a sequence of pages to be accessed by an active reader), +and save them for their imminent readers. + +This parameter controls the max allowed chunk size, i.e. the max +number of pages pinned for an active reader. + +The default value is 0(off). Increase it if you have enough memory.
include/linux/mm.h +1 -1
@@ -991,7 +991,7 @@ extern int filemap_populate(struct vm_arint write_one_page (struct page *page,int wait);/* readahead.c */ -#define VM_MAX_READAHEAD 128/* kbytes */ +#define VM_MAX_READAHEAD 1024/* kbytes */ #define VM_MIN_READAHEAD 16/* kbytes (includes current page) */ #define VM_MAX_CACHE_HIT 256/* max pages in a row in cache before * turning readahead off */
include/linux/sysctl.h +3 -0
@@ -182,6 +182,9 @@ enumVM_LEGACY_VA_LAYOUT =27 ,/* legacy/compatibility virtual address space layout */ VM_SWAP_TOKEN_TIMEOUT =28 ,/* default time for token time out */ VM_SWAP_PREFETCH =29 ,/* int: amount to swap prefetch */ +VM_READAHEAD_RATIO =30 ,/* percent of read-ahead size to thrashing-threshold */ +VM_READAHEAD_HIT_RATE =31 ,/* one accessed page legitimizes so many read-ahead pages */ + VM_READAHEAD_LIVE_CHUNK=32, /* pin no more than that many pages for a live reader */ };
kernel/sysctl.c +34 -0
@@ -68,6 +68,9 @@ extern int min_free_kbytes;extern int printk_ratelimit_jiffies;extern int printk_ratelimit_burst;extern int pid_max_min, pid_max_max; +extern int readahead_ratio; +extern int readahead_hit_rate; +extern int readahead_live_chunk;#if defined(CONFIG_X86_LOCAL_APIC ) && defined(CONFIG_X86 )int unknown_nmi_panic;
@@ -668,6 +671,7 @@ static ctl_table kern_table[] = {/* Constants for minimum and maximum testing in vm_table. We use these as one-element integer vectors. */ static int zero; +static int one =1 ;static int one_hundred =100 ;
@@ -867,6 +871,36 @@ static ctl_table vm_table[] = { },#endif #endif + { + .ctl_name = VM_READAHEAD_RATIO, + .procname = "readahead_ratio", + .data = &readahead_ratio, + .maxlen = sizeof(readahead_ratio), + .mode = 0644, + .proc_handler = &proc_dointvec, + .strategy = &sysctl_intvec, + .extra1 = &zero, + }, + { + .ctl_name = VM_READAHEAD_HIT_RATE, + .procname = "readahead_hit_rate", + .data = &readahead_hit_rate, + .maxlen = sizeof(readahead_hit_rate), + .mode = 0644, + .proc_handler = &proc_dointvec, + .strategy = &sysctl_intvec, + .extra1 = &one, + }, + { + .ctl_name = VM_READAHEAD_LIVE_CHUNK, + .procname = "readahead_live_chunk", + .data = &readahead_live_chunk, + .maxlen = sizeof(readahead_live_chunk), + .mode = 0644, + .proc_handler = &proc_dointvec, + .strategy = &sysctl_intvec, + .extra1 = &zero, + }, { .ctl_name = 0 } };
mm/readahead.c +39 -0
@@ -20,6 +20,24 @@#define MAX_RA_PAGES KB(VM_MAX_READAHEAD)#define MIN_RA_PAGES KB(VM_MIN_READAHEAD) +/* In laptop mode, poll delayed look-ahead on every ## pages read. */ +#define LAPTOP_POLL_INTERVAL 16 + +/* Set look-ahead size to 1/# of the thrashing-threshold. */ +#define LOOKAHEAD_RATIO 8 + +/* Set read-ahead size to ##% of the thrashing-threshold. */ +int readahead_ratio =50 ; +EXPORT_SYMBOL (readahead_ratio); + +/* Readahead as long as cache hit ratio keeps above 1/##. */ +int readahead_hit_rate =2 ; +EXPORT_SYMBOL (readahead_hit_rate); + +/* Scan backward ## pages to find a live reader. */ +int readahead_live_chunk =0 ; +EXPORT_SYMBOL (readahead_live_chunk); +/* Detailed classification of read-ahead behaviors. */ #define RA_CLASS_SHIFT 4#define RA_CLASS_MASK ((1 << RA_CLASS_SHIFT) - 1)
@@ -796,6 +814,27 @@ out: }/* +* ra_size is mainly determined by: +* 1. sequential-start: min(MIN_RA_PAGES + (pages>>14), KB(128)) +* 2. sequential-max: min(ra->ra_pages, 0xFFFF) +* 3. sequential: (thrashing-threshold) * readahead_ratio / 100 +* +* Table of concrete numbers for 4KB page size: +* (inactive + free) (in MB): 4 8 16 32 64 128 256 512 1024 +* initial ra_size (in KB): 16 16 16 16 20 24 32 48 64 +*/ +static inline void get_readahead_bounds (struct file_ra_state *ra, +unsigned long *ra_min, +unsigned long *ra_max) +{ +unsigned long pages; + + pages =node_free_and_cold_pages (); + *ra_max =min (min (pages/2 ,0xFFFFUL ), ra->ra_pages); + *ra_min =min (min (MIN_RA_PAGES + (pages>>14 ),KB (128 )), *ra_max/2 ); +} + +/* * This is the entry point of the adaptive read-ahead logic. * * It is only called on two conditions:
--
PATCH 7/16 readahead: state based method
In reply to Wu FengguangThis is the fast code path.
Major steps:
- estimate a thrashing safe ra_size;
- assemble the next read-ahead request in file_ra_state;
- submit it.
---
include/linux/fs.h | 20 ++ include/linux/mm.h | 6 mm/memory.c | 1 mm/readahead.c | 358 +++++++++++++++++++++++++++++++++++++++++++++++++++++ mm/swap.c | 2 mm/vmscan.c | 3 6 files changed, 384 insertions(+), 6 deletions(-)
include/linux/fs.h +14 -6
@@ -601,16 +601,24 @@ struct fown_struct {* Track a single file's readahead state */ struct file_ra_state { +/* conventional read-ahead */ unsigned long start;/* Current window */ unsigned long size; -unsigned long flags;/* ra flags RA_FLAG_xxx*/ -unsigned long cache_hit;/* cache hit count*/ -unsigned long prev_page;/* Cache last read() position */ unsigned long ahead_start;/* Ahead window */ unsigned long ahead_size; -unsigned long ra_pages;/* Maximum readahead window */ -unsigned long mmap_hit;/* Cache hit stat for mmap accesses */ -unsigned long mmap_miss;/* Cache miss stat for mmap accesses */ + +/* adaptive read-ahead */ +unsigned long age; +pgoff_t la_index; +pgoff_t ra_index; +pgoff_t lookahead_index; +pgoff_t readahead_index; + +/* shared */ +uint64_t cache_hit;/* cache hit count*/ +unsigned long flags;/* ra flags RA_FLAG_xxx*/ +unsigned long prev_page;/* Cache last read() position */ +unsigned long ra_pages;/* Maximum readahead window */ };#define RA_FLAG_MISS 0x01/* a cache miss occured against this file */ #define RA_FLAG_INCACHE 0x02/* file is already in cache */
include/linux/mm.h +6 -0
@@ -1029,6 +1029,12 @@ static inline int prefer_adaptive_readahreturn readahead_ratio >9 ; } +DECLARE_PER_CPU(unsigned long, readahead_aging); +static inline void inc_readahead_aging (void ) +{ +__get_cpu_var (readahead_aging)++; +} +/* Do stack extension */ extern int expand_stack (struct vm_area_struct *vma,unsigned long address);#ifdef CONFIG_IA64
mm/memory.c +1 -0
@@ -1986,6 +1986,7 @@ static int do_anonymous_page(struct mm_s page_table =pte_offset_map_lock (mm, pmd, address, &ptl);if (!pte_none (*page_table)) goto release; +inc_readahead_aging ();inc_mm_counter (mm, anon_rss);lru_cache_add_active (page);SetPageReferenced (page);
mm/vmscan.c +3 -0
@@ -460,6 +460,9 @@ static int shrink_list(struct list_head goto activate_locked; } +if (!PageReferenced (page)) +inc_readahead_aging (); + referenced =page_referenced (page,1 );/* In active use or really unfreeable? Activate it. */ if (referenced &&page_mapping_inuse (page))
mm/swap.c +2 -0
@@ -124,6 +124,8 @@ void fastcall mark_page_accessed(structClearPageReferenced (page); }else if (!PageReferenced (page)) {SetPageReferenced (page); +if (PageLRU (page) && !PageActivate (page)) +inc_readahead_aging (); } }
mm/readahead.c +358 -0
389 lines not on this page · raw message
--
PATCH 8/16 readahead: context based method
In reply to Wu FengguangThis is the slow code path.
No valid state info is available, so the page cache is queried to abtain the required position/timing infomation.
Major steps:
- look back/forward to find the ra_index;
- look back to estimate a thrashing safe ra_size;
- assemble the next read-ahead request in file_ra_state;
- submit it.
---
mm/readahead.c | 345 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 345 insertions(+)
mm/readahead.c +345 -0
@@ -1170,6 +1170,351 @@ state_based_readahead(struct address_spareturn ra_dispatch (ra, mapping, filp); } +/* +* Page cache context based estimation of read-ahead/look-ahead size/index. +* +* The logic first looks around to find the start point of next read-ahead, +* and then, if necessary, looks backward in the inactive_list to get an +* estimation of the thrashing-threshold. +* +* The estimation theory can be illustrated with figure: +* +* chunk A chunk B chunk C head +* +* l01 l11 l12 l21 l22 +*| |-->|-->| |------>|-->| |------>| +*| +-------+ +-----------+ +-------------+ | +*| | # | | # | | # | | +*| +-------+ +-----------+ +-------------+ | +*| |<==============|<===========================|<============================| +* L0 L1 L2 +* +* Let f(l) = L be a map from +* l: the number of pages read by the stream +* to +* L: the number of pages pushed into inactive_list in the mean time +* then +* f(l01) <= L0 +* f(l11 + l12) = L1 +* f(l21 + l22) = L2 +* ... +* f(l01 + l11 + ...) <= Sum(L0 + L1 + ...) +* <= Length(inactive_list) = f(thrashing-threshold) +* +* So the count of countinuous history pages left in the inactive_list is always +* a lower estimation of the true thrashing-threshold. +*/ + +/* +* STATUS REFERENCE COUNT TYPE +* A__ 0 not in inactive list +* ___ 0 fresh +* __R PAGE_REFCNT_1 stale +* _a_ PAGE_REFCNT_2 disturbed once +* _aR PAGE_REFCNT_3 disturbed twice +* +* A/a/R: Active / aCTIVATE / Referenced +*/ +static inline unsigned long cold_page_refcnt (struct page *page) +{ +if (!page ||PageActive (page)) +return 0 ; + +return page_refcnt (page); +} + +static inline char page_refcnt_symbol (struct page *page) +{ +if (!page) +return 'X' ; +if (PageActive (page)) +return 'A' ; +switch (page_refcnt (page)) { +case 0 : +return '_' ; +case PAGE_REFCNT_1 : +return '-' ; +case PAGE_REFCNT_2 : +return '=' ; +case PAGE_REFCNT_3 : +return '#' ; + } +return '?' ; +} + +/* +* Count/estimate cache hits in range [first_index, last_index]. +* The estimation is simple and optimistic. +*/ +static int count_cache_hit (struct address_space *mapping, +pgoff_t first_index,pgoff_t last_index) +{ +struct page *page; +int size = last_index - first_index +1 ; +int count =0 ; +int i; + +read_lock_irq (&mapping->tree_lock); + +/* +* The first page may well is chunk head and has been accessed, +* so it is index 0 that makes the estimation optimistic. This +* behavior guarantees a readahead when (size < ra_max) and +* (readahead_hit_rate >= 16). +*/ +for (i =0 ; i <16 ;) { + page =__find_page (mapping, first_index + + size * ((i++ *29 ) &15 ) /16 ); +if (cold_page_refcnt (page) >=PAGE_REFCNT_1 && ++count >=2 ) +break ; + } + +read_unlock_irq (&mapping->tree_lock); + +return size * count / i; +} + +/* +* Look back and check history pages to estimate thrashing-threshold. +*/ +static int query_page_cache (struct address_space *mapping, +struct file_ra_state *ra, +unsigned long *remain,pgoff_t offset, +unsigned long ra_min,unsigned long ra_max) +{ +int count; +pgoff_t index; +unsigned long nr_lookback; +struct radix_tree_cache cache; + +/* +* Scan backward and check the near @ra_max pages. +* The count here determines ra_size. +*/ +read_lock_irq (&mapping->tree_lock); + index =radix_tree_lookup_head (&mapping->page_tree, offset, ra_max); +read_unlock_irq (&mapping->tree_lock); +#ifdef DEBUG_READAHEAD_RADIXTREE +if (index <= offset) { +WARN_ON (!find_page (mapping, index)); +if (index + ra_max > offset) +WARN_ON (find_page (mapping, index -1 )); + }else { +BUG_ON (index > offset +1 ); +WARN_ON (find_page (mapping, offset)); + } +#endif + + *remain = offset - index +1 ; + +if (unlikely (*remain <= ra_min)) +return ra_min; + +if (!index) +return *remain; + +if (offset +1 == ra->readahead_index &&ra_cache_hit_ok (ra)) + count = *remain; +else if (count_cache_hit (mapping, index, offset) * + readahead_hit_rate >= *remain) + count = *remain; +else +return ra_min; + +if (count < ra_max) + goto out; + +/* +* Check the far pages coarsely. +* The big count here helps increase la_size. +*/ + nr_lookback = ra_max * (LOOKAHEAD_RATIO +1 ) * +100 / (readahead_ratio +1 ); +if (nr_lookback > offset) + nr_lookback = offset; + +radix_tree_cache_init (&cache); +read_lock_irq (&mapping->tree_lock); +for (count += ra_max; count < nr_lookback; count += ra_max) { +struct radix_tree_node *node; + node =radix_tree_cache_lookup_node (&mapping->page_tree, + &cache, offset - count,1 ); +if (!node) +break ; +#ifdef DEBUG_READAHEAD_RADIXTREE +if (node !=radix_tree_lookup_node (&mapping->page_tree, + offset - count,1 )) { +read_unlock_irq (&mapping->tree_lock); +printk (KERN_ERR "check radix_tree_cache_lookup_node!\n" ); +return 1 ; + } +#endif + } +read_unlock_irq (&mapping->tree_lock); + +/* +* For sequential read that extends from index 0, the counted value +* may well be far under the true threshold, so return it unmodified +* for further process in adjust_rala_accelerated(). +*/ +if (count >= offset) +return offset +1 ; + +out: + count = count * readahead_ratio /100 ; +return count; +} + +/* +* Scan backward in the file for the first non-present page. +*/ +static inline pgoff_t first_absent_page_bw (struct address_space *mapping, +pgoff_t index,unsigned long max_scan) +{ +struct radix_tree_cache cache; +struct page *page; +pgoff_t origin; + + origin = index; +if (max_scan > index) + max_scan = index; + +radix_tree_cache_init (&cache); +read_lock_irq (&mapping->tree_lock); +for (; origin - index <= max_scan;) { + page =radix_tree_cache_lookup (&mapping->page_tree, + &cache, --index); +if (page) { + index++; +break ; + } + } +read_unlock_irq (&mapping->tree_lock); + +return index; +} + +/* +* Scan forward in the file for the first non-present page. +*/ +static inline pgoff_t first_absent_page (struct address_space *mapping, +pgoff_t index,unsigned long max_scan) +{ +pgoff_t ra_index; + +read_lock_irq (&mapping->tree_lock); + ra_index =radix_tree_lookup_tail (&mapping->page_tree, + index +1 , max_scan); +read_unlock_irq (&mapping->tree_lock); + +#ifdef DEBUG_READAHEAD_RADIXTREE +BUG_ON (ra_index <= index); +if (index + max_scan > index) { +if (ra_index <= index + max_scan) +WARN_ON (find_page (mapping, ra_index)); +WARN_ON (!find_page (mapping, ra_index -1 )); + } +#endif + +if (ra_index <= index + max_scan) +return ra_index; +else +return 0 ; +} + +/* +* Determine the request parameters for context based read-ahead that extends +* from start of file. +* +* The major weakness of stateless method is perhaps the slow grow up speed of +* ra_size. The logic tries to make up for this in the important case of +* sequential reads that extend from start of file. In this case, the ra_size +* is not choosed to make the whole next chunk safe(as in normal ones). Only +* half of which is safe. The added 'unsafe' half is the look-ahead part. It +* is expected to be safeguarded by rescue_pages() when the previous chunks are +* lost. +*/ +static inline int adjust_rala_accelerated (unsigned long ra_max, +unsigned long *ra_size,unsigned long *la_size) +{ +pgoff_t index = *ra_size; + + *ra_size -=min (*ra_size, *la_size); + *ra_size = *ra_size * readahead_ratio /100 ; + *la_size = index * readahead_ratio /100 ; + *ra_size += *la_size; + +if (*ra_size > ra_max) + *ra_size = ra_max; +if (*la_size > *ra_size) + *la_size = *ra_size; + +return 1 ; +} + +/* +* Main function for page context based read-ahead. +*/ +static inline int +try_context_based_readahead (struct address_space *mapping, +struct file_ra_state *ra, +struct page *prev_page,struct page *page, +pgoff_t index,unsigned long ra_size, +unsigned long ra_min,unsigned long ra_max) +{ +pgoff_t ra_index; +unsigned long la_size; +unsigned long remain_pages; + +/* Where to start read-ahead? +* NFSv3 daemons may process adjecent requests in parallel, +* leading to many locally disordered, globally sequential reads. +* So do not require nearby history pages to be present or accessed. +*/ +if (page) { + ra_index =first_absent_page (mapping, index, ra_max *5 /4 ); +if (unlikely (!ra_index)) +return -1 ; + }else if (!prev_page) { + ra_index =first_absent_page_bw (mapping, index, + readahead_hit_rate + ra_min); +if (index - ra_index > readahead_hit_rate + ra_min) +return 0 ; + ra_min +=2 * (index - ra_index); + index = ra_index; + }else { + ra_index = index; +if (ra_has_index (ra, index)) +ra_account (ra,RA_EVENT_READAHEAD_MUTILATE , + ra->readahead_index - index); + } + + ra_size =query_page_cache (mapping, ra, &remain_pages, + index -1 , ra_min, ra_max); + + la_size = ra_index - index; +if (!readahead_live_chunk && + remain_pages <= la_size && la_size >1 ) { +rescue_pages (page, la_size); +return -1 ; + } + +if (ra_size == index) { +if (!adjust_rala_accelerated (ra_max, &ra_size, &la_size)) +return -1 ; +set_ra_class (ra,RA_CLASS_CONTEXT_ACCELERATED ); + }else { +if (!adjust_rala (ra_max, &ra_size, &la_size)) +return -1 ; +set_ra_class (ra,RA_CLASS_CONTEXT ); + } + +ra_state_init (ra, index, ra_index); +ra_state_update (ra, ra_size, la_size); + +return 1 ; +} +/* * ra_size is mainly determined by:
--
PATCH 9/16 readahead: read-around method for mmap file
In reply to Wu FengguangMove the readaround logic outside of filemap_nopage(), and make it a little more smart and tunable.
The original logic is quite agressive, so relax readahead_hit_rate for mmap to make the new implementation comparable to the old behavior. It should be larger than normal files anyway: programs can jump back and forth frequently, there will be less chance to accumulate a big cache_hit_rate, though the chance of it coming back to read the missed pages are large.
The pgmajfault was increased on every readahead invocation and other possible I/O waits. Change it to simply increase on every I/O waits, since readahead means I/O wait in normal.
---
include/linux/fs.h | 1 + include/linux/mm.h | 3 +++ mm/filemap.c | 42 +++++++----------------------------------- mm/readahead.c | 50 ++++++++++++++++++++++++++++++++++++++++++++++++++ 4 files changed, 61 insertions(+), 35 deletions(-)
include/linux/mm.h +3 -0
@@ -1014,6 +1014,9 @@ page_cache_readahead_adaptive(struct add struct page *prev_page, struct page *page, pgoff_t first_index, pgoff_t index, pgoff_t last_index); +unsigned long +page_cache_readaround (struct address_space *mapping,struct file_ra_state *ra, +struct file *filp,pgoff_t index); void fastcall ra_access(struct file_ra_state *ra, struct page *page);#ifdef CONFIG_DEBUG_FS
mm/filemap.c +7 -35
79 lines not on this page · raw message
mm/readahead.c +50 -0
56 lines not on this page · raw message
include/linux/fs.h +1 -0
@@ -622,6 +622,7 @@ struct file_ra_state { };#define RA_FLAG_MISS 0x01/* a cache miss occured against this file */ #define RA_FLAG_INCACHE 0x02/* file is already in cache */ +#define RA_FLAG_MMAP (1UL<<31)/* mmaped page access */ struct file {/*
--
PATCH 10/16 readahead: other methods
In reply to Wu FengguangVarious read-ahead strategies for:
- fresh read from start of file
- backward prefetching
- seek and read one record pattern(db workload)
- quick recover from thrashing
---
mm/readahead.c | 111 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 111 insertions(+)
mm/readahead.c +111 -0
@@ -1515,6 +1515,117 @@ try_context_based_readahead(struct addrereturn 1 ; } +/* +* Read-ahead on start of file. +* +* It is most important for small files. +* 1. Set a moderate large read-ahead size; +* 2. Issue the next read-ahead request as soon as possible. +* +* But be careful, there are some applications that dip into only the very head +* of a file. The most important thing is to prevent them from triggering the +* next (much larger) read-ahead request, which leads to lots of cache misses. +* Two pages should be enough for them, correct me if I'm wrong. +*/ +static inline unsigned long +newfile_readahead (struct address_space *mapping, +struct file *filp,struct file_ra_state *ra, +unsigned long req_size,unsigned long ra_min) +{ +unsigned long ra_size; +unsigned long la_size; + +if (req_size > ra_min) + req_size = ra_min; + + ra_size =4 * req_size; + la_size =2 * req_size; + +set_ra_class (ra,RA_CLASS_NEWFILE ); +ra_state_init (ra,0 ,0 ); +ra_state_update (ra, ra_size, la_size); + +return ra_dispatch (ra, mapping, filp); +} + +/* +* Backward prefetching. +* No look ahead and thrashing threshold estimation for stepping backward +* pattern: should be unnecessary. +*/ +static inline int +try_read_backward (struct file_ra_state *ra, +pgoff_t begin_index,pgoff_t end_index, +unsigned long ra_size, +unsigned long ra_min,unsigned long ra_max) +{ +if (ra_size > ra_max || end_index > ra->prev_page) +return 0 ; + +if (ra_has_index (ra, ra->prev_page)) { +if (end_index > ra->la_index) +return 0 ; + ra_size +=2 *ra_cache_hit (ra,0 ); + end_index = ra->la_index; + }else { + ra_size += readahead_hit_rate + ra_min; + end_index = ra->prev_page; + } + +if (ra_size > ra_max) + ra_size = ra_max; + +if (end_index > begin_index + ra_size) +return 0 ; + + begin_index = end_index - ra_size; + +set_ra_class (ra,RA_CLASS_BACKWARD ); +ra_state_init (ra, begin_index, begin_index); +ra_state_update (ra, ra_size,0 ); + +return 1 ; +} + +/* +* If there is a previous sequential read, it is likely to be another +* sequential read at the new position. +* Databases are known to have this seek-and-read-one-record pattern. +*/ +static inline int +try_random_readahead (struct file_ra_state *ra,pgoff_t index, +unsigned long ra_size,unsigned long ra_max) +{ +unsigned long hit0 =ra_cache_hit (ra,0 ); +unsigned long hit1 =ra_cache_hit (ra,1 ) + hit0; +unsigned long hit2 =ra_cache_hit (ra,2 ); +unsigned long hit3 =ra_cache_hit (ra,3 ); + +if (!ra_has_index (ra, ra->prev_page)) +return 0 ; + +if (index == ra->prev_page +1 ) {/* read after thrashing */ + ra_size = hit0; +set_ra_class (ra,RA_CLASS_RANDOM_THRASHING ); +ra_account (ra,RA_EVENT_READAHEAD_THRASHING , + ra->readahead_index - index); + }else if (ra_size < hit1 &&/* read after seeking */ + hit1 > hit2 /2 && + hit2 > hit3 /2 && + hit3 > hit1 /2 ) { + ra_size =max (hit1, hit2); +set_ra_class (ra,RA_CLASS_RANDOM_SEEK ); + }else +return 0 ; + +if (ra_size > ra_max) + ra_size = ra_max; + +ra_state_init (ra, index, index); +ra_state_update (ra, ra_size,0 ); + +return 1 ; +}/* * Read-around for mmaped file.
--
PATCH 11/16 readahead: detect and rescue live pages
In reply to Wu FengguangIt tries to identify and protect live pages (sequential pages that are going to be accessed in the near future) on vmscan time. Almost all live pages can be sorted out and saved.
The cost: dead pages that won't be read will be kept in inactive_list for another round. Hopefully there won't be much, for file servers normally have read-ahead hit rate as high as 99%.
This feature is greatly demanded by file servers, though should be useless for desktop. It saves the case when one fast reader flushes the cache and strips the read-ahead size of slow readers, or the case where caching is just a wasting of memory. Then you can raise readahead_ratio to 200 or more to enforce a larger read-ahead size and strip the useless cached data out of lru.
Its use is currently limited, for the context based method is not ready for the case. This problem will be solved when the timing info of evicted pages are available. It can also be extended to further benefit large memory systems. I'll leave them as future work.
---
include/linux/mm.h | 1 include/linux/page-flags.h | 2 mm/page_alloc.c | 2 mm/readahead.c | 318 ++++++++++++++++++++++++++++++++++++++++++++- mm/vmscan.c | 9 + 5 files changed, 331 insertions(+), 1 deletion(-)
include/linux/page-flags.h +2 -0
@@ -109,6 +109,8 @@ struct page_state {unsigned long pgfree;/* page freeings */ unsigned long pgactivate;/* pages moved inactive->active */ unsigned long pgdeactivate;/* pages moved active->inactive */ +unsigned long pgkeephot;/* pages sent back to active */ +unsigned long pgkeepcold;/* pages sent back to inactive */ unsigned long pgfault;/* faults (major+minor) */ unsigned long pgmajfault;/* faults (major only) */
include/linux/mm.h +1 -0
@@ -1018,6 +1018,7 @@ unsigned long page_cache_readaround(struct address_space *mapping, struct file_ra_state *ra, struct file *filp, pgoff_t index); void fastcall ra_access(struct file_ra_state *ra, struct page *page); +int rescue_ra_pages (struct list_head *page_list,struct list_head *save_list);#ifdef CONFIG_DEBUG_FS extern u32 readahead_debug_level;
mm/page_alloc.c +2 -0
@@ -2397,6 +2397,8 @@ static char *vmstat_text[] = {"pgfree" ,"pgactivate" ,"pgdeactivate" , +"pgkeephot" , +"pgkeepcold" ,"pgfault" , "pgmajfault",
mm/vmscan.c +9 -0
@@ -417,6 +417,8 @@ cannot_free:return 0 ; } +extern int readahead_live_chunk; +/* * shrink_list adds the number of reclaimed pages to sc->nr_reclaimed */
@@ -425,10 +427,14 @@ static int shrink_list(struct list_headLIST_HEAD (ret_pages);struct pagevec freed_pvec;int pgactivate =0 ; +int pgkeep =0 ;int reclaimed =0 ;cond_resched (); +if (readahead_live_chunk) + pgkeep +=rescue_ra_pages (page_list, &ret_pages); +pagevec_init (&freed_pvec,1 );while (!list_empty (page_list)) {struct address_space *mapping;
@@ -582,11 +588,13 @@ keep_locked: keep:list_add (&page->lru, &ret_pages);BUG_ON (PageLRU (page)); + pgkeep++; }list_splice (&ret_pages, page_list);if (pagevec_count (&freed_pvec))__pagevec_release_nonlru (&freed_pvec);mod_page_state (pgactivate, pgactivate); +mod_page_state (pgkeepcold, pgkeep - pgactivate); sc->nr_reclaimed += reclaimed;return reclaimed; }
@@ -1080,6 +1088,7 @@ refill_inactive_zone(struct zone *zone,mod_page_state_zone (zone, pgrefill, pgscanned);mod_page_state (pgdeactivate, pgdeactivate); +mod_page_state (pgkeephot, pgmoved); }/*
mm/readahead.c +317 -1
327 lines not on this page · raw message
--
PATCH 12/16 readahead: events accounting
In reply to Wu FengguangA debugfs file named `readahead/events' is created according to advices from J?rn Engel, Andrew Morton and Ingo Oeser. It yields to much better readability than the preious /proc/vmstat interface :)
It reveals various read-ahead activities/events, and is vital to the testing.
-------------------------------------------------------------------------
If you are experiencing performance problems, or want to help improve the read-ahead logic, please send me the debug data. Thanks.
- Preparations
## Compile with CONFIG_DEBUG_FS('Kernel hacking ---> Debug Filesystem') mkdir /debug
mount -t debug none /debug
- For each session with distinct access pattern
echo > /debug/readahead/events # reset the counters
# echo > /var/log/kern.log # you may want to backup it first # echo 5 > /debug/readahead/debug_level # show verbose printk traces ## do one benchmark/task # echo 0 > /debug/readahead/debug_level # revert to normal value cp /debug/readahead/events readahead-events-`date +'%F_%R'` # bzip2 -c /var/log/kern.log > kern.log-`date +'%F_%R'`.bz2
The commented out commands can uncover the very detailed file accesses, which are useful sometimes. But the log file will be rather huge.
-------------------------------------------------------------------------
This is a trimmed down output on my PC:
# cat /debug/readahead/events [table requests] total newfile state context none cache_miss 403 56 12 69 263 read_random 260 37 5 17 201 io_congestion 0 0 0 0 0 io_cache_hit 85 0 24 46 0 io_block 9796 5613 822 143 3203 readahead 5956 5418 383 139 0 lookahead 961 650 212 98 0 lookahead_hit 449 181 164 58 41 lookahead_ignore 0 0 0 0 0 readahead_eof 4981 4768 171 28 0 readahead_shrink 0 0 0 0 0 readahead_thrash 0 0 0 0 0 readahead_mutilt 0 0 0 0 0 readahead_rescue 45 0 0 0 45
[table pages] total newfile state context nonecache_miss 5590 72 2506 181 2826read_random 265 37 5 17 206
io_congestion 0 0 0 0 0 io_cache_hit 2440 0 1054 1366 0 io_block 165848 11117 147794 3668 3203 readahead 43080 11360 28949 2621 0 readahead_hit 38251 10716 25669 1818 9 lookahead 24013 1718 21641 647 0 lookahead_hit 20161 770 18679 712 0 lookahead_ignore 0 0 0 0 0 readahead_eof 15961 7924 7440 461 0 readahead_shrink 0 0 0 0 0 readahead_thrash 0 0 0 0 0 readahead_mutilt 0 0 0 0 0
readahead_rescue 240 0 0 0 240
[table summary] total newfile state context none
random_rate 4% 0% 1% 10% 99% ra_hit_rate 88% 94% 88% 69% 900% la_hit_rate 46% 27% 76% 58% 4100% avg_ra_size 7 2 75 19 0 avg_la_size 25 3 102 7 0
---
mm/readahead.c | 202 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++- 1 files changed, 201 insertions(+), 1 deletion(-)
mm/readahead.c +201 -1
@@ -112,6 +112,9 @@ enum ra_event {u32 readahead_debug_level =0 ;u32 debug_disable_stateful_method =0 ; +static struct dentry *readahead_events_dentry; +extern struct file_operations ra_debug_fops; +static int __init readahead_init (void ) {struct dentry *root;
@@ -122,6 +125,9 @@ static int __init readahead_init(void)debugfs_create_bool ("disable_stateful_method" ,0644 , root, &debug_disable_stateful_method); + readahead_events_dentry =debugfs_create_file ("events" , +0644 , root,NULL , &ra_debug_fops); +return 0 ; }
@@ -139,6 +145,195 @@ static inline int disable_stateful_methoreturn 0 ; } +#endif + +/* +* Read-ahead events accounting. +*/ +#ifdef DEBUG_READAHEAD + +static char *ra_class_name[] = { +"total" , +"newfile" , +"state" , +"context" , +"contexta" , +"around" , +"backward" , +"onthrash" , +"onraseek" , +"none" , +}; + +static char *ra_event_name[] = { +"cache_miss" , +"read_random" , +"io_congestion" , +"io_cache_hit" , +"io_block" , +"readahead" , +"readahead_hit" , +"lookahead" , +"lookahead_hit" , +"lookahead_ignore" , +"readahead_mmap" , +"readahead_eof" , +"readahead_shrink" , +"readahead_thrash" , +"readahead_mutilt" , +"readahead_rescue" , +}; + +static unsigned long ra_event_count[RA_CLASS_END +1 ][RA_EVENT_END +1 ][2 ]; + +static inline void ra_account (struct file_ra_state *ra, +enum ra_event e,int pages) +{ +enum ra_class c; + +if (e ==RA_EVENT_READAHEAD_HIT && pages <0 ) { + c = (ra->flags >>RA_CLASS_SHIFT ) &RA_CLASS_MASK ; + pages = -pages; + }else if (ra) + c = ra->flags &RA_CLASS_MASK ; +else + c =RA_CLASS_END ; + +if (!c) + c =RA_CLASS_END ; + + ra_event_count[c][e][0 ] +=1 ; + ra_event_count[c][e][1 ] += pages; + +if (e ==RA_EVENT_READAHEAD ) + ra_event_count[c][RA_EVENT_END ][1 ] += pages * pages; +} + +static int ra_account_show (struct seq_file *s,void *_) +{ +int i; +int c; +int e; +static char event_fmt[] ="%-16s" ; +static char class_fmt[] ="%10s" ; +static char item_fmt[] ="%10lu" ; +static char percent_format[] ="%9lu%%" ; +static char *table_name[] = { +"[table requests]" , +"[table pages]" , +"[table summary]" }; + +for (i =0 ; i <=1 ; i++) { +for (e =0 ; e <=RA_EVENT_END ; e++) { + ra_event_count[0 ][e][i] =0 ; +for (c =1 ; c <=RA_CLASS_END ; c++) + ra_event_count[0 ][e][i] += + ra_event_count[c][e][i]; + } + +seq_printf (s, event_fmt, table_name[i]); +for (c =0 ; c <=RA_CLASS_END ; c++) +seq_printf (s, class_fmt, ra_class_name[c]); +seq_puts (s,"\n" ); + +for (e =0 ; e <RA_EVENT_END ; e++) { +if (e ==RA_EVENT_READAHEAD_HIT && i ==0 ) +continue ; + +seq_printf (s, event_fmt, ra_event_name[e]); +for (c =0 ; c <=RA_CLASS_END ; c++) +seq_printf (s, item_fmt, + ra_event_count[c][e][i]); +seq_puts (s,"\n" ); + } +seq_puts (s,"\n" ); + } + +seq_printf (s, event_fmt, table_name[2 ]); +for (c =0 ; c <=RA_CLASS_END ; c++) +seq_printf (s, class_fmt, ra_class_name[c]); +seq_puts (s,"\n" ); + +seq_printf (s, event_fmt,"random_rate" ); +for (c =0 ; c <=RA_CLASS_END ; c++) +seq_printf (s, percent_format, + (ra_event_count[c][RA_EVENT_READRANDOM ][0 ] *100 ) / + (ra_event_count[c][RA_EVENT_READRANDOM ][0 ] + + ra_event_count[c][RA_EVENT_READAHEAD ][0 ] +1 )); +seq_puts (s,"\n" ); + +seq_printf (s, event_fmt,"ra_hit_rate" ); +for (c =0 ; c <=RA_CLASS_END ; c++) +seq_printf (s, percent_format, + (ra_event_count[c][RA_EVENT_READAHEAD_HIT ][1 ] *100 ) / + (ra_event_count[c][RA_EVENT_READAHEAD ][1 ] |1 )); +seq_puts (s,"\n" ); + +seq_printf (s, event_fmt,"la_hit_rate" ); +for (c =0 ; c <=RA_CLASS_END ; c++) +seq_printf (s, percent_format, + (ra_event_count[c][RA_EVENT_LOOKAHEAD_HIT ][0 ] *100 ) / + (ra_event_count[c][RA_EVENT_LOOKAHEAD ][0 ] |1 )); +seq_puts (s,"\n" ); + +seq_printf (s, event_fmt,"var_ra_size" ); +for (c =0 ; c <=RA_CLASS_END ; c++) +seq_printf (s, item_fmt, + (ra_event_count[c][RA_EVENT_END ][1 ] - + ra_event_count[c][RA_EVENT_READAHEAD ][1 ] * + (ra_event_count[c][RA_EVENT_READAHEAD ][1 ] / + (ra_event_count[c][RA_EVENT_READAHEAD ][0 ] |1 ))) / + (ra_event_count[c][RA_EVENT_READAHEAD ][0 ] |1 )); +seq_puts (s,"\n" ); + +seq_printf (s, event_fmt,"avg_ra_size" ); +for (c =0 ; c <=RA_CLASS_END ; c++) +seq_printf (s, item_fmt, + (ra_event_count[c][RA_EVENT_READAHEAD ][1 ] + + ra_event_count[c][RA_EVENT_READAHEAD ][0 ] /2 ) / + (ra_event_count[c][RA_EVENT_READAHEAD ][0 ] |1 )); +seq_puts (s,"\n" ); + +seq_printf (s, event_fmt,"avg_la_size" ); +for (c =0 ; c <=RA_CLASS_END ; c++) +seq_printf (s, item_fmt, + (ra_event_count[c][RA_EVENT_LOOKAHEAD ][1 ] + + ra_event_count[c][RA_EVENT_LOOKAHEAD ][0 ] /2 ) / + (ra_event_count[c][RA_EVENT_LOOKAHEAD ][0 ] |1 )); +seq_puts (s,"\n" ); + +return 0 ; +} + +static int ra_debug_open (struct inode *inode,struct file *file) +{ +return single_open (file, ra_account_show,NULL ); +} + +static ssize_t ra_debug_write (struct file *file,const char __user *buf, +size_t size,loff_t *offset) +{ +if (file->f_dentry == readahead_events_dentry) +memset (ra_event_count,0 ,sizeof (ra_event_count)); +return 1 ; +} + +static struct file_operations ra_debug_fops = { + .owner =THIS_MODULE , + .open = ra_debug_open, + .write = ra_debug_write, + .read = seq_read, + .llseek = seq_lseek, + .release = single_release, +}; + +#else /* !DEBUG_READAHEAD */ + +static inline void ra_account (struct file_ra_state *ra, +enum ra_event e,int pages) +{ +} +#endif /* DEBUG_READAHEAD */
@@ -1033,6 +1228,8 @@ static int ra_dispatch(struct file_ra_stra_account (ra,RA_EVENT_READAHEAD_EOF , actual);if (la_size)ra_account (ra,RA_EVENT_LOOKAHEAD , la_size); +if (ra_size > actual) +ra_account (ra,RA_EVENT_IO_CACHE_HIT , ra_size - actual);ra_account (ra,RA_EVENT_READAHEAD , actual); dprintk("readahead-%s(ino=%lu, index=%lu, ra=%lu+%lu-%lu) = %d\n",
@@ -1728,8 +1925,11 @@ page_cache_readahead_adaptive(struct addif (page) {if (!TestClearPageReadahead (page))return 0 ; -if (bdi_read_congested (mapping->backing_dev_info)) +if (bdi_read_congested (mapping->backing_dev_info)) { +ra_account (ra,RA_EVENT_IO_CONGESTION , + end_index - index);return 0 ; + } }if (page)
--
PATCH 13/16 readahead: laptop mode support
In reply to Wu FengguangWhen the laptop drive is spinned down, defer look-ahead to spin up time.
The implementation employs a poll based method, for performance is not a concern in this code path. The poll interval is 64KB, which should be small enough for movies/musics. The user space application is responsible for proper caching to hide the spin-up-and-read delay.
------------------------------------------------------------------------
For crazy laptop users who prefer aggressive read-ahead, here is the way:
# echo 1000 > /proc/sys/vm/readahead_ratio # blockdev --setra 524280 /dev/hda # this is the max possible value
Notes:
- It is still an untested feature.
- It is safer to use blockdev+fadvise to increase ra-max for a single file, which needs patching your movie player.
- Be sure to restore them to sane values in normal operations!
---
include/linux/writeback.h | 6 ++++++ mm/page-writeback.c | 2 +- mm/readahead.c | 30 ++++++++++++++++++++++++++++++ 3 files changed, 37 insertions(+), 1 deletion(-)
include/linux/writeback.h +6 -0
@@ -85,6 +85,12 @@ void laptop_io_completion(void);void laptop_sync_completion (void );void throttle_vm_writeout (void ); +extern struct timer_list laptop_mode_wb_timer; +static inline int laptop_spinned_down (void ) +{ +return !timer_pending (&laptop_mode_wb_timer); +} +/* These are exported to sysctl. */ extern int dirty_background_ratio;extern int vm_dirty_ratio;
mm/page-writeback.c +1 -1
@@ -369,7 +369,7 @@ static void wb_timer_fn(unsigned long unstatic void laptop_timer_fn (unsigned long unused); static DEFINE_TIMER(wb_timer, wb_timer_fn, 0, 0); -static DEFINE_TIMER(laptop_mode_wb_timer, laptop_timer_fn, 0, 0); +DEFINE_TIMER (laptop_mode_wb_timer, laptop_timer_fn,0 ,0 );/* * Periodic writeback of "old" data.
mm/readahead.c +30 -0
@@ -14,6 +14,7 @@#include <linux/blkdev.h> #include <linux/backing-dev.h> #include <linux/pagevec.h> +#include <linux/writeback.h> /* The default max/min read-ahead pages. */ #define KB (size) (((size)*1024 + PAGE_CACHE_SIZE-1) / PAGE_CACHE_SIZE)
@@ -1029,6 +1030,30 @@ out: }/* +* Set a new look-ahead mark at @new_index. +* Return 0 if the new mark is successfully set. +*/ +static inline int renew_lookahead (struct address_space *mapping, +struct file_ra_state *ra, +pgoff_t index,pgoff_t new_index) +{ +struct page *page; + +if (index == ra->lookahead_index && + new_index >= ra->readahead_index) +return 1 ; + + page =find_page (mapping, new_index); +if (!page) +return 1 ; + +SetPageReadahead (page); +if (ra->lookahead_index == index) + ra->lookahead_index = new_index; +return 0 ; +} + +/* * State based calculation of read-ahead request. * * This figure shows the meaning of file_ra_state members:
@@ -1930,6 +1955,11 @@ page_cache_readahead_adaptive(struct add end_index - index);return 0 ; } +if (laptop_mode &&laptop_spinned_down ()) { +if (!renew_lookahead (mapping, ra, index, + index +LAPTOP_POLL_INTERVAL )) +return 0 ; + } }if (page)
--
PATCH 14/16 readahead: disable look-ahead for loopback file
In reply to Wu FengguangLoopback files normally contain filesystem, in which case there are already proper look-aheads in the upper layer, more look-aheads on the loopback file only ruins the read-ahead hit rate.
---
I'd like to thank Tero Grundstr?m for uncovering the loopback problem.
drivers/block/loop.c | 6 ++++++ include/linux/fs.h | 1 + mm/readahead.c | 8 ++++++++ 3 files changed, 15 insertions(+)
include/linux/fs.h +1 -0
@@ -623,6 +623,7 @@ struct file_ra_state {#define RA_FLAG_MISS 0x01/* a cache miss occured against this file */ #define RA_FLAG_INCACHE 0x02/* file is already in cache */ #define RA_FLAG_MMAP (1UL<<31)/* mmaped page access */ +#define RA_FLAG_NO_LOOKAHEAD (1UL<<30)/* disable look-ahead */ struct file {/*
drivers/block/loop.c +6 -0
@@ -782,6 +782,12 @@ static int loop_set_fd(struct loop_devic mapping = file->f_mapping; inode = mapping->host; +/* +* The upper layer should already do proper look-ahead, +* one more look-ahead here only ruins the cache hit rate. +*/ + file->f_ra.flags |=RA_FLAG_NO_LOOKAHEAD ; +if (!(file->f_mode &FMODE_WRITE )) lo_flags |=LO_FLAGS_READ_ONLY ;
mm/readahead.c +8 -0
@@ -1186,6 +1186,11 @@ static inline void ra_state_update(strucif (ra_size < old_ra &&ra_cache_hit (ra,0 ))ra_account (ra,RA_EVENT_READAHEAD_SHRINK , old_ra - ra_size);#endif + +/* Disable look-ahead for loopback file. */ +if (unlikely (ra->flags &RA_FLAG_NO_LOOKAHEAD )) + la_size =0 ; +ra_addup_cache_hit (ra); ra->ra_index = ra->readahead_index; ra->la_index = ra->lookahead_index;
@@ -1546,6 +1551,9 @@ static int query_page_cache(struct addreif (count < ra_max) goto out; +if (unlikely (ra->flags &RA_FLAG_NO_LOOKAHEAD )) + goto out; +/* * Check the far pages coarsely. * The big count here helps increase la_size.
--
PATCH 15/16 readahead: nfsd support
In reply to Wu Fengguang- disable nfsd raparms: the new logic do not rely on it
- disable look-ahead on start of file: leave it to the client
For the case of NFS service, the new read-ahead logic
+ can handle disordered nfsd requests
+ can handle concurrent sequential requests on large files with the help of look-ahead
- will have much ado about the concurrent ones on small files
------------------------------------------------------------------------
Notes about the concurrent nfsd requests issue:
nfsd read requests can be out of order, concurrent and with no ra-state info. They are handled by the context based read-ahead method, which does the job in the following steps:
1. scan in page cache
2. make read-ahead decisions
3. alloc new pages
4. insert new pages to page cache
A single read-ahead chunk in the client side will be dissembled and serviced by many concurrent nfsd in the server side. It is highly possible for two or more of these parallel nfsd instances to be in step 1/2/3 at the same time. Without knowing others working on the same file region, they will issue overlaped read-ahead requests, which lead to many conflicts at step 4.
There's no much luck to eliminate the concurrent problem in general and efficient ways. But for small to medium NFS servers where the bottleneck lies in storage devices, here is a performance tip:
# for pid in `pidof nfsd`; do taskset -p 1 $pid; done
This command effectively serializes all nfsd requests. It would be nice if someone can code this serialization on a per-file basis.
------------------------------------------------------------------------
Here is some test output(8 nfsd; local mount with tcp,rsize=8192):
SERIALIZED, SMALL FILES
=======================readahead_ratio = 0, ra_max = 128kb (old logic, the ra_max is really not relavant) 96.51s real 11.32s system 3.27s user 160334+2829 cs diff -r $NFSDIR $NFSDIR2 readahead_ratio = 70, ra_max = 1024kb (new read-ahead logic)
94.88s real 11.53s system 3.20s user 152415+3777 cs diff -r $NFSDIR $NFSDIR2
PARALLEL, SMALL FILES
=====================readahead_ratio = 0, ra_max = 128kb
99.87s real 11.41s system 3.15s user 173945+9163 cs diff -r $NFSDIR $NFSDIR2 readahead_ratio = 70, ra_max = 1024kb
100.14s real 12.06s system 3.16s user 170865+13406 cs diff -r $NFSDIR $NFSDIR2
SERIALIZED, BIG FILES
=====================readahead_ratio = 0, ra_max = 128kb
56.52s real 3.38s system 1.23s user 47930+5256 cs diff $NFSFILE $NFSFILE2 readahead_ratio = 70, ra_max = 1024kb
32.54s real 5.71s system 1.38s user 23851+17007 cs diff $NFSFILE $NFSFILE2
PARALLEL, BIG FILES
===================readahead_ratio = 0, ra_max = 128kb
63.35s real 5.68s system 1.57s user 82594+48747 cs diff $NFSFILE $NFSFILE2 readahead_ratio = 70, ra_max = 1024kb
33.87s real 10.17s system 1.55s user 72291+100079 cs diff $NFSFILE $NFSFILE2
---
fs/nfsd/vfs.c | 6 +++++- include/linux/fs.h | 1 + mm/readahead.c | 11 +++++++++-- 3 files changed, 15 insertions(+), 3 deletions(-)
fs/nfsd/vfs.c +5 -1
@@ -832,10 +832,14 @@ nfsd_vfs_read(struct svc_rqst *rqstp, st#endif /* Get readahead parameters */ - ra =nfsd_get_raparms (inode->i_sb->s_dev, inode->i_ino); +if (prefer_adaptive_readahead ()) + ra =NULL ; +else + ra =nfsd_get_raparms (inode->i_sb->s_dev, inode->i_ino);if (ra && ra->p_set) file->f_ra = ra->p_ra; + file->f_ra.flags |=RA_FLAG_NFSD ;if (file->f_op->sendfile) {svc_pushback_unused_pages (rqstp);
include/linux/fs.h +1 -0
@@ -624,6 +624,7 @@ struct file_ra_state {#define RA_FLAG_INCACHE 0x02/* file is already in cache */ #define RA_FLAG_MMAP (1UL<<31)/* mmaped page access */ #define RA_FLAG_NO_LOOKAHEAD (1UL<<30)/* disable look-ahead */ +#define RA_FLAG_NFSD (1UL<<29)/* request from nfsd */ struct file {/*
mm/readahead.c +9 -2
@@ -15,11 +15,13 @@#include <linux/backing-dev.h> #include <linux/pagevec.h> #include <linux/writeback.h> +#include <linux/nfsd/const.h> /* The default max/min read-ahead pages. */ #define KB (size) (((size)*1024 + PAGE_CACHE_SIZE-1) / PAGE_CACHE_SIZE)#define MAX_RA_PAGES KB(VM_MAX_READAHEAD)#define MIN_RA_PAGES KB(VM_MIN_READAHEAD) +#define MIN_NFSD_PAGES KB(NFSSVC_MAXBLKSIZE/1024)/* In laptop mode, poll delayed look-ahead on every ## pages read. */ #define LAPTOP_POLL_INTERVAL 16
@@ -1768,8 +1770,13 @@ newfile_readahead(struct address_space *if (req_size > ra_min) req_size = ra_min; - ra_size =4 * req_size; - la_size =2 * req_size; +if (unlikely (ra->flags &RA_FLAG_NFSD )) { + ra_size =MIN_NFSD_PAGES ; + la_size =0 ; + }else { + ra_size =4 * req_size; + la_size =2 * req_size; + }set_ra_class (ra,RA_CLASS_NEWFILE );ra_state_init (ra,0 ,0 );
--
PATCH 16/16 io: prevent too much latency in the read-ahead code
In reply to Wu FengguangSince the VM_MAX_READAHEAD is greatly enlarged and the algorithm become more complex, it may be necessary to insert some cond_resched() calls in the read-ahead path.
----------------------------------------------------------------------------
If you feel more latency with the new read-ahead code, the cause can either be the complex read-ahead code, or some low level routines not ready to support the larger default 1M read-ahead size. It can be cleared out with the following commands:
dd if=/dev/zero of=sparse bs=1M seek=10000 count=1 cp sparse /dev/null
If the above copy does not lead to audio jitters, then it's an low level issue. There are basicly two ways:
1) compile kernel with CONFIG_PREEMPT_VOLUNTARY/CONFIG_PREEMPT
2) reduce the read-ahead request size by
blockdev --setra 256 /dev/hda # or whatever device you are using
---
This is recommended by Con Kolivas to improve respond time for desktop. Thanks!
fs/mpage.c | 4 +++- mm/readahead.c | 16 +++++++++++++++- 2 files changed, 18 insertions(+), 2 deletions(-)
mm/readahead.c +15 -1
@@ -499,8 +499,10 @@ static int read_pages(struct address_spa page->index, GFP_KERNEL)) { ret = mapping->a_ops->readpage (filp, page);if (ret !=AOP_TRUNCATED_PAGE ) { -if (!pagevec_add (&lru_pvec, page)) +if (!pagevec_add (&lru_pvec, page)) {__pagevec_lru_add (&lru_pvec); +cond_resched (); + }continue ; }/* else fall through to release */ }
@@ -620,6 +622,7 @@ __do_page_cache_readahead(struct address }read_unlock_irq (&mapping->tree_lock); +cond_resched (); page =page_cache_alloc_cold (mapping);read_lock_irq (&mapping->tree_lock);if (!page)
@@ -1019,6 +1022,7 @@ static int rescue_pages(struct page *pagspin_unlock_irq (&zone->lru_lock); +cond_resched (); page =find_page (mapping, index);if (!page) goto out;
@@ -1093,6 +1097,7 @@ static unsigned long node_readahead_aginunsigned long sum =0 ;cpumask_t mask =node_to_cpumask (numa_node_id ()); +cond_resched ();for_each_cpu_mask (cpu, mask) sum +=per_cpu (readahead_aging, cpu);
@@ -1223,6 +1228,7 @@ static int ra_dispatch(struct file_ra_stint actual;enum ra_class ra_class; +cond_resched (); ra_class = (ra->flags &RA_CLASS_MASK );BUG_ON (ra_class ==0 || ra_class >RA_CLASS_END );
@@ -1245,6 +1251,7 @@ static int ra_dispatch(struct file_ra_st actual =__do_page_cache_readahead (mapping, filp, ra->ra_index, ra_size, la_size); +cond_resched ();#ifdef READAHEAD_STREAMING if (actual < ra_size) {
@@ -1483,6 +1490,7 @@ static int count_cache_hit(struct addresint count =0 ;int i; +cond_resched ();read_lock_irq (&mapping->tree_lock);/*
@@ -1520,6 +1528,7 @@ static int query_page_cache(struct addre* Scan backward and check the near @ra_max pages. * The count here determines ra_size. */ +cond_resched ();read_lock_irq (&mapping->tree_lock); index =radix_tree_lookup_head (&mapping->page_tree, offset, ra_max);read_unlock_irq (&mapping->tree_lock);
@@ -1565,6 +1574,7 @@ static int query_page_cache(struct addreif (nr_lookback > offset) nr_lookback = offset; +cond_resched ();radix_tree_cache_init (&cache);read_lock_irq (&mapping->tree_lock);for (count += ra_max; count < nr_lookback; count += ra_max) {
@@ -1611,6 +1621,7 @@ static inline pgoff_t first_absent_page_if (max_scan > index) max_scan = index; +cond_resched ();radix_tree_cache_init (&cache);read_lock_irq (&mapping->tree_lock);for (; origin - index <= max_scan;) {
@@ -1634,6 +1645,7 @@ static inline pgoff_t first_absent_page( {pgoff_t ra_index; +cond_resched ();read_lock_irq (&mapping->tree_lock); ra_index =radix_tree_lookup_tail (&mapping->page_tree, index +1 , max_scan);
@@ -1884,6 +1896,7 @@ page_cache_readaround(struct address_spaelse if ((unsigned )(index - ra->prev_page) <= hit_rate) ra_size =4 * (index - ra->prev_page);else { +cond_resched ();read_lock_irq (&mapping->tree_lock);if (radix_tree_lookup_node (&mapping->page_tree, index,1 )) ra_size =RADIX_TREE_MAP_SIZE ;
@@ -2390,6 +2403,7 @@ save_chunk: n <= 3) ret +=save_chunk (chunk_head, live_head, page, save_list); +cond_resched ();if (&page->lru != page_list) goto next_chunk;
fs/mpage.c +3 -1
@@ -343,8 +343,10 @@ mpage_readpages(struct address_space *ma bio =do_mpage_readpage (bio, page, nr_pages - page_idx, &last_block_in_bio, get_block); -if (!pagevec_add (&lru_pvec, page)) +if (!pagevec_add (&lru_pvec, page)) {__pagevec_lru_add (&lru_pvec); +cond_resched (); + } }else {page_cache_release (page); }
--