Skip to contentSkip to conversation

core-iscsi v1.6.2.1 STABLE

PATCH Nicholas A. Bellinger 1 participant 1 message Dec 6, 2005 SCSI

lore
Share & tools
lore
#0 lore raw

Greetings all!

Attached is a new release of the core-iscsi stack that solves one of the items from RELEASE_NOTES (Netapp, Wasabi, SANRAD support) as well as a additional fix related to iSCSI Underflow handling involving the removal of a unnecessary 'return on error' condition. A big thanks to Dominik and Dustin @ VBI for making this release happen!

These are both a single line change, please see the code below:

http://www.kernel.org/pub/linux/kernel/people/nab/iscsi-initiator-core/core-iscsi-v1.6.2.1.tar.bz2

CHANGELOG-1.6.2.1

1) Fixed iscsi_put_lun() to not include 0x4 at start of Flat Space 64-bit SCSI LUN Addressing (Wasabi+Netapp support added) that was causing a 'logical unit not connected' execption in INQUIRY readback data.
2) Only make noise when handling a Underflow mismatching between local missing read data value and resid.

iscsi_initiator_util.c (working copy) renamed from iscsi_initiator_util.c (revision 2146) +1 -1
Index: iscsi_initiator_util.c
===================================================================
@@ -1691,7 +1691,7 @@
        u64 ret;
 
        ret = ((lun & 0xff) << 8);
-       ret |= 0x40 | ((lun >> 8) & 0x3f);
+       ret |= 0x00 | ((lun >> 8) & 0x3f);
 
        return(cpu_to_le64(ret));

}

iscsi_initiator.c (working copy) renamed from iscsi_initiator.c (revision 2146) +0 -0
Index: iscsi_initiator.c
===================================================================
@@ -2499,7 +2499,6 @@
                                TRACE_ERROR("Underflow Residual count %u

does"
" NOT match expected %d\n",
hdr->res_count,
missing);

-                               return(-1);
                        }
                        resid = hdr->res_count;
                } else if (hdr->res_count != 0) {
Signature · 9 lines
Nicholas A. Bellinger <[email protected]>



-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click