Skip to contentSkip to conversation

incorrect return from ia64_pci_legacy_write()

PATCH New Alex Williamson 1 participant 1 message Dec 21, 2005

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 incorrect return from ia64_pci_legacy_write()

Tony,

Maybe there's time for one more push to Linus? The function
ia64_pci_legacy_write() returns 0 for everything except errors. This return value gets sent back to the user from pci_write_legacy_io(), making it look like every write fails. The trivial patch below copies the behavior of the SGI sn machvec and does what would be expected from something implementing a write() function. Please apply, Thanks,

Alex

---

arch/ia64/pci/pci.c +1 -1
diff -r 513446906e2e arch/ia64/pci/pci.c
@@ -700,7 +700,7 @@
  */
 int ia64_pci_legacy_write(struct pci_dev *bus, u16 port, u32 val, u8 size)
 {
-	int ret = 0;
+	int ret = size;
 
 	switch (size) {
 	case 1: