VIDEO_SAA7134_ALSA shouldn't select SND_PCM_OSS
PATCH 1/1 VIDEO_SAA7134_ALSA shouldn't select SND_PCM_OSS
There's no reason for an ALSA driver to select an OSS legacy userspace interface.
drivers/media/video/saa7134/Kconfig renamed from drivers/media/video/saa7134/Kconfig.old +1 -1
@@ -15,7 +15,7 @@ config VIDEO_SAA7134_ALSA tristate "Philips SAA7134 DMA audio support" depends on VIDEO_SAA7134 && SND - select SND_PCM_OSS + select SND_PCM ---help--- This is a video4linux driver for direct (DMA) audio in Philips SAA713x based TV cards using ALSA
Quoted 2 lines · Adrian Bunk
There's no reason for an ALSA driver to select an OSS legacy userspace interface.
Actually there is a reason. While OSS may be deprecated the OSS API is not - ALSA is committed to supporting it for the forseeable future. And as broken an interface as it is, a lot of people consider the sound system broken if you can't just write() to /dev/dsp and have sound come out.
Lee
Quoted 9 lines · Lee Revell
Quoted 2 lines · Adrian Bunk
There's no reason for an ALSA driver to select an OSS legacy userspace interface.
Actually there is a reason. While OSS may be deprecated the OSS API is not - ALSA is committed to supporting it for the forseeable future. And as broken an interface as it is, a lot of people consider the sound system broken if you can't just
write()to/dev/dspand have sound come out.
No disagreement, but that's not the point.
SND_PCM_OSS gives an OSS API interface for userspace on top of ALSA. ALSA drivers shouldn't care whether they are controlled directly through ALSA or through a legacy OSS API on top of ALSA.
If someone wants to use SND_PCM_OSS that is fine, but the ALSA interface to my saa7134 card is working fine, so why does it force me to compile a legacy OSS API interface into the kernel?
Quoted 1 line
Lee
cu
Adrian
Signature · 4 lines
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon SeedQuoted 13 lines · Adrian Bunk
Quoted 9 lines · Lee Revell
Quoted 2 lines · Adrian Bunk
There's no reason for an ALSA driver to select an OSS legacy userspace interface.
Actually there is a reason. While OSS may be deprecated the OSS API is not - ALSA is committed to supporting it for the forseeable future. And as broken an interface as it is, a lot of people consider the sound system broken if you can't just
write()to/dev/dspand have sound come out.No disagreement, but that's not the point.
Quoted 7 lines
SND_PCM_OSSgives an OSS API interface for userspace on top of ALSA. ALSA drivers shouldn't care whether they are controlled directly through ALSA or through a legacy OSS API on top of ALSA.If someone wants to use
SND_PCM_OSSthat is fine, but the ALSA interface to my saa7134 card is working fine, so why does it force me to compile a legacy OSS API interface into the kernel?
OK, makes sense.
Lee
Em Ter, 2006-01-10 às 05:06 +0100, Adrian Bunk escreveu:
Quoted 9 lines
There's no reason for an ALSA driver to select an OSS legacy userspace interface.
Signed-off-by Adrian Bunk <[email protected]>
drivers/media/video/saa7134/Kconfig line 21
Quoted 8 lines
drivers/media/video/saa7134/Kconfig renamed from drivers/media/video/saa7134/Kconfig.old +1
-1@@ -15,7 +15,7 @@ config VIDEO_SAA7134_ALSA tristate "Philips SAA7134 DMA audio support" depends on VIDEO_SAA7134 && SND - select SND_PCM_OSS + select SND_PCM ---help--- This is a video4linux driver for direct (DMA) audio in Philips SAA713x based TV cards using ALSA
I'll apply at v4l-dvb git tree.
Quoted 2 lines
Cheers,
Mauro.