Skip to contentSkip to conversation

arch/s390/Makefile: remove -finline-limit=10000

PATCH In review Adrian Bunk 3 participants 3 messages Jan 10, 2006 – Jan 11, 2006 s390

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arch/s390/Makefile: remove -finline-limit=10000

-finline-limit might have been required for older compilers, but nowadays it does no longer make sense.

arch/s390/Makefile renamed from arch/s390/Makefile.old +0 -1
@@ -67,7 +67,6 @@
 endif
 
 CFLAGS		+= -mbackchain -msoft-float $(cflags-y)
-CFLAGS		+= $(call cc-option,-finline-limit=10000)
 CFLAGS 		+= -pipe -fno-strength-reduce -Wno-sign-compare 
 AFLAGS		+= $(aflags-y)
 
#1 lore raw
Quoted 2 lines · Adrian Bunk

-finline-limit might have been required for older compilers, but nowadays it does no longer make sense.

I didn't check the effects of reverting to the default inline-limit, did you find any negative impacts? I'm thinking about the critical code paths e.g. minor faults. There better should not be an additional function call that would have been inlined with the bigger inline limit, since function calls are quite expensive on s390.

Signature · 6 lines
blue skies,
   Martin

Martin Schwidefsky
Linux for zSeries Development & Services
IBM Deutschland Entwicklung GmbH
#2 lore raw

From: Martin Schwidefsky <[email protected]>
Date: Wed, 11 Jan 2006 10:21:20 +0100

Quoted 9 lines · Adrian Bunk
Quoted 2 lines

-finline-limit might have been required for older compilers, but nowadays it does no longer make sense.

I didn't check the effects of reverting to the default inline-limit, did you find any negative impacts? I'm thinking about the critical code paths e.g. minor faults. There better should not be an additional function call that would have been inlined with the bigger inline limit, since function calls are quite expensive on s390.

You need to be careful now that -Os is specified by default in 2.6.x

The inline-limit GCC option is interpreted differently in gcc-4.x when -Os is given vs. when it is not.

On Sparc this caused schedule() to be inlined (I'm not kidding) which caused all kinds of troubles.

I highly recommed you don't specify it and let the compiler make the decisions, and add inline tags to places where you think it is hyper-important for inlining to occur.