Skip to contentSkip to conversation

mtd: update documentation of mtd_device_parse_register()

PATCH Applied Rafał Miłecki 3 participants 3 messages Mar 27, 2018 – Mar 29, 2018 Memory technology devices (MTD)

lore
Share & tools
lore

Rafał Miłecki

author
#0 lore raw

PATCH 1/1 mtd: update documentation of mtd_device_parse_register()

From: Rafał Miłecki <[email protected]>

In the commit 2c77c57d22adb ("mtd: move code adding master MTD out of mtd_add_device_partitions()") behavior of mtd_device_parse_register() has very slightly changed. It's a pretty non-significant order change to match updated function behavior.

Signed-off-by Rafał Miłecki <[email protected]>
---
 drivers/mtd/mtdcore.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
drivers/mtd/mtdcore.c +3 -4
index f25d65ea7149..20d5262c5b5c 100644
@@ -673,14 +673,13 @@ static void mtd_set_dev_defaults(struct mtd_info *mtd)
  * 'parse_mtd_partitions()') and MTD device and partitions registering. It
  * basically follows the most common pattern found in many MTD drivers:
  *
- * * It first tries to probe partitions on MTD device @mtd using parsers
+ * * If the MTD_PARTITIONED_MASTER option is set, then the device as a whole is
+ *   registered first.
+ * * Then It tries to probe partitions on MTD device @mtd using parsers
  *   specified in @types (if @types is %NULL, then the default list of parsers
  *   is used, see 'parse_mtd_partitions()' for more information). If none are
  *   found this functions tries to fallback to information specified in
  *   @parts/@nr_parts.
- * * If any partitioning info was found, this function registers the found
- *   partitions. If the MTD_PARTITIONED_MASTER option is set, then the device
- *   as a whole is registered first.
  * * If no partitions were found this function just registers the MTD device
  *   @mtd and exits.
  *
Signature · 1 line
2.11.0
maintainer Reviewed-by on v1 1/1
#1 lore raw

Am Dienstag, 27. März 2018, 15:36:47 CEST schrieb Rafał Miłecki:

Quoted 25 lines

From: Rafał Miłecki <[email protected]>

In the commit 2c77c57d22adb ("mtd: move code adding master MTD out of mtd_add_device_partitions()") behavior of mtd_device_parse_register() has very slightly changed. It's a pretty non-significant order change to match updated function behavior.

Signed-off-by Rafał Miłecki <[email protected]>
---
 drivers/mtd/mtdcore.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
drivers/mtd/mtdcore.c +3 -1
index f25d65ea7149..20d5262c5b5c 100644
@@ -673,14 +673,13 @@ static void mtd_set_dev_defaults(struct mtd_info *mtd)
  * 'parse_mtd_partitions()') and MTD device and partitions registering. It
  * basically follows the most common pattern found in many MTD drivers:
  *
- * * It first tries to probe partitions on MTD device @mtd using parsers
+ * * If the MTD_PARTITIONED_MASTER option is set, then the device as a whole is
+ *   registered first.
+ * * Then It tries to probe partitions on MTD device @mtd using parsers

drivers/mtd/mtdcore.c static void mtd_set_dev_defaults(struct mtd_info *mtd) · line 685

Quoted 10 lines
drivers/mtd/mtdcore.c +0 -3
  *   specified in @types (if @types is %NULL, then the default list of parsers
  *   is used, see 'parse_mtd_partitions()' for more information). If none are
  *   found this functions tries to fallback to information specified in
  *   @parts/@nr_parts.
- * * If any partitioning info was found, this function registers the found
- *   partitions. If the MTD_PARTITIONED_MASTER option is set, then the device
- *   as a whole is registered first.
  * * If no partitions were found this function just registers the MTD device
  *   @mtd and exits.
  *

Thanks for taking care of docs. :-)

Reviewed-by Richard Weinberger <[email protected]>

Thanks,
//richard

Applied
#2 lore raw
Quoted 9 lines · On Tue, 27 Mar 2018 21:18:14 +0200 Richard Weinberger <[email protected]> wrote:

Am Dienstag, 27. März 2018, 15:36:47 CEST schrieb Rafał Miłecki:

Quoted 8 lines

From: Rafał Miłecki <[email protected]>

In the commit 2c77c57d22adb ("mtd: move code adding master MTD out of mtd_add_device_partitions()") behavior of mtd_device_parse_register() has very slightly changed. It's a pretty non-significant order change to match updated function behavior.

Signed-off-by Rafał Miłecki <[email protected]>

Applied.

Thanks,

Boris

Quoted 35 lines
Quoted 17 lines
---
 drivers/mtd/mtdcore.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
drivers/mtd/mtdcore.c +3 -1
index f25d65ea7149..20d5262c5b5c 100644
@@ -673,14 +673,13 @@ static void mtd_set_dev_defaults(struct mtd_info *mtd)
  * 'parse_mtd_partitions()') and MTD device and partitions registering. It
  * basically follows the most common pattern found in many MTD drivers:
  *
- * * It first tries to probe partitions on MTD device @mtd using parsers
+ * * If the MTD_PARTITIONED_MASTER option is set, then the device as a whole is
+ *   registered first.
+ * * Then It tries to probe partitions on MTD device @mtd using parsers

drivers/mtd/mtdcore.c static void mtd_set_dev_defaults(struct mtd_info *mtd) · line 685

Quoted 10 lines
drivers/mtd/mtdcore.c +0 -3
  *   specified in @types (if @types is %NULL, then the default list of parsers
  *   is used, see 'parse_mtd_partitions()' for more information). If none are
  *   found this functions tries to fallback to information specified in
  *   @parts/@nr_parts.
- * * If any partitioning info was found, this function registers the found
- *   partitions. If the MTD_PARTITIONED_MASTER option is set, then the device
- *   as a whole is registered first.
  * * If no partitions were found this function just registers the MTD device
  *   @mtd and exits.
  *

Thanks for taking care of docs. :-)

Reviewed-by Richard Weinberger <[email protected]>

Thanks,
//richard

Signature · 3 lines
Boris Brezillon, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com