Skip to contentSkip to conversation

allow user to set domU xenstore UUID

RFC PATCH New Andrew D. Ball 1 participant 1 message Jan 18, 2006

lore
Share & tools
lore
#0 lore raw

RFC PATCH 1/1 allow user to set domU xenstore UUID

I'd like for the xenstore UUID for a domU to be able to stay the same across virtual power cycles of domU's. I believe this patch makes one approach for doing this possible.

I was unable to get the 01_localhost_pos xm-test test case to pass for an unpatched xen-unstable, so I have no data for whether this patch causes any regression for that particular test case. Anyone else's testing to verify no regression here would be appreciated as I improve my test environments.

Please let me know what you think.

Signature · 44 lines
Andrew D. Ball
[email protected]

"Festina Lente" $\approx$ "Make hast slowly"
  -- Caesar Augustus

=======================================================================
Treat xenstore UUID for domU's like MAC addresses for virtual network
interfaces -- can be set by user in domU configuration, but is 
generated randomly by default.

xm-test results: 
http://xmtest.dague.org/cgi-bin/display?view=single&testid=1228
[These are for pristine changeset 8627. I see no difference between
these and the results for changeset 8627 with this patch applied.]

Signed-off-by: Andrew D. Ball <[email protected]>

diff -r 9efe7eb108e1 -r 97aea0094880 tools/python/xen/xm/create.py
--- a/tools/python/xen/xm/create.py	Wed Jan  4 17:51:38 2006
+++ b/tools/python/xen/xm/create.py	Wed Jan 11 16:10:45 2006
@@ -395,6 +395,13 @@
 gopts.var('xauthority', val='XAUTHORITY',
           fn=set_value, default=None,
           use="X11 Authority to use")
+
+gopts.var('uuid', val='',
+          fn=set_value, default=None,
+          use="""xenstore UUID (universally unique identifier) to use.  One 
+          will be randomly generated if this option is not set, just like MAC 
+          addresses for virtual network interfaces.  This must be a unique 
+          value across the entire cluster.""")
 
 
 def err(msg):
@@ -566,6 +573,8 @@
     map(add_conf, ['name', 'memory', 'ssidref', 'maxmem', 'restart',
                    'on_poweroff', 'on_reboot', 'on_crash', 'vcpus'])
     
+    if vals.uuid is not None:
+        config.append(['uuid', vals.uuid])
     if vals.cpu is not None:
         config.append(['cpu', vals.cpu])
     if vals.cpus is not None:

Treat xenstore UUID for domU's like MAC addresses for virtual network interfaces -- can be set by user in domU configuration, but is generated randomly by default.

xm-test results:
http://xmtest.dague.org/cgi-bin/display?view=single&testid=1228
[These are for pristine changeset 8627. I see no difference between these and the results for changeset 8627 with this patch applied.]

tools/python/xen/xm/create.py +9 -0
diff -r 9efe7eb108e1 -r 97aea0094880 tools/python/xen/xm/create.py
@@ -395,6 +395,13 @@
 gopts.var('xauthority', val='XAUTHORITY',
           fn=set_value, default=None,
           use="X11 Authority to use")
+
+gopts.var('uuid', val='',
+          fn=set_value, default=None,
+          use="""xenstore UUID (universally unique identifier) to use.  One 
+          will be randomly generated if this option is not set, just like MAC 
+          addresses for virtual network interfaces.  This must be a unique 
+          value across the entire cluster.""")
 
 
 def err(msg):
@@ -566,6 +573,8 @@
     map(add_conf, ['name', 'memory', 'ssidref', 'maxmem', 'restart',
                    'on_poweroff', 'on_reboot', 'on_crash', 'vcpus'])
     
+    if vals.uuid is not None:
+        config.append(['uuid', vals.uuid])
     if vals.cpu is not None:
         config.append(['cpu', vals.cpu])
     if vals.cpus is not None:

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel