Skip to content Skip to conversation

BUG_ON() Conversion in net/tulip/xircom_cb.c

PATCH New Eric Sesterhenn / snakebyte 1 participant 1 message Jan 26, 2006

Subsystems (2)

Network drivers Kernel janitors

Share & tools

Eric Sesterhenn / snakebyte

author

2006-01-26 21:02 UTC #0 lore raw

PATCH 3/3 BUG_ON() Conversion in net/tulip/xircom_cb.c

hi,

this changes if() BUG(); constructs to BUG_ON() which is cleaner and can better optimized away

Signed-off-by Eric Sesterhenn <[email protected]>

drivers/net/tulip/xircom_cb.c renamed from drivers/net/tulip/xircom_cb.c.orig +2 -4

@@ -598,10 +598,8 @@ static void setup_descriptors(struct xir
 	enter("setup_descriptors");
 
 
-	if (card->rx_buffer == NULL)
-		BUG();
-	if (card->tx_buffer == NULL)
-		BUG();
+	BUG_ON(card->rx_buffer == NULL);
+	BUG_ON(card->tx_buffer == NULL);
 
 	/* Receive descriptors */
 	memset(card->rx_buffer, 0, 128);	/* clear the descriptors */

_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors