Skip to contentSkip to conversation

Create and Use common mempool allocators (Take 2)

PATCH In review Matthew Dobson 2 participants 2 messages Jan 30, 2006 – Jan 31, 2006

lore
Share & tools
lore
#0 lore raw

cover Create and Use common mempool allocators (Take 2)

--
In the course of working on some patches to implement subsystem-wide critical pools through the existing mempool API, I created the following patches which create 3 new common mempool allocators (mempool_alloc_pages, mempool_kmalloc & mempool_kzalloc) and freers. The following 6 patches add these new common allocators and convert existing mempool users to use these common allocators, where possible. Optionally, the last 2 patches in this series add and use a wrapper for the common case of creating a slab-based mempool.

After the application of these patches there are only 4 places where 'non-common' allocators are used (drivers/md/raid1.c & raid10.c, mm/highmem.c and drivers/scsi/scsi_transport_iscsi.c), and all of these are non-trivial allocators. The sum of these patches is a reduction of 90 lines of kernel code and the removal of many nearly identical mempool allocators.

New since Take 1:
* Added 4 mempool_create() wrappers to avoid both gratuitous casting and gratuitous cast warnings.
* Update to 2.6.16-rc1-mm4

Thanks!

-Matt

Acked-by on the v1 series
#1 lore raw
Quoted 7 lines · Matthew Dobson

In the course of working on some patches to implement subsystem-wide critical pools through the existing mempool API, I created the following patches which create 3 new common mempool allocators (mempool_alloc_pages, mempool_kmalloc & mempool_kzalloc) and freers. The following 6 patches add these new common allocators and convert existing mempool users to use these common allocators, where possible. Optionally, the last 2 patches in this series add and use a wrapper for the common case of creating a slab-based mempool.

Looks good to me.

Pekka