Skip to contentSkip to conversation

Style Fix in __constant_test_bit for S390, remove one set of ( )

PATCH New Eric Paris 1 participant 1 message Feb 2, 2006

lore
Share & tools
lore

Eric Paris

author
#0 lore raw

PATCH 1/1 Style Fix in __constant_test_bit for S390, remove one set of ( )

Right now in __constant_test_bit for the s390 there is an extra set of () surrounding the calculation. Putting it all on one line it could read like

return (( ((volatile char *) addr) [(nr^(__BITOPS_WORDSIZE-8))>>3] & (1<<(nr&7)) )) != 0;

This patch simply removes one set of () that is surrounding the whole clause.

---
 bitops.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
include/asm-s390/bitops.h renamed from include/asm-s390/bitops.h.old +2 -2
@@ -518,8 +518,8 @@ static inline int __test_bit(unsigned lo
 
 static inline int 
 __constant_test_bit(unsigned long nr, const volatile unsigned long *addr) {
-    return ((((volatile char *) addr)
-	    [(nr^(__BITOPS_WORDSIZE-8))>>3] & (1<<(nr&7)))) != 0;
+    return (((volatile char *) addr)
+	    [(nr^(__BITOPS_WORDSIZE-8))>>3] & (1<<(nr&7))) != 0;
 }
 
 #define test_bit(nr,addr) \