Skip to contentSkip to conversation

pci_set_drvdata()

KJ Matthew Martin 3 participants 3 messages Feb 6, 2006 Kernel janitors

lore
Share & tools
lore
#0 lore raw

On the TODO list it said to use pci_set_drvdata() to set dev->driver_data. So I did this file. Is this right?

--- original-linux-2.6.15/drivers/eisa/pci_eisa.c 2006-01-02
21:21:10.000000000 -0600
+++ linux-2.6.15/drivers/eisa/pci_eisa.c 2006-02-05 22:22:58.000000000
-0600
@@ -31,7 +31,7 @@ static int __devinit pci_eisa_init (stru
}

pci_eisa_root.dev = &pdev->dev;
- pci_eisa_root.dev->driver_data = &pci_eisa_root;
+ pci_set_drvdata(pdev,&pci_eisa_root);
pci_eisa_root.res = pdev->bus->resource[0];
pci_eisa_root.bus_base_addr = pdev->bus->resource[0]->start;
pci_eisa_root.slots = EISA_MAX_SLOTS;

_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors

#1 lore raw

Review static int __devinit pci_eisa_init (stru · line 37

Quoted 13 lines · Matthew Martin

--- original-linux-2.6.15/drivers/eisa/pci_eisa.c 2006-01-02
21:21:10.000000000 -0600
+++ linux-2.6.15/drivers/eisa/pci_eisa.c 2006-02-05 22:22:58.000000000
-0600

(quoted diff) +1 -1
@@ -31,7 +31,7 @@ static int __devinit pci_eisa_init (stru
 	}
 
 	pci_eisa_root.dev              = &pdev->dev;
-	pci_eisa_root.dev->driver_data = &pci_eisa_root;
+        pci_set_drvdata(pdev,&pci_eisa_root);
 	pci_eisa_root.res	       = pdev->bus->resource[0];
 	pci_eisa_root.bus_base_addr    = pdev->bus->resource[0]->start;
 	pci_eisa_root.slots	       = EISA_MAX_SLOTS;

You replace a tab with spaces here which is against CodingStyle.

Cheers, Tobias

_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors

#2 lore raw
In reply to Matthew Martin
Quoted 5 lines · Tobias Klauser

Review

Quoted 2 lines · Matthew Martin
(quoted diff) +1 -1
-	pci_eisa_root.dev->driver_data = &pci_eisa_root;
+        pci_set_drvdata(pdev,&pci_eisa_root);

You replace a tab with spaces here which is against CodingStyle.

And you should place a space after a comma.

_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors