alter prototypes in w83781d.c, w83627hf.c, sis5595.c,
Subsystems (3)
PATCH 1/1 alter prototypes in w83781d.c, w83627hf.c, sis5595.c,
G'day list,
To avoid me spamming you further here are the rest of the fixes for drivers/hwmon/
from http://linuxicc.sourceforge.net/
ICC complains about : Storage class not first.
In all these cases it appears to be because the prototype miss-names the reg variable as "register" which confuses ICC.
The patch below just re-names them all to reg which fits the actual functions.
drivers/hwmon/lm78.c renamed from drivers/hwmon/lm78.c.orig +2 -2
@@ -157,8 +157,8 @@ static int lm78_isa_attach_adapter(strucstatic int lm78_detect (struct i2c_adapter *adapter,int address,int kind);static int lm78_detach_client (struct i2c_client *client); -static int lm78_read_value (struct i2c_client *client,u8 register); -static int lm78_write_value (struct i2c_client *client,u8 register,u8 value); +static int lm78_read_value (struct i2c_client *client,u8 reg); +static int lm78_write_value (struct i2c_client *client,u8 reg,u8 value);static struct lm78_data *lm78_update_device (struct device *dev);static void lm78_init_client (struct i2c_client *client);
drivers/hwmon/lm85.c renamed from drivers/hwmon/lm85.c.orig +2 -2
@@ -373,8 +373,8 @@ static int lm85_detect(struct i2c_adapte int kind);static int lm85_detach_client (struct i2c_client *client); -static int lm85_read_value (struct i2c_client *client,u8 register); -static int lm85_write_value (struct i2c_client *client,u8 register,int value); +static int lm85_read_value (struct i2c_client *client,u8 reg); +static int lm85_write_value (struct i2c_client *client,u8 reg,int value);static struct lm85_data *lm85_update_device (struct device *dev);static void lm85_init_client (struct i2c_client *client);
drivers/hwmon/sis5595.c renamed from drivers/hwmon/sis5595.c.orig +2 -2
@@ -192,8 +192,8 @@ static struct pci_dev *s_bridge; /* poinstatic int sis5595_detect (struct i2c_adapter *adapter);static int sis5595_detach_client (struct i2c_client *client); -static int sis5595_read_value (struct i2c_client *client,u8 register); -static int sis5595_write_value (struct i2c_client *client,u8 register,u8 value); +static int sis5595_read_value (struct i2c_client *client,u8 reg); +static int sis5595_write_value (struct i2c_client *client,u8 reg,u8 value);static struct sis5595_data *sis5595_update_device (struct device *dev);static void sis5595_init_client (struct i2c_client *client);
drivers/hwmon/w83627hf.c renamed from drivers/hwmon/w83627hf.c.orig +2 -2
@@ -325,8 +325,8 @@ struct w83627hf_data {static int w83627hf_detect (struct i2c_adapter *adapter);static int w83627hf_detach_client (struct i2c_client *client); -static int w83627hf_read_value (struct i2c_client *client,u16 register); -static int w83627hf_write_value (struct i2c_client *client,u16 register, +static int w83627hf_read_value (struct i2c_client *client,u16 reg); +static int w83627hf_write_value (struct i2c_client *client,u16 reg,u16 value);static struct w83627hf_data *w83627hf_update_device (struct device *dev);static void w83627hf_init_client (struct i2c_client *client);
drivers/hwmon/w83781d.c renamed from drivers/hwmon/w83781d.c.orig +2 -2
@@ -262,8 +262,8 @@ static int w83781d_isa_attach_adapter(ststatic int w83781d_detect (struct i2c_adapter *adapter,int address,int kind);static int w83781d_detach_client (struct i2c_client *client); -static int w83781d_read_value (struct i2c_client *client,u16 register); -static int w83781d_write_value (struct i2c_client *client,u16 register, +static int w83781d_read_value (struct i2c_client *client,u16 reg); +static int w83781d_write_value (struct i2c_client *client,u16 reg,u16 value);static struct w83781d_data *w83781d_update_device (struct device *dev);static void w83781d_init_client (struct i2c_client *client);
_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors
Jean Delvare
AppliedRe: [KJ][Patch] alter prototypes in w83781d.c, w83627hf.c,
Hi Darren,
Quoted 5 lines
To avoid me spamming you further here are the rest of the fixes for
drivers/hwmon/
Quoted 7 lines
ICC complains about : Storage class not first.
In all these cases it appears to be because the prototype miss-names the reg variable as "register" which confuses ICC.
The patch below just re-names them all to reg which fits the actual functions.
I've merged all four patches in a single one, which I'll push to Greg in the next batch of patches. Thanks!
Signature · 1 line
Jean Delvare
_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors