Skip to contentSkip to conversation

make UNIX a bool]

PATCH In review James C. Georgas 2 participants 7 messages Mar 3, 2006 – Mar 7, 2006

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 make UNIX a bool]

Quoted 6 lines · Adrian Bunk
Quoted 5 lines · Jesper Juhl
Quoted 4 lines · Adrian Bunk
Quoted 3 lines · Herbert Xu
Quoted 2 lines · Adrian Bunk

It does also matter in the kernel image size case, since you

have to put

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

enough modules to the other medium for having a effect bigger

than the

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 1 line

kernel image size increase from setting CONFIG_MODULES=y.

That's not very difficult considering the large number of

modules that's

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 2 lines

out there that a system may wish to use.
...

This might be true for full-blown desktop systems - but these do

not

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines

tend to be the systems where kernel image size matters that much. Smaller kernel image size might be an issue e.g. for distribution kernels, but in a much less pressing way.

The systems where kernel image size really matters are systems

with few

Quoted 1 line
Quoted 1 line
Quoted 1 line

modules where you know in advance which modules you might need. I

played

Quoted 1 line
Quoted 1 line
Quoted 1 line

a bit with the ARM defconfigs, and if you consider that you can't

build

Quoted 1 line
Quoted 1 line
Quoted 1 line

the filesystem for accessing your modules modular I haven't found

any

Quoted 1 line
Quoted 1 line
Quoted 1 line

where making everything modular would have given a real kernel

image

Quoted 8 lines
Quoted 6 lines
Quoted 2 lines

size gain compared to the CONFIG_MODULES=n case.

I believe the basic question is this: What do we win by making CONFIG_UNIX a bool?
...

We do not have to export symbols we don't want to export to modules

but

Quoted 1 line

needed by CONFIG_UNIX.

Sorry, I must just be dense, or something.

Is not the only difference between a modular driver and a built in driver supposed to be the initialization and cleanup functions?

I don't see why you would have to expose any additional symbols, over and above the existing required symbols, to load your module.

Signature · 1 line
James C. Georgas <[email protected]>
#1 lore raw

Re: [2.6 patch] make UNIX a bool

Quoted 6 lines · Adrian Bunk
Quoted 5 lines · Jesper Juhl
Quoted 4 lines · Adrian Bunk
Quoted 3 lines · Herbert Xu
Quoted 2 lines · Adrian Bunk

It does also matter in the kernel image size case, since you

have to put

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

enough modules to the other medium for having a effect bigger

than the

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 1 line

kernel image size increase from setting CONFIG_MODULES=y.

That's not very difficult considering the large number of

modules that's

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 2 lines

out there that a system may wish to use.
...

This might be true for full-blown desktop systems - but these do

not

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines

tend to be the systems where kernel image size matters that much. Smaller kernel image size might be an issue e.g. for distribution kernels, but in a much less pressing way.

The systems where kernel image size really matters are systems

with few

Quoted 1 line
Quoted 1 line
Quoted 1 line

modules where you know in advance which modules you might need. I

played

Quoted 1 line
Quoted 1 line
Quoted 1 line

a bit with the ARM defconfigs, and if you consider that you can't

build

Quoted 1 line
Quoted 1 line
Quoted 1 line

the filesystem for accessing your modules modular I haven't found

any

Quoted 1 line
Quoted 1 line
Quoted 1 line

where making everything modular would have given a real kernel

image

Quoted 8 lines
Quoted 6 lines
Quoted 2 lines

size gain compared to the CONFIG_MODULES=n case.

I believe the basic question is this: What do we win by making CONFIG_UNIX a bool?
...

We do not have to export symbols we don't want to export to modules

but

Quoted 1 line

needed by CONFIG_UNIX.

Sorry, I must just be dense, or something.

Is not the only difference between a modular driver and a built in driver supposed to be the initialization and cleanup functions?

I don't see why you would have to expose any additional symbols, over and above the existing required symbols, to load your module.

Signature · 1 line
James C. Georgas <[email protected]>
#2 lore raw

Re: [2.6 patch] make UNIX a bool

Quoted 11 lines · On Thu, 02 Mar 2006 23:14:38 -0500 "James C. Georgas" <[email protected]>…
Quoted 2 lines · Adrian Bunk

We do not have to export symbols we don't want to export to modules but needed by CONFIG_UNIX.

Sorry, I must just be dense, or something.

Is not the only difference between a modular driver and a built in driver supposed to be the initialization and cleanup functions?

I don't see why you would have to expose any additional symbols, over and above the existing required symbols, to load your module.

af_unix (IE: CONFIG_UNIX) currently uses the symbol get_max_files. It is the only module that uses that symbol, and that symbol probably should not be exported as it's kind of an internal API. Therefore if we mandate that CONFIG_UNIX != m, then that symbol may be properly unexported and made private, because nothing modular would use it. Does that clear things up?

P.S.: Please don't remove people from the CC list if you expect them to respond to your message (Adrian Bunk readded to CC).

Cheers,
Kyle Moffett

#3 lore raw

Re: [2.6 patch] make UNIX a bool

Quoted 13 lines · Kyle Moffett
Quoted 11 lines · On Thu, 02 Mar 2006 23:14:38 -0500 "James C. Georgas" <[email protected]>…
Quoted 2 lines · Adrian Bunk

We do not have to export symbols we don't want to export to modules but needed by CONFIG_UNIX.

Sorry, I must just be dense, or something.

Is not the only difference between a modular driver and a built in driver supposed to be the initialization and cleanup functions?

I don't see why you would have to expose any additional symbols, over and above the existing required symbols, to load your module.

Quoted 7 lines

af_unix (IE: CONFIG_UNIX) currently uses the symbol get_max_files. It is the only module that uses that symbol, and that symbol probably should not be exported as it's kind of an internal API. Therefore if we mandate that CONFIG_UNIX != m, then that symbol may be properly unexported and made private, because nothing modular would use it. Does that clear things up?

Yes, I think I understand.

However, even if you don't export the symbol, I don't see how you can make it private (i.e. static declaration) to file_table.c, since it has to remain extern, in order to be visible to af_unix.c.

Quoted 2 lines

P.S.: Please don't remove people from the CC list if you expect them to respond to your message (Adrian Bunk readded to CC).

Whoops. I should've hit "reply to all" instead of just hitting "reply". Thanks. I also somehow got this post split off from the main thread. I've been responding there.

Quoted 8 lines

Cheers,
Kyle Moffett
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Signature · 1 line
James C. Georgas <[email protected]>
#4 lore raw

Re: [2.6 patch] make UNIX a bool

Quoted 6 lines · James C. Georgas
Quoted 1 line · Kyle Moffett

af_unix (IE: CONFIG_UNIX) currently uses the symbol get_max_files. It is the only module that uses that symbol, and that symbol probably should not be exported as it's kind of an internal API. Therefore if we mandate that CONFIG_UNIX != m, then that symbol may be properly unexported and made private, because nothing modular would use it. Does that clear things up?

Yes, I think I understand.

However, even if you don't export the symbol, I don't see how you can make it private (i.e. static declaration) to file_table.c, since it has to remain extern, in order to be visible to af_unix.c.

You're missing some crucial information about how Linux operates. EXPORT_SYMBOL != extern. Basically, Linux maintains a list of symbols that dynamically loaded modules are allowed to use, along with some technical usage restrictions on each (Symbols exported with EXPORT_SYMBOL_GPL may only be used by modules that declare 'MODULE_LICENSE("GPL");'.) Exporting a symbol increases the likliehood that some module author will use it inappropriately, and bloats the kernel. In this case, removing the EXPORT_SYMBOL() would be a good thing.

Cheers,
Kyle Moffett

#5 lore raw

Re: [2.6 patch] make UNIX a bool

Quoted 15 lines · Kyle Moffett
Quoted 8 lines · James C. Georgas
Quoted 6 lines · Kyle Moffett

af_unix (IE: CONFIG_UNIX) currently uses the symbol get_max_files. It is the only module that uses that symbol, and that symbol probably should not be exported as it's kind of an internal API. Therefore if we mandate that CONFIG_UNIX != m, then that symbol may be properly unexported and made private, because nothing modular would use it. Does that clear things up?

Quoted 5 lines

Yes, I think I understand.

However, even if you don't export the symbol, I don't see how you can make it private (i.e. static declaration) to file_table.c, since it has to remain extern, in order to be visible to af_unix.c.

Quoted 9 lines

You're missing some crucial information about how Linux operates. EXPORT_SYMBOL != extern. Basically, Linux maintains a list of symbols that dynamically loaded modules are allowed to use, along with some technical usage restrictions on each (Symbols exported with EXPORT_SYMBOL_GPL may only be used by modules that declare 'MODULE_LICENSE("GPL");'.) Exporting a symbol increases the likliehood that some module author will use it inappropriately, and bloats the kernel. In this case, removing the EXPORT_SYMBOL() would be a good thing.

Isn't it kind of pointless to not EXPORT a symbol if the symbol is still declared globally in an include/linux/ header file? If the intent is to prevent abuse of the symbol, then this doesn't do it, because I can just statically compile my module into the kernel, and keep on using that symbol.

It makes sense to me to remove the EXPORT of geget_max_filest_max_files, if the intent is to eventually remove

I was under the impression that Adrian wanted

Quoted 4 lines

Cheers,
Kyle Moffett

Signature · 1 line
James C. Georgas <[email protected]>
#6 lore raw

Re: [2.6 patch] make UNIX a bool

In reply to Kyle Moffett

Excuse me - sent half a response earlier.

Quoted 15 lines · Kyle Moffett
Quoted 8 lines · James C. Georgas
Quoted 6 lines · Kyle Moffett

af_unix (IE: CONFIG_UNIX) currently uses the symbol get_max_files. It is the only module that uses that symbol, and that symbol probably should not be exported as it's kind of an internal API. Therefore if we mandate that CONFIG_UNIX != m, then that symbol may be properly unexported and made private, because nothing modular would use it. Does that clear things up?

Quoted 5 lines

Yes, I think I understand.

However, even if you don't export the symbol, I don't see how you can make it private (i.e. static declaration) to file_table.c, since it has to remain extern, in order to be visible to af_unix.c.

Quoted 9 lines

You're missing some crucial information about how Linux operates. EXPORT_SYMBOL != extern. Basically, Linux maintains a list of symbols that dynamically loaded modules are allowed to use, along with some technical usage restrictions on each (Symbols exported with EXPORT_SYMBOL_GPL may only be used by modules that declare 'MODULE_LICENSE("GPL");'.) Exporting a symbol increases the likliehood that some module author will use it inappropriately, and bloats the kernel. In this case, removing the EXPORT_SYMBOL() would be a good thing.

Isn't it kind of pointless to not EXPORT a symbol if the symbol is still declared globally in an include/linux/ header file? If the intent is to prevent abuse of the symbol, then this doesn't do it, because I can just statically compile my module into the kernel, and keep on using that symbol.

It makes sense to me to remove the EXPORT of get_max_files only if the intent is to eventually remove the get_max_files function from include/linux/fs.h.

This would require that af_unix.c calculate the maximum number of allowed open Unix sockets from information other than the files_stat.max_files value is fs/file_table.c.

If that's the intent, then there's no point in disallowing AF_UNIX=m. Doing this just so one can unEXPORT a symbol only fixes half the issue.

Quoted 3 lines

Cheers,
Kyle Moffett

Signature · 1 line
James C. Georgas <[email protected]>