Skip to contentSkip to conversation

let NET_CLS_ACT no longer depend on EXPERIMENTAL

RFC PATCH Applied Adrian Bunk 4 participants 5 messages Mar 4, 2006 – Mar 10, 2006

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

RFC PATCH 1/1 let NET_CLS_ACT no longer depend on EXPERIMENTAL

This option should IMHO no longer depend on EXPERIMENTAL.

---

This patch was already sent on:
- 12 Feb 2006

net/sched/Kconfig renamed from net/sched/Kconfig.old +0 -1
@@ -434,7 +434,6 @@
 
 config NET_CLS_ACT
 	bool "Actions"
-	depends on EXPERIMENTAL
 	select NET_ESTIMATOR
 	---help---
 	  Say Y here if you want to use traffic control actions. Actions
#1 lore raw
Quoted 9 lines · Adrian Bunk

This option should IMHO no longer depend on EXPERIMENTAL.

---

This patch was already sent on:
- 12 Feb 2006

Yesterday I managed to crash my machine playing around with tc actions within minutes. I haven't looked into it yet, but it seems it still needs more testing.

Acked-by
#2 lore raw
Quoted 6 lines · Patrick McHardy
Quoted 5 lines · Adrian Bunk

This option should IMHO no longer depend on EXPERIMENTAL.

Quoted 8 lines
Quoted 4 lines

---

This patch was already sent on:
- 12 Feb 2006

Yesterday I managed to crash my machine playing around with tc actions within minutes. I haven't looked into it yet, but it seems it still needs more testing.

Simple: Fix the bug and submit a patch. If you cant find the cause post what you are doing.

What is the metric for going from experimental to non-experimental? I surely hope it doesnt come to some irrational reasoning like "Patrick found a bug"[1].
- It has been around since 2.6.7/8;
- I use it extensively on about 10 machines since (I am pretty sure a lot more extensively than Patrick)
- I know people who use it extensively
- I am pretty sure there are people that i dont know who use it extensively

So on Adrian's patch and above reasoning:

cheers,
jamal

[1]If you used half of that logic on netfilter it would still be experimental or rather should be demoted to experimental.

#3 lore raw
Quoted 7 lines · jamal
Quoted 5 lines · Patrick McHardy
Quoted 2 lines · Adrian Bunk

This option should IMHO no longer depend on EXPERIMENTAL.

Quoted 7 lines
Quoted 3 lines

Yesterday I managed to crash my machine playing around with tc actions within minutes. I haven't looked into it yet, but it seems it still needs more testing.

Simple: Fix the bug and submit a patch. If you cant find the cause post what you are doing.

I'll fix it.

Quoted 3 lines

What is the metric for going from experimental to non-experimental? I surely hope it doesnt come to some irrational reasoning like "Patrick found a bug"[1].

I think a sane metric is "opinion of people who know the code". But I don't care much, I don't think many people care whether something is maked experimental or not.

Quoted 2 lines

[1]If you used half of that logic on netfilter it would still be experimental or rather should be demoted to experimental.

I'll take that as a compliment :)