Skip to contentSkip to conversation

Coverity #733

PATCH In review Frank Filz 1 participant 1 message Mar 27, 2006

Subsystems (2)
lore
Share & tools
lore

Frank Filz

author
#0 lore raw

PATCH 2/4 Coverity #733

This one could be considered a false positive since the only call to nfs4_acl_nfsv4_to_posix() passes in a non-NULL pointer to dpacl, but the code does check for non-NULL dpacl later.

Signed-off by: Frank Filz

fs/nfsd/nfs4acl.c +3 -1
@@ -378,7 +378,9 @@ nfs4_acl_nfsv4_to_posix(struct nfs4_acl 
 	int error = -ENOMEM;
 
 	*pacl = NULL;
-	*dpacl = NULL;
+
+	if (dpacl != NULL)
+		*dpacl = NULL;
 
 	dacl = nfs4_acl_new();
 	if (dacl == NULL)

-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs