Skip to contentSkip to conversation

I/OAT

PATCH In review Chris Leech 2 participants 3 messages Mar 29, 2006 – Mar 31, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 2/9 I/OAT

[I/OAT] Driver for the Intel(R) I/OAT DMA engine

From: Chris Leech <[email protected]>

Adds a new ioatdma driver

---

 drivers/dma/Kconfig             |    9 
 drivers/dma/Makefile            |    1 
 drivers/dma/ioatdma.c           |  805
+++++++++++++++++++++++++++++++++++++++
 drivers/dma/ioatdma.h           |  126 ++++++
 drivers/dma/ioatdma_hw.h        |   52 +++
 drivers/dma/ioatdma_io.h        |  118 ++++++
 drivers/dma/ioatdma_registers.h |  128 ++++++
 7 files changed, 1239 insertions(+), 0 deletions(-)
#1 lore raw
Quoted 7 lines · Chris Leech

[I/OAT] Driver for the Intel(R) I/OAT DMA engine

From: Chris Leech <[email protected]>

Adds a new ioatdma driver

Let's do it again.
Could you please describe how struct ioat_dma_chan channels are freed? For example when device is removed just after it has been added.

ioat_probe() -> enumerate_dma_channels() (failures are ok now) -> kmalloc a lot of channels.

ioat_remove() -> dma_async_device_unregister() which does not cleanup ioat_dma_chan channels, but only clients.
It ends up in dma_async_device_cleanup() only.

Signature · 1 line
	Evgeniy Polyakov
#2 lore raw
Quoted 1 line

Could you please describe how struct ioat_dma_chan channels are freed?

Sorry, I got distracted by other issues and never ended up following up on this. You're right, and it's just sloppiness on my part for missing it, those structs are being leaked on module unload. I'll fix it. Thanks.

-Chris