Skip to contentSkip to conversation

spin_lock in check_monotonic_clock must be raw

PATCH Applied Steven Rostedt 2 participants 2 messages Mar 30, 2006 – Mar 31, 2006

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 spin_lock in check_monotonic_clock must be raw

Hi Ingo,

The lock in check_monotonic_clock must be a raw spinlock since it is called from the hrtimer_interrupt.

-- Steve

kernel/time/timeofday.c +1 -1
Index: linux-2.6.16-rt11/kernel/time/timeofday.c
===================================================================
@@ -125,7 +125,7 @@
 
 #ifdef CONFIG_PARANOID_GENERIC_TIME
 /* This will hurt performance! */
-static DEFINE_SPINLOCK(check_monotonic_lock);
+static DEFINE_RAW_SPINLOCK(check_monotonic_lock);
 static ktime_t last_monotonic_ktime;
 
 static ktime_t get_check_value(void)
Applied
#1 lore raw
Quoted 4 lines · Steven Rostedt

Hi Ingo,

The lock in check_monotonic_clock must be a raw spinlock since it is called from the hrtimer_interrupt.

thanks, applied.

Ingo