Skip to contentSkip to conversation

KVME080 Support

PATCH New DENX Support System 1 participant 1 message Mar 31, 2006

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 KVME080 Support

Hello list,

inside the automatic U-Boot patch tracking system a new ticket [DNX#2006033142000231] was created:

<snip>

Quoted 25 lines

Hi Wolfgang,

Quoted 1 line · Wolfgang Denk

In message <004e01c5a3db$3840e6f0$212d4cdc@smkim> you wrote:

[snip]

Quoted 9 lines

And please cleanup your code before re-submitting:

* It violates the coding style requirements (trailing white space).

* Using globally visible preprocessor defines like FLASH_WRITE64 is not acceptable (you also forgot to document these, but that would help either), and defining such code in the board config file is the wrong way to implement it either. The board config file is - ummm, a _configuration_ file, but does not contain source code.

IIRC, you posted a couple of scripts that tested for formatting violations. Per my previous suggestion of putting the patch rules on your web site, I would like to see the formatting test scripts posted too. If these were on the DULG twiki, they could be collaboratively tuned.

[snip]

Quoted 8 lines
Quoted 5 lines

Rejected, sorry.

Best regards,

Wolfgang Denk

Thanks,
gvb

</snip>

Your U-Boot support team