Skip to contentSkip to conversation

add support for AMD Alc [...]

PATCH DENX Support System 1 participant 1 message Mar 31, 2006

lore
Share & tools
lore
#0 lore raw

Hello list,

inside the automatic U-Boot patch tracking system a new ticket [DNX#2006033142000374] was created:

<snip>

Quoted 23 lines · Wolfgang Denk
Quoted 6 lines
Quoted 2 lines

I've also fixed the mii and usb commands which can dereference a null pointer when called without arguments.

No, this is not possible. The command definition requires always at least one argument. This part rejected.

I beg to differ - I've seen this problem also. The code in main.c:run_command() checks for more than more than a maximum but never checks a minimum number of arguments, so entering mii<CR> makes cmd_mii get called with argv[0] = 'mii' and argc = 1. main.c:parse_line() sets argv[1] to NULL.

The code in cmd_mii.c assumes there will be a valid argv[1], but never checks argc before using argv[1]. This leads to an exception on machines where 0 is not a valid address (like MIPS).

--
Hardware, n.:
The parts of a computer system that can be kicked.

Quoted 10 lines

-------------------------------------------------------
SF.Net email is sponsored by:
Tame your development challenges with Apache's Geronimo App Server. Download
it for free - -and be entered to win a 42" plasma tv or your very own Sony(tm)PSP. Click here to play: http://sourceforge.net/geronimo.php
_______________________________________________
U-Boot-Users mailing list
U-Boot-Users at lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

</snip>

Your U-Boot support team