fix kbuild warnings in savagefb.o

G'day list

There are a few kbuild warnings in drivers/video/savage/

WARNING: drivers/video/savage/savagefb.o - Section mismatch: reference to .init.data:savagefb_devices from .data between 'savagefb_driver' (at offset 0x38) and 'savagefb_ops'

This one is the same false positive for the pci device id as before.

WARNING: drivers/video/savage/savagefb.o - Section mismatch: reference to .init.text: from .exit.text after 'savagefb_remove' (at offset 0x6e)
WARNING: drivers/video/savage/savagefb.o - Section mismatch: reference to .init.text: from .exit.text after 'savagefb_remove' (at offset 0x66)

These two are caused by savagefb_remove() which is marked __devexit calling savage_unmap_mmio() and savage_unmap_video() which are marked as __devinit.

WARNING: drivers/video/savage/savagefb.o - Section mismatch: reference to .init.text: from .text between 'savagefb_resume' (at offset 0x232b) and 'savage4_gpio_getscl'

This one is caused by savagefb_resume() which is un-annotated calling savage_init_hw() which is marked as __devinit.

The patch below removes the __devinit annotations in all three cases.

@@ -1545,7 +1545,7 @@ static int __devinit savage_map_mmio (st
 	return 0;
 }
 
-static void __devinit savage_unmap_mmio (struct fb_info *info)
+static void savage_unmap_mmio (struct fb_info *info)
 {
 	struct savagefb_par *par = info->par;
 	DBG ("savage_unmap_mmio");

@@ -1597,7 +1597,7 @@ static int __devinit savage_map_video (s
 	return 0;
 }
 
-static void __devinit savage_unmap_video (struct fb_info *info)
+static void savage_unmap_video (struct fb_info *info)
 {
 	struct savagefb_par *par = info->par;
 

@@ -1614,7 +1614,7 @@ static void __devinit savage_unmap_video
 	}
 }
 
-static int __devinit savage_init_hw (struct savagefb_par *par)
+static int savage_init_hw (struct savagefb_par *par)
 {
 	unsigned char config1, m, n, n1, n2, sr8, cr3f, cr66 = 0, tmp;
 

_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors