Skip to contentSkip to conversation

allow dom0 to power off machine using ACPI on shutdown.]

RFC PATCH New Harry Butterworth 1 participant 1 message Apr 7, 2006

lore
Share & tools
lore
#0 lore raw

RFC PATCH 1/1 allow dom0 to power off machine using ACPI on shutdown.]

Ewan,

Keir seems to think this patch is OK. I tested it on an
Intellistation A Pro for x86_64 and it works for me. I think it is low risk because it's executed at the end of the shutdown process. Please apply.

http://lists.xensource.com/archives/html/xen-devel/2006-04/msg00223.html

Quoted 9 lines · Harry Butterworth

It might be better to install the hypervisor call in pm_power_off and let it get replaced by the acpi_power_off call if ACPI is detected. That would seem to fit in better with the way the x86 arch handles multiple power off strategies.

I haven't looked to see how the other architectures do power off yet.

Was hoping for some comment about whether to do power off in xen or in domU and whether the hypervisor needed notification.

I think your patch looked okay for now, actually. Alternatively our machine_restart() could be moved into arch-specific code files. Doing the power off in dom0 is fine -- as you say, Xen doesn't do anyhting special before shutdown.

-- Keir

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel