Skip to contentSkip to conversation

Overrun in sound/pci/au88x0/au88x0_pcm.c

PATCH In review Eric Sesterhenn 2 participants 2 messages Apr 10, 2006 – Apr 11, 2006 Sound

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Overrun in sound/pci/au88x0/au88x0_pcm.c

hi,

since idx is used as an index for vortex_pcm_prettyname[VORTEX_PCM_LAST], it should not be equal to VORTEX_PCM_LAST. This fixes coverity bug id #572

sound/pci/au88x0/au88x0_pcm.c renamed from sound/pci/au88x0/au88x0_pcm.c.orig +1 -1
@@ -506,7 +506,7 @@ static int __devinit snd_vortex_new_pcm(
 	int i;
 	int err, nr_capt;
 
-	if ((chip == 0) || (idx < 0) || (idx > VORTEX_PCM_LAST))
+	if ((chip == 0) || (idx < 0) || (idx >= VORTEX_PCM_LAST))
 		return -ENODEV;
 
 	/* idx indicates which kind of PCM device. ADB, SPDIF, I2S and A3D share the 
#1 lore raw

Please send all ALSA bug fixes to alsa-devel (cc'ed)

Quoted 21 lines · Eric Sesterhenn

hi,

since idx is used as an index for vortex_pcm_prettyname[VORTEX_PCM_LAST], it should not be equal to VORTEX_PCM_LAST. This fixes coverity bug id #572

sound/pci/au88x0/au88x0_pcm.c renamed from sound/pci/au88x0/au88x0_pcm.c.orig +1 -2
@@ -506,7 +506,7 @@ static int __devinit snd_vortex_new_pcm(
 	int i;
 	int err, nr_capt;
 
-	if ((chip == 0) || (idx < 0) || (idx > VORTEX_PCM_LAST))
+	if ((chip == 0) || (idx < 0) || (idx >= VORTEX_PCM_LAST))
 		return -ENODEV;
 
 	/* idx indicates which kind of PCM device. ADB, SPDIF, I2S and A3D share the 
 
 
-
Quoted 5 lines

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642