Memory leak in sound/pcmcia/pdaudiocf/pdaudiocf.c
PATCH 1/1 Memory leak in sound/pcmcia/pdaudiocf/pdaudiocf.c
hi,
if one of the first three CS_CHECKS fails, we goto cs_failed:
In this case parse we donr kfree() parse. Since the the last three CS_CHECKS might also fail, i moved the kfree() below all the CS_CHECKs and added one in the error path. This fixes coverity bug id #1099
sound/pcmcia/pdaudiocf/pdaudiocf.c renamed from sound/pcmcia/pdaudiocf/pdaudiocf.c.orig +3 -1
@@ -241,12 +241,13 @@ static int pdacf_config(struct pcmcia_deCS_CHECK (ParseTuple,pcmcia_parse_tuple (link, &tuple, parse)); link->conf.ConfigBase = parse->config.base; link->conf.ConfigIndex =0x5 ; -kfree (parse);CS_CHECK (RequestIO,pcmcia_request_io (link, &link->io));CS_CHECK (RequestIRQ,pcmcia_request_irq (link, &link->irq));CS_CHECK (RequestConfiguration,pcmcia_request_configuration (link, &link->conf)); +kfree (parse); +if (snd_pdacf_assign_resources (pdacf, link->io.BasePort1, link->irq.AssignedIRQ) <0 ) goto failed;
@@ -254,6 +255,7 @@ static int pdacf_config(struct pcmcia_dereturn 0 ; cs_failed: +kfree (parse);cs_error (link, last_fn, last_ret); failed:pcmcia_disable_device (link);
-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
Takashi Iwai
AppliedAt Wed, 12 Apr 2006 11:58:05 +0200,
Quoted 9 lines · Eric Sesterhenn
hi,
if one of the first three
CS_CHECKSfails, we gotocs_failed:
In this case parse we donrkfree()parse. Since the the last threeCS_CHECKSmight also fail, i moved thekfree()below all theCS_CHECKsand added one in the error path. This fixes coverity bug id #1099Signed-off-by Eric Sesterhenn <[email protected]>
Thanks, applied to ALSA tree now.
Takashi
-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642