Skip to contentSkip to conversation

don't always need to build x86 firmware

PATCH In review Al Stone 2 participants 3 messages Apr 12, 2006

lore
Share & tools
lore

Al Stone

author
#0 lore raw

PATCH 1/1 don't always need to build x86 firmware

In the tools part of xen, if you have bcc installed, 'make tools' will try to compile all of the x86 firmware (ACPI, ROM BIOS, VGA BIOS). This patch turns that off if we're building for ia64, where we don't really need it (yet). It may be necessary to turn this off for PowerPC, too, but I don't have one of those to test on.

Tested with 'make tools' on ia64 Debian GNU/Linux (unstable)

Signature · 8 lines
Ciao,
al
----------------------------------------------------------------------
Al Stone                                      Alter Ego:
Open Source and Linux R&D                     Debian Developer
Hewlett-Packard Company                       http://www.debian.org
E-mail: [email protected]                        [email protected]
----------------------------------------------------------------------
tools/Makefile +2 -0
diff -r 5cc367720223 -r d5318d3a8ced tools/Makefile
@@ -8,7 +8,9 @@ SUBDIRS += examples
 SUBDIRS += examples
 SUBDIRS += xentrace
 SUBDIRS += xcutils
+ifneq ($(XEN_TARGET_ARCH),ia64)
 SUBDIRS += firmware
+endif
 SUBDIRS += security
 SUBDIRS += console
 SUBDIRS += xenmon

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel

#1 lore raw

tools/Makefile Wed Apr 12 10:39:06 2006 -0600 SUBDIRS += examples · line 16

Quoted 13 lines · Al Stone

diff -r 5cc367720223 -r d5318d3a8ced tools/Makefile

tools/Makefile Wed Apr 12 10:39:06 2006 -0600 renamed from tools/Makefile Tue Apr 11 18:54:18 2006 -0600 +2 -0
@@ -8,7 +8,9 @@ SUBDIRS += examples
 SUBDIRS += examples
 SUBDIRS += xentrace
 SUBDIRS += xcutils
+ifneq ($(XEN_TARGET_ARCH),ia64)
 SUBDIRS += firmware
+endif
 SUBDIRS += security
 SUBDIRS += console
 SUBDIRS += xenmon 

Instead of this, could you have a look at converting tools/Makefile to use the subdirs-$(foo) syntax that the xen/ Makefiles are using?

Signature · 2 lines
Hollis Blanchard
IBM Linux Technology Center
author
#2 lore raw
Quoted 17 lines · Hollis Blanchard

tools/Makefile Wed Apr 12 10:39:06 2006 -0600 SUBDIRS += examples · line 16

Quoted 13 lines · Al Stone

diff -r 5cc367720223 -r d5318d3a8ced tools/Makefile

tools/Makefile Wed Apr 12 10:39:06 2006 -0600 renamed from tools/Makefile Tue Apr 11 18:54:18 2006 -0600 +2 -0
@@ -8,7 +8,9 @@ SUBDIRS += examples
 SUBDIRS += examples
 SUBDIRS += xentrace
 SUBDIRS += xcutils
+ifneq ($(XEN_TARGET_ARCH),ia64)
 SUBDIRS += firmware
+endif
 SUBDIRS += security
 SUBDIRS += console
 SUBDIRS += xenmon 

Instead of this, could you have a look at converting tools/Makefile to use the subdirs-$(foo) syntax that the xen/ Makefiles are using?

Good idea. I'll take a look.

Signature · 8 lines
Ciao,
al
----------------------------------------------------------------------
Al Stone                                      Alter Ego:
Open Source and Linux R&D                     Debian Developer
Hewlett-Packard Company                       http://www.debian.org
E-mail: [email protected]                        [email protected]
----------------------------------------------------------------------