libxc whitespace
PATCH 1/1 libxc whitespace
I noticed there is an prodigious amount of trailing whitespace in tools/libxc. This patch, a result of running
perl -p -i -e 's/\s+$/\n/g' tools/libxc/*.[ch]
removes it all. You could also run the perl yourself to produce the same effect.
There were also a few tabs that had snuck in. I left the headers alone, but fixed the instances in code.
As usual, the IA64 code contains some truly bizarre use of whitespace, but I resisted the temptation.
The resulting patch is ~140KB, so I've gzipped it. It introduces no functional changes, and has been compile-tested on x86_32. Please apply.
Signature · 6 lines
Hollis Blanchard IBM Linux Technology Center Fix whitespace in libxc. Signed-off-by: Hollis Blanchard <[email protected]>
_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel
Quoted 6 lines · Hollis Blanchard
I noticed there is an prodigious amount of trailing whitespace in
tools/libxc. This patch, a result of runningperl -p -i -e 's/\s+$/\n/g' tools/libxc/*.[ch]removes it all. You could also run the perl yourself to produce the same effect.
Quoted 8 lines
There were also a few tabs that had snuck in. I left the headers alone, but fixed the instances in code.
As usual, the IA64 code contains some truly bizarre use of whitespace, but I resisted the temptation.
The resulting patch is ~140KB, so I've gzipped it. It introduces no functional changes, and has been compile-tested on
x86_32. Please
apply.
Yes please!!!
Could we just run this on the entire Xen and tools trees?
Cheers,
Muli
Signature · 2 lines
Muli Ben-Yehuda http://www.mulix.org | http://mulix.livejournal.com/
Quoted 4 lines · Muli Ben-Yehuda
Quoted 2 lines
tools/libxc. This patch, a result of runningperl -p -i -e 's/\s+$/\n/g' tools/libxc/*.[ch]Could we just run this on the entire Xen and tools trees?
No, can't we wait and do this a file at a time when other changes are made? It is far from critical and it makes merging hell...
regards
john
Quoted 9 lines · John Levon
Quoted 4 lines · Muli Ben-Yehuda
Quoted 2 lines
tools/libxc. This patch, a result of runningperl -p -i -e 's/\s+$/\n/g' tools/libxc/*.[ch]Could we just run this on the entire Xen and tools trees?
No, can't we wait and do this a file at a time when other changes are made? It is far from critical and it makes merging hell...
I agree it makes merging hell, but hopefully, it will merging hell once and after that something automatic will enforce it at check-in time the same way akpm does for -mm, and all will be well with the world. The strategy you suggest almost always ends up with people making both changes at once, which makes *reviewing* hell.
Cheers,
Muli
Signature · 2 lines
Muli Ben-Yehuda http://www.mulix.org | http://mulix.livejournal.com/