Process Events - Header Cleanup and License Change
cover Process Events - Header Cleanup and License Change
Andrew,
This series of patches cleans up the Process Events header ininclude/linux/cn_proc.h in the first patch and then changes the license of cn_proc.h to LGPL in the second patch. As copyright holders to the work the header was derived from (mentioned at the top of the header) I think Guillaume Thouvenin and Nguyen Anh Quynh should sign-off or [n]ack the second patch before it can go in.
Please consider applying these to -mm.
Thanks,
-Matt Helsley <[email protected]>
Re: [PATCH 01/02] Process Events - Header Cleanup
Move connector header include to precisely where it's needed.
Remove unused time.h header file as well. This was leftover from previous iterations of the process events patches.
Compiles on x86. Tested on ppc64.
Please apply to -mm.
--
drivers/connector/cn_proc.c +1 -0
@@ -24,10 +24,11 @@#include <linux/module.h> #include <linux/kernel.h> #include <linux/ktime.h> #include <linux/init.h> +#include <linux/connector.h> #include <asm/atomic.h> #include <linux/cn_proc.h> #define CN_PROC_MSG_SIZE (sizeof(struct cn_msg) + sizeof(struct proc_event))
include/linux/cn_proc.h +0 -2
@@ -24,12 +24,10 @@#ifndef CN_PROC_H #define CN_PROC_H #include <linux/types.h> -#include <linux/time.h> -#include <linux/connector.h> /* * Userspace sends this enum to register with the kernel that it is listening * for events on the connector. */
Re: [PATCH 02/02] Process Events - License Change
In reply to Matt HelsleyChange the license on the process event structure passed between kernel and userspace.
--
include/linux/cn_proc.h +7 -14
@@ -1,27 +1,20 @@/* * cn_proc.h - process events connector * * Copyright (C) Matt Helsley, IBM Corp. 2005 * Based on cn_fork.h by Nguyen Anh Quynh and Guillaume Thouvenin -* Original copyright notice follows: * Copyright (C) 2005 Nguyen Anh Quynh <[email protected]> * Copyright (C) 2005 Guillaume Thouvenin <[email protected]> * -* This program is free software; you can redistribute it and/or modify -* it under the terms of the GNU General Public License as published by -* the Free Software Foundation; either version 2 of the License, or -* (at your option) any later version. -* -* This program is distributed in the hope that it will be useful, -* but WITHOUT ANY WARRANTY; without even the implied warranty of -* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -* GNU General Public License for more details. -* -* You should have received a copy of the GNU General Public License -* along with this program; if not, write to the Free Software -* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA +* This program is free software; you can redistribute it and/or modify it +* under the terms of version 2.1 of the GNU Lesser General Public License +* as published by the Free Software Foundation. +* +* This program is distributed in the hope that it would be useful, but +* WITHOUT ANY WARRANTY; without even the implied warranty of +* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. */ #ifndef CN_PROC_H #define CN_PROC_H
Nguyen Anh Quynh
Acked-byRe: [PATCH 02/02] Process Events - License Change
Hi,
I agree with the license change proposed by Matt Helsley.
Quoted 39 lines · Matt Helsley
Change the license on the process event structure passed between kernel and userspace.
Signed-off-by Matt Helsley <[email protected]>--
Index:
linux-2.6.17-rc2/include/linux/cn_proc.h
===================================================================include/linux/cn_proc.h +2
-14@@ -1,27 +1,20 @@/* * cn_proc.h - process events connector * * Copyright (C) Matt Helsley, IBM Corp. 2005 * Based on cn_fork.h by Nguyen Anh Quynh and Guillaume Thouvenin -* Original copyright notice follows: * Copyright (C) 2005 Nguyen Anh Quynh <[email protected]> * Copyright (C) 2005 Guillaume Thouvenin <[email protected]> * -* This program is free software; you can redistribute it and/or modify -* it under the terms of the GNU General Public License as published by -* the Free Software Foundation; either version 2 of the License, or -* (at your option) any later version. -* -* This program is distributed in the hope that it will be useful, -* but WITHOUT ANY WARRANTY; without even the implied warranty of -* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -* GNU General Public License for more details. -* -* You should have received a copy of the GNU General Public License -* along with this program; if not, write to the Free Software -* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA +* This program is free software; you can redistribute it and/or modify it +* under the terms of version 2.1 of the GNU Lesser General Public License
include/linux/cn_proc.h line 20
Quoted 10 lines
include/linux/cn_proc.h +5
-0+* as published by the Free Software Foundation. +* +* This program is distributed in the hope that it would be useful, but +* WITHOUT ANY WARRANTY; without even the implied warranty of +* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. */ #ifndef CN_PROC_H #define CN_PROC_H
--
Regards,
Quynh
Guillaume Thouvenin
Acked-byRe: [PATCH 02/02] Process Events - License Change
In reply to Matt HelsleyHello,
Changing the license is okay for me,
Cheers,
Quoted 48 lines · On Tue, 25 Apr 2006 02:12:30 -0700 Matt Helsley <[email protected]> wrote:
Change the license on the process event structure passed between kernel and userspace.
Signed-off-by Matt Helsley <[email protected]>--
Index:
linux-2.6.17-rc2/include/linux/cn_proc.h
===================================================================include/linux/cn_proc.h +7
-14@@ -1,27 +1,20 @@/* * cn_proc.h - process events connector * * Copyright (C) Matt Helsley, IBM Corp. 2005 * Based on cn_fork.h by Nguyen Anh Quynh and Guillaume Thouvenin -* Original copyright notice follows: * Copyright (C) 2005 Nguyen Anh Quynh <[email protected]> * Copyright (C) 2005 Guillaume Thouvenin <[email protected]> * -* This program is free software; you can redistribute it and/or modify -* it under the terms of the GNU General Public License as published by -* the Free Software Foundation; either version 2 of the License, or -* (at your option) any later version. -* -* This program is distributed in the hope that it will be useful, -* but WITHOUT ANY WARRANTY; without even the implied warranty of -* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -* GNU General Public License for more details. -* -* You should have received a copy of the GNU General Public License -* along with this program; if not, write to the Free Software -* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA +* This program is free software; you can redistribute it and/or modify it +* under the terms of version 2.1 of the GNU Lesser General Public License +* as published by the Free Software Foundation. +* +* This program is distributed in the hope that it would be useful, but +* WITHOUT ANY WARRANTY; without even the implied warranty of +* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. */ #ifndef CN_PROC_H #define CN_PROC_H