Skip to contentSkip to conversation

Remove useless SET_MODULE_OWNER calls.

AX25, ROSE Applied Ralf Baechle DL5RB 4 participants 5 messages Apr 29, 2006 – May 4, 2006

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Ralf Baechle DL5RB

author
#0 lore raw
Signed-off-by Ralf Baechle <[email protected]>

--

 net/netrom/nr_dev.c |    1 -
 net/rose/rose_dev.c |    1 -
 2 files changed, 2 deletions(-)
net/netrom/nr_dev.c +0 -1
Index: linux-net.git/net/netrom/nr_dev.c
===================================================================
@@ -185,7 +185,6 @@ static struct net_device_stats *nr_get_s
 
 void nr_setup(struct net_device *dev)
 {
-	SET_MODULE_OWNER(dev);
 	dev->mtu		= NR_MAX_PACKET_SIZE;
 	dev->hard_start_xmit	= nr_xmit;
 	dev->open		= nr_open;
net/rose/rose_dev.c +0 -1
Index: linux-net.git/net/rose/rose_dev.c
===================================================================
@@ -135,7 +135,6 @@ static struct net_device_stats *rose_get
 
 void rose_setup(struct net_device *dev)
 {
-	SET_MODULE_OWNER(dev);
 	dev->mtu		= ROSE_MAX_PACKET_SIZE - 2;
 	dev->hard_start_xmit	= rose_xmit;
 	dev->open		= rose_open;
#1 lore raw
Quoted 13 lines · On Sat, 2006-04-29 at 15:29 +0100, Ralf Baechle DL5RB wrote:
Signed-off-by Ralf Baechle <[email protected]>

--

 net/netrom/nr_dev.c |    1 -
 net/rose/rose_dev.c |    1 -
 2 files changed, 2 deletions(-)

Index: linux-net.git/net/netrom/nr_dev.c
===================================================================

net/netrom/nr_dev.c static struct net_device_stats *nr_get_s · line 190

Quoted 7 lines
net/netrom/nr_dev.c +0 -1
@@ -185,7 +185,6 @@ static struct net_device_stats *nr_get_s
 
 void nr_setup(struct net_device *dev)
 {
-	SET_MODULE_OWNER(dev);
 	dev->mtu		= NR_MAX_PACKET_SIZE;
 	dev->hard_start_xmit	= nr_xmit;
 	dev->open		= nr_open;

Are these done by anything else now? Did something change to make SET_MODULE_OWNER useless in individual drivers? I'm asking because I was fairly sure that SET_MODULE_OWNER set up some sysfs links and such that HAL depends on to figure out information about the driver and hardware device, much like SET_NETDEV_DEV.

Dan

#3 lore raw
Quoted 7 lines · Herbert Xu
Quoted 3 lines · Dan Williams

Are these done by anything else now? Did something change to make SET_MODULE_OWNER useless in individual drivers? I'm asking because I

SET_MODULE_OWNER has been a no-op ever since Dave made live network device driver modules unloadable nearly three years ago.

Ah, thanks for the clarification.

dan