Skip to contentSkip to conversation

ip_options_fragment() has no effect on fragmentation

PATCH Wei Yongjun 2 participants 2 messages May 8, 2006 – May 9, 2006

Subsystems (3)
Networking Network drivers IPv4/IPv6
lore
Share & tools
lore

Wei Yongjun

author
#0 lore raw

I had tested the patch under linux system, maybe this mail is correct.

Fix error point to options in ip_options_fragment(). optptr get a error pointer to the ipv4 header, correct is pointer to ipv4 options.

Signed-off-by Wei Yongjun <[email protected]>
net/ipv4/ip_options.c +1 -1
@@ -207,7 +207,7 @@
 
 void ip_options_fragment(struct sk_buff * skb) 
 {
-	unsigned char * optptr = skb->nh.raw;
+	unsigned char * optptr = skb->nh.raw + sizeof(struct iphdr);
 	struct ip_options * opt = &(IPCB(skb)->opt);
 	int  l = opt->optlen;
 	int  optlen;
Quoted 7 lines · David S. Miller

Actually it didn't get applied for some reason.

Please resubmit it properly with a full changelog and "Signed-off-by: " lines, and make double sure that your email client does not corrupt the patch so that I may apply it cleanly. Test this by sending it to yourself and trying to apply the patch.

maintainer
#1 lore raw

From: Wei Yongjun <[email protected]>
Date: Fri, 05 May 2006 20:36:14 -0400

Quoted 6 lines

I had tested the patch under linux system, maybe this mail is correct.

Fix error point to options in ip_options_fragment(). optptr get a error pointer to the ipv4 header, correct is pointer to ipv4 options.

Signed-off-by Wei Yongjun <[email protected]>

Patch applied, thank you very much.