media: dt-bindings: samsung,s5p-mfc: Fix iommu properties schemas
Subsystems (3)
Rob Herring
maintainerPATCH v2 1/1 media: dt-bindings: samsung,s5p-mfc: Fix iommu properties schemas
The iommus and iommu-names property schemas have several issues. First, 'iommus-names' in the if/then schemas is the wrong name. As all the names are the same, they can be defined at the top level instead. Then the if/then schemas just need to define how many entries. The iommus if/then schemas are also redundant. Best I can tell, the desire was to require 2 entries for "samsung,exynos5433-mfc", "samsung,mfc-v5", "samsung,mfc-v6", and "samsung,mfc-v8".
---
v2:
- Fix some more cases of iommus-names
--- .../bindings/media/samsung,s5p-mfc.yaml | 33 ++++++++----------- 1 file changed, 13 insertions(+), 20 deletions(-)
Documentation/devicetree/bindings/media/samsung,s5p-mfc.yaml +13 -20
@@ -49,7 +49,9 @@ properties: iommu-names: minItems: 1 - maxItems: 2 + items: + - const: left + - const: right power-domains: maxItems: 1
@@ -84,7 +86,7 @@ allOf: - const: sclk_mfc iommus: maxItems: 1 - iommus-names: false + iommu-names: false - if: properties:
@@ -102,11 +104,9 @@ allOf: - const: aclk - const: aclk_xiu iommus: - maxItems: 2 - iommus-names: - items: - - const: left - - const: right + minItems: 2 + iommu-names: + minItems: 2 - if: properties:
@@ -123,11 +123,9 @@ allOf: - const: mfc - const: sclk_mfc iommus: - maxItems: 2 - iommus-names: - items: - - const: left - - const: right + minItems: 2 + iommu-names: + minItems: 2 - if: properties:
@@ -144,11 +142,9 @@ allOf: items: - const: mfc iommus: - maxItems: 2 - iommus-names: - items: - - const: left - - const: right + minItems: 2 + iommu-names: + minItems: 2 - if: properties:
@@ -161,9 +157,6 @@ allOf: clocks: minItems: 1 maxItems: 2 - iommus: - minItems: 1 - maxItems: 2 examples: - |
Signature · 1 line
2.43.0
Quoted 14 lines
-----Original Message-----
From: Rob Herring <[email protected]>
Sent: 15 December 2023 01:26
To: Mauro Carvalho Chehab <[email protected]>; Krzysztof Kozlowski <[email protected]>; Conor Dooley <[email protected]>; Marek Szyprowski <[email protected]>; Aakarsh Jain <[email protected]>
Cc: [email protected]; [email protected]; linux- [email protected]
Subject: [PATCH v2] media: dt-bindings: samsung,s5p-mfc: Fix iommu properties schemas
Quoted 3 lines
The iommus and iommu-names property schemas have several issues. First, 'iommus-names' in the if/then schemas is the wrong name. As all the names are the same, they can be defined at the top level instead. Then the
if/then
Quoted 2 lines
schemas just need to define how many entries. The iommus if/then schemas are also redundant. Best I can tell, the desire was to require 2 entries
for
Quoted 93 lines
"samsung,exynos5433-mfc", "samsung,mfc-v5", "samsung,mfc-v6", and "samsung,mfc-v8".
Signed-off-by Rob Herring <[email protected]>---
v2:
- Fix some more cases of iommus-names--- .../bindings/media/samsung,s5p-mfc.yaml | 33 ++++++++----------- 1 file changed, 13 insertions(+), 20 deletions(-)(quoted diff) +0
-0
mfc.yamlb/Documentation/devicetree/bindings/media/samsung,s5p-mfc.yaml
index084b44582a43..4c3250985ac3100644Documentation/devicetree/bindings/media/samsung,s5p-mfc.yaml +13
-21@@ -49,7 +49,9 @@ properties: iommu-names: minItems: 1 - maxItems: 2 + items: + - const: left + - const: right power-domains: maxItems: 1@@ -84,7 +86,7 @@ allOf: - const: sclk_mfc iommus: maxItems: 1 - iommus-names: false + iommu-names: false - if: properties:@@ -102,11 +104,9 @@ allOf: - const: aclk - const: aclk_xiu iommus: - maxItems: 2 - iommus-names: - items: - - const: left - - const: right + minItems: 2 + iommu-names: + minItems: 2 - if: properties:@@ -123,11 +123,9 @@ allOf: - const: mfc - const: sclk_mfc iommus: - maxItems: 2 - iommus-names: - items: - - const: left - - const: right + minItems: 2 + iommu-names: + minItems: 2 - if: properties:@@ -144,11 +142,9 @@ allOf: items: - const: mfc iommus: - maxItems: 2 - iommus-names: - items: - - const: left - - const: right + minItems: 2 + iommu-names: + minItems: 2 - if: properties:@@ -161,9 +157,6 @@ allOf: clocks: minItems: 1 maxItems: 2 - iommus: - minItems: 1 - maxItems: 2 examples: - | --
Quoted 1 line
2.43.0
Quoted 10 lines · Rob Herring
The iommus and iommu-names property schemas have several issues. First, 'iommus-names' in the if/then schemas is the wrong name. As all the names are the same, they can be defined at the top level instead. Then the if/then schemas just need to define how many entries. The iommus if/then schemas are also redundant. Best I can tell, the desire was to require 2 entries for "samsung,exynos5433-mfc", "samsung,mfc-v5", "samsung,mfc-v6", and "samsung,mfc-v8".
Signed-off-by Rob Herring <[email protected]>---
Best regards,
Krzysztof
Quoted 8 lines · Rob Herring
The iommus and iommu-names property schemas have several issues. First, 'iommus-names' in the if/then schemas is the wrong name. As all the names are the same, they can be defined at the top level instead. Then the if/then schemas just need to define how many entries. The iommus if/then schemas are also redundant. Best I can tell, the desire was to require 2 entries for "samsung,exynos5433-mfc", "samsung,mfc-v5", "samsung,mfc-v6", and "samsung,mfc-v8".
Quoted 8 lines
Signed-off-by Rob Herring <[email protected]>---
v2:
- Fix some more cases of iommus-names--- .../bindings/media/samsung,s5p-mfc.yaml | 33 ++++++++----------- 1 file changed, 13 insertions(+), 20 deletions(-)
Applied, thanks!