__vmalloc with GFP_ATOMIC causes 'sleeping from invalid context'
Subsystems (2)
If __vmalloc is called in atomic context with GFP_ATOMIC flags, __get_vm_area_node is called, which calls kmalloc_node with GFP_KERNEL flags. This causes 'sleeping function called from invalid context at mm/slab.c:2729' with 2.6.16-rc4 kernel. A simple solution is to use proper flags in __get_vm_area_node, depending on the context:
mm/vmalloc.c +4 -1
@@ -177,7 +177,10 @@ addr =ALIGN (start, align); size =PAGE_ALIGN (size); - area =kmalloc_node (sizeof (*area),GFP_KERNEL , node); +if (in_atomic () ||in_interrupt ()) + area =kmalloc_node (sizeof (*area),GFP_ATOMIC , node); +else + area =kmalloc_node (sizeof (*area),GFP_KERNEL , node);if (unlikely (!area))return NULL ;
An alternate solution is to pass flags to __get_vm_area_node what was passed to __vmalloc so it can call kmalloc_node with either GFP_KERNEL or GFP_ATOMIC, but that changes signature of get_vm_area_node and __get_vm_area_node which may affect other parts of kernel / modules.
Another point: In include/linux/kernel.h, might_resched() is defined as
#ifdef CONFIG_PREEMPT_VOLUNTARY
extern int cond_resched(void);
# define might_resched() cond_resched()
#else
# define might_resched() do { } while (0)
#endifWhy is cond_resched() used only if CONFIG_PREEMPT_VOLUNTARY and not if CONFIG_PREEMPT is enabled? i.e., shouldn't it be defined as
#if defined(CONFIG_PREEMPT_VOLUNTARY) || defined(CONFIG_PREEMPT) extern int cond_resched(void);
# define might_resched() cond_resched()
#else
# define might_resched() do { } while (0)
#endifThanks,
Giri
Quoted 5 lines · Giridhar Pemmasani
If
__vmallocis called in atomic context withGFP_ATOMICflags,__get_vm_area_nodeis called, which callskmalloc_nodewithGFP_KERNELflags. This causes 'sleeping function called from invalid context atmm/slab.c:2729' with 2.6.16-rc4 kernel. A simple solution is to use proper flags in__get_vm_area_node, depending on the context:
vmalloc sleeps, or at least does things to the lower vm layers that really do sleepy things. So calling it from an atomic context really tends to be a bug....
where in the kernel is this done?
Quoted 9 lines · Arjan van de Ven
Quoted 6 lines · Giridhar Pemmasani
If
__vmallocis called in atomic context withGFP_ATOMICflags,__get_vm_area_nodeis called, which callskmalloc_nodewithGFP_KERNELflags. This causes 'sleeping function called from invalid context atmm/slab.c:2729' with 2.6.16-rc4 kernel. A simple solution is to use proper flags in__get_vm_area_node, depending on the context:
Quoted 5 lines
vmalloc sleeps, or at least does things to the lower vm layers that really do sleepy things. So calling it from an atomic context really tends to be a bug....
where in the kernel is this done?
It is not about vmalloc, but about __vmalloc. I gave more details in response to Nick Piggin's reply on this thread.
Thanks,
Giri
Quoted 4 lines · Giridhar Pemmasani
If
__vmallocis called in atomic context withGFP_ATOMICflags,__get_vm_area_nodeis called, which callskmalloc_nodewithGFP_KERNELflags. This causes 'sleeping function called from invalid context atmm/slab.c:2729' with 2.6.16-rc4 kernel. A simple solution is to use
I can't see what would cause this in either 2.6.16-rc4 or 2.6.17-rc4. What is the line?
Quoted 1 line
proper flags in
__get_vm_area_node, depending on the context:
I don't think that always works, you might pass in GFP_ATOMIC due to having hold of a spinlock, for example.
Also, vmlist_lock isn't interrupt safe, so it still kind of goes against the spirit of GFP_ATOMIC (which is to allow allocation from interrupt context).
Signature · 2 lines
SUSE Labs, Novell Inc. Send instant messages to your online friends http://au.messenger.yahoo.com
Quoted 9 lines · Nick Piggin
Quoted 5 lines · Giridhar Pemmasani
If
__vmallocis called in atomic context withGFP_ATOMICflags,__get_vm_area_nodeis called, which callskmalloc_nodewithGFP_KERNELflags. This causes 'sleeping function called from invalid context atmm/slab.c:2729' with 2.6.16-rc4 kernel. A simple solution is to useI can't see what would cause this in either 2.6.16-rc4 or 2.6.17-rc4. What is the line?
If someone calls __vmalloc in atomic context (with GFP_ATOMIC flags):
with 2.6.17-rc4, in file mm/vmalloc.c,
__vmalloc calls __vmalloc_node on line 484, __vmalloc_node calls get_vm_area_node on line 474, get_vm_area_node calls __get_vm_area_node on line 256, __get_vm_area_node calls kmalloc_node with GFP_KERNEL on line 180
and in include/linux/slab.h,
kmalloc_node calls kmalloc with GFP_KERNEL on line 164, kmalloc calls kmem_cache_alloc on line 106,
and in mm/slab.c,
kmem_cache_alloc calls __cache_alloc on line 3136, __cache_alloc calls cache_alloc_debugcheck_before on line 2880, cache_alloc_debugcheck_before calls might_sleep_if(GFP_KERNEL & GFP_WAIT) on line 2783
which causes the warning.
Signature · 1 line
Giri
Quoted 9 lines · Giridhar Pemmasani
Quoted 6 lines · Nick Piggin
Quoted 5 lines · Giridhar Pemmasani
If
__vmallocis called in atomic context withGFP_ATOMICflags,__get_vm_area_nodeis called, which callskmalloc_nodewithGFP_KERNELflags. This causes 'sleeping function called from invalid context atmm/slab.c:2729' with 2.6.16-rc4 kernel. A simple solution is to use
Quoted 4 lines
Quoted 2 lines
I can't see what would cause this in either 2.6.16-rc4 or 2.6.17-rc4. What is the line?
If someone calls
__vmallocin atomic context (withGFP_ATOMICflags):
OK I misunderstood your comment. I was looking for the caller. Hmm, page_alloc.c does, but I don't know that it needs to be atomic -- what happens if we just make that allocation GFP_KERNEL?
Signature · 2 lines
SUSE Labs, Novell Inc. Send instant messages to your online friends http://au.messenger.yahoo.com
Quoted 14 lines · Nick Piggin
Quoted 12 lines · Giridhar Pemmasani
Quoted 9 lines · Nick Piggin
Quoted 5 lines · Giridhar Pemmasani
If
__vmallocis called in atomic context withGFP_ATOMICflags,__get_vm_area_nodeis called, which callskmalloc_nodewithGFP_KERNELflags. This causes 'sleeping function called from invalid context atmm/slab.c:2729' with 2.6.16-rc4 kernel. A simple solution is to useI can't see what would cause this in either 2.6.16-rc4 or 2.6.17-rc4. What is the line?
Quoted 7 lines
Quoted 1 line
If someone calls
__vmallocin atomic context (withGFP_ATOMICflags):OK I misunderstood your comment. I was looking for the caller. Hmm,
page_alloc.cdoes, but I don't know that it needs to be atomic -- what happens if we just make that allocationGFP_KERNEL?
OTOH, it doesn't seem to be particularly wrong to allow __vmalloc GFP_ATOMIC allocations. The correct fix is to pass the gfp_mask to kmalloc: if you're worried about breaking the API, introduce a new __get_vm_area_node_mask() and implement __get_vm_area_node() as a simple wrapper that passes in GFP_KERNEL.
Thanks,
Nick
Signature · 2 lines
SUSE Labs, Novell Inc. Send instant messages to your online friends http://au.messenger.yahoo.com
Quoted 5 lines · Nick Piggin
OTOH, it doesn't seem to be particularly wrong to allow
__vmallocGFP_ATOMICallocations. The correct fix is to pass thegfp_maskto kmalloc: if you're worried about breaking the API, introduce a new__get_vm_area_node_mask()and implement__get_vm_area_node()as a simple wrapper that passes inGFP_KERNEL.
Oh, and __get_vm_area_node{_mask} should BUG_ON(in_interrupt());
Signature · 2 lines
SUSE Labs, Novell Inc. Send instant messages to your online friends http://au.messenger.yahoo.com
Quoted 9 lines · Nick Piggin
Quoted 5 lines · Nick Piggin
OTOH, it doesn't seem to be particularly wrong to allow
__vmallocGFP_ATOMICallocations. The correct fix is to pass thegfp_maskto kmalloc: if you're worried about breaking the API, introduce a new__get_vm_area_node_mask()and implement__get_vm_area_node()as a simple wrapper that passes inGFP_KERNEL.Oh, and __get_vm_area_node{_mask} should BUG_ON(in_interrupt());
With the patch I sent earlier, this may not be required: Since __get_vm_area_node calls kmalloc, it should be taken care of in kmalloc and friends. Currently cache_alloc_debugcheck_before doesn't check for in_interrupt(); perhaps that is the right place to add
if (flags & GFP_WAIT)
BUG_ON(in_interrupt());
Thanks,
Giri
Quoted 10 lines · Giridhar Pemmasani
Quoted 7 lines · Nick Piggin
Quoted 5 lines · Nick Piggin
OTOH, it doesn't seem to be particularly wrong to allow
__vmallocGFP_ATOMICallocations. The correct fix is to pass thegfp_maskto kmalloc: if you're worried about breaking the API, introduce a new__get_vm_area_node_mask()and implement__get_vm_area_node()as a simple wrapper that passes inGFP_KERNEL.
Quoted 6 lines
Quoted 1 line
Oh, and __get_vm_area_node{_mask} should BUG_ON(in_interrupt());
With the patch I sent earlier, this may not be required: Since
__get_vm_area_nodecalls kmalloc, it should be taken care of in kmalloc and friends. Currentlycache_alloc_debugcheck_beforedoesn't check forin_interrupt(); perhaps that is the right place to add
vmlist_lock is not irq safe. If you call it from interrupt, you can deadlock.
Signature · 2 lines
SUSE Labs, Novell Inc. Send instant messages to your online friends http://au.messenger.yahoo.com
Quoted 11 lines · Nick Piggin
Quoted 8 lines
Quoted 1 line
Oh, and __get_vm_area_node{_mask} should
BUG_ON(in_interrupt());
With the patch I sent earlier, this may not be required: Since
__get_vm_area_nodecalls kmalloc, it should be taken care of in kmalloc and friends. Currentlycache_alloc_debugcheck_beforedoesn't check forin_interrupt(); perhaps that is the right place to add
vmlist_lockis not irq safe. If you call it from interrupt, you can deadlock.
Aha. I will add BUG_ON(in_interrupt()) to __get_vm_area_node in the next round (if there is interest in the patch).
Thanks,
Giri
Quoted 26 lines · Nick Piggin
Quoted 15 lines · Nick Piggin
Quoted 13 lines · Giridhar Pemmasani
Quoted 1 line · Nick Piggin
Giridhar Pemmasani wrote: >> If
__vmallocis called in atomiccontext with
GFP_ATOMICflags, >>__get_vm_area_nodeis called, which callskmalloc_nodewith >>GFP_KERNELflags. This causes 'sleeping function called from >> invalid context atmm/slab.c:2729' with 2.6.16-rc4 kernel. A >> simple solution is to useQuoted 1 line
I can't see what would cause this in either 2.6.16-rc4 or >
2.6.17-rc4. What is the line?
Quoted 9 lines
Quoted 2 lines
If someone calls
__vmallocin atomic context (withGFP_ATOMICflags):OK I misunderstood your comment. I was looking for the caller. Hmm,
page_alloc.cdoes, but I don't know that it needs to be atomic -- what happens if we just make that allocationGFP_KERNEL?
Quoted 5 lines
OTOH, it doesn't seem to be particularly wrong to allow
__vmallocGFP_ATOMICallocations. The correct fix is to pass thegfp_maskto kmalloc: if you're worried about breaking the API, introduce a new__get_vm_area_node_mask()and implement__get_vm_area_node()as a simple wrapper that passes inGFP_KERNEL.
Here is an attempt at this. I also made __get_vm_area_node static.
include/linux/vmalloc.h +10 -2
@@ -3,6 +3,7 @@#include <linux/spinlock.h> #include <asm/page.h> /* pgprot_t */ +#include <linux/gfp.h> /* bits in vm_struct->flags */ #define VM_IOREMAP 0x00000001/* ioremap() and friends */
@@ -52,8 +53,15 @@extern struct vm_struct *get_vm_area (unsigned long size,unsigned long flags);extern struct vm_struct *__get_vm_area (unsigned long size,unsigned long flags,unsigned long start,unsigned long end); -extern struct vm_struct *get_vm_area_node (unsigned long size, -unsigned long flags,int node); +extern struct vm_struct *get_vm_area_node_mask (unsigned long size, +unsigned long flags,int node, +gfp_t gfp_mask); +static inline struct vm_struct *get_vm_area_node (unsigned long size, +unsigned long flags,int node) +{ +return get_vm_area_node_mask (size, flags, node,GFP_KERNEL ); +} +extern struct vm_struct *remove_vm_area (void *addr);extern struct vm_struct *__remove_vm_area (void *addr); extern int map_vm_area(struct vm_struct *area, pgprot_t prot,
mm/vmalloc.c +10 -7
@@ -157,8 +157,9 @@return err; } -struct vm_struct *__get_vm_area_node (unsigned long size,unsigned long flags, -unsigned long start,unsigned long end,int node) +static struct vm_struct *__get_vm_area_node (unsigned long size,unsigned long flags, +unsigned long start,unsigned long end, +int node,gfp_t gfp_mask) {struct vm_struct **p, *tmp, *area;unsigned long align =1 ;
@@ -177,7 +178,7 @@ addr =ALIGN (start, align); size =PAGE_ALIGN (size); - area =kmalloc_node (sizeof (*area),GFP_KERNEL , node); + area =kmalloc_node (sizeof (*area), gfp_mask, node);if (unlikely (!area))return NULL ;
@@ -233,7 +234,7 @@struct vm_struct *__get_vm_area (unsigned long size,unsigned long flags,unsigned long start,unsigned long end) { -return __get_vm_area_node (size, flags, start, end,-1 ); +return __get_vm_area_node (size, flags, start, end,-1 ,GFP_KERNEL ); }/**
@@ -251,9 +252,11 @@return __get_vm_area (size, flags,VMALLOC_START ,VMALLOC_END ); } -struct vm_struct *get_vm_area_node (unsigned long size,unsigned long flags,int node) +struct vm_struct *get_vm_area_node_mask (unsigned long size,unsigned long flags, +int node,gfp_t gfp_mask) { -return __get_vm_area_node (size, flags,VMALLOC_START ,VMALLOC_END , node); +return __get_vm_area_node (size, flags,VMALLOC_START ,VMALLOC_END , node, + gfp_mask); }/* Caller must hold vmlist_lock */
@@ -471,7 +474,7 @@if (!size || (size >>PAGE_SHIFT ) > num_physpages)return NULL ; - area =get_vm_area_node (size,VM_ALLOC , node); + area =get_vm_area_node_mask (size,VM_ALLOC , node, gfp_mask);if (!area)return NULL ;
Thanks,
Giri
Quoted 81 lines · Giridhar Pemmasani
diff -Naur
linux.orig/include/linux/vmalloc.hlinux/include/linux/vmalloc.h
---linux.orig/include/linux/vmalloc.h2006-05-22 02:45:23.000000000 -0400
+++linux/include/linux/vmalloc.h2006-05-22 02:45:38.000000000 -0400
@@ -3,6 +3,7 @@#include <
linux/spinlock.h>
#include <asm/page.h> /*pgprot_t*/
+#include <linux/gfp.h>/* bits in
vm_struct->flags*/
#defineVM_IOREMAP0x00000001/*ioremap()and friends */
@@ -52,8 +53,15 @@
extern structvm_struct*get_vm_area(unsigned long size, unsigned long flags); extern structvm_struct*__get_vm_area(unsigned long size, unsigned long flags,
unsigned long start, unsigned long end);
-extern structvm_struct*get_vm_area_node(unsigned long size,
- unsigned long flags, int node);
+extern structvm_struct*get_vm_area_node_mask(unsigned long size,
+ unsigned long flags, int node,
+gfp_tgfp_mask);
+static inline structvm_struct*get_vm_area_node(unsigned long size,
+ unsigned long flags, int node)
+{
+ returnget_vm_area_node_mask(size, flags, node, GFP_KERNEL);
+}
+
extern structvm_struct*remove_vm_area(void *addr);
extern structvm_struct*__remove_vm_area(void *addr);
extern int map_vm_area(structvm_struct*area,pgprot_tprot,
diff -Naurlinux.orig/mm/vmalloc.clinux/mm/vmalloc.c
---linux.orig/mm/vmalloc.c2006-05-19 01:22:00.000000000 -0400
+++linux/mm/vmalloc.c2006-05-22 02:45:49.000000000 -0400
@@ -157,8 +157,9 @@
return err;
}-struct
vm_struct*__get_vm_area_node(unsigned long size, unsigned long flags,
- unsigned long start, unsigned long end, int node)
+static structvm_struct*__get_vm_area_node(unsigned long size, unsigned long flags,
+ unsigned long start, unsigned long end,
+ int node,gfp_tgfp_mask)
{
structvm_struct**p, *tmp, *area;
unsigned long align = 1;
@@ -177,7 +178,7 @@
addr =ALIGN(start, align);
size =PAGE_ALIGN(size);- area =
kmalloc_node(sizeof(*area), GFP_KERNEL, node);
+ area =kmalloc_node(sizeof(*area), gfp_mask, node);
if (unlikely(!area))
return NULL;@@ -233,7 +234,7 @@
structvm_struct*__get_vm_area(unsigned long size, unsigned long flags,
unsigned long start, unsigned long end)
{
- return__get_vm_area_node(size, flags, start, end, -1);
+ return__get_vm_area_node(size, flags, start, end, -1, GFP_KERNEL);
}/**
@@ -251,9 +252,11 @@
return__get_vm_area(size, flags, VMALLOC_START, VMALLOC_END);
}-struct
vm_struct*get_vm_area_node(unsigned long size, unsigned long flags, int node) +structvm_struct*get_vm_area_node_mask(unsigned long size, unsigned long flags,
+ int node,gfp_tgfp_mask)
{
- return__get_vm_area_node(size, flags, VMALLOC_START, VMALLOC_END, node);
+ return __get_vm_area_node(size, flags,VMALLOC_START,VMALLOC_END, node,
+gfp_mask);
}/* Caller must hold
vmlist_lock*/
@@ -471,7 +474,7 @@
if (!size || (size >>PAGE_SHIFT) >num_physpages)
return NULL;
Quoted 5 lines
- area =
get_vm_area_node(size, VM_ALLOC, node);
+ area =get_vm_area_node_mask(size, VM_ALLOC, node, gfp_mask);
if (!area)
return NULL;
It was wrong for get_vm_area_node() to have assumed that it could use GFP_KERNEL.
Please just change the top-level API of get_vm_area_node() to take a gfp_t and don't worry about the get_vm_area_node_mask() thing.
The only callers of get_vm_area_node() are in vmalloc.c anyway. We could in fact make it static, but I guess exposing it as an API call makes sense.
Quoted 10 lines · Andrew Morton
It was wrong for
get_vm_area_node()to have assumed that it could useGFP_KERNEL.Please just change the top-level API of
get_vm_area_node()to take agfp_tand don't worry about theget_vm_area_node_mask()thing.The only callers of
get_vm_area_node()are invmalloc.canyway. We could in fact make it static, but I guess exposing it as an API call makes sense.
In addition, I added BUG_ON(in_interrupt()), as suggested by Nick Piggin earlier. The patch is against 2.6.17-rc4.
Thanks,
Giri
---
include/linux/vmalloc.h +2 -1
@@ -53,7 +53,8 @@extern struct vm_struct *__get_vm_area (unsigned long size,unsigned long flags,unsigned long start,unsigned long end);extern struct vm_struct *get_vm_area_node (unsigned long size, -unsigned long flags,int node); +unsigned long flags,int node, +gfp_t gfp_mask);extern struct vm_struct *remove_vm_area (void *addr);extern struct vm_struct *__remove_vm_area (void *addr); extern int map_vm_area(struct vm_struct *area, pgprot_t prot,
mm/vmalloc.c +11 -7
@@ -157,13 +157,15 @@return err; } -struct vm_struct *__get_vm_area_node (unsigned long size,unsigned long flags, -unsigned long start,unsigned long end,int node) +static struct vm_struct *__get_vm_area_node (unsigned long size,unsigned long flags, +unsigned long start,unsigned long end, +int node,gfp_t gfp_mask) {struct vm_struct **p, *tmp, *area;unsigned long align =1 ;unsigned long addr; +BUG_ON (in_interrupt ());if (flags &VM_IOREMAP ) {int bit =fls (size);
@@ -177,7 +179,7 @@ addr =ALIGN (start, align); size =PAGE_ALIGN (size); - area =kmalloc_node (sizeof (*area),GFP_KERNEL , node); + area =kmalloc_node (sizeof (*area), gfp_mask, node);if (unlikely (!area))return NULL ;
@@ -233,7 +235,7 @@struct vm_struct *__get_vm_area (unsigned long size,unsigned long flags,unsigned long start,unsigned long end) { -return __get_vm_area_node (size, flags, start, end,-1 ); +return __get_vm_area_node (size, flags, start, end,-1 ,GFP_KERNEL ); }/**
@@ -251,9 +253,11 @@return __get_vm_area (size, flags,VMALLOC_START ,VMALLOC_END ); } -struct vm_struct *get_vm_area_node (unsigned long size,unsigned long flags,int node) +struct vm_struct *get_vm_area_node (unsigned long size,unsigned long flags, +int node,gfp_t gfp_mask) { -return __get_vm_area_node (size, flags,VMALLOC_START ,VMALLOC_END , node); +return __get_vm_area_node (size, flags,VMALLOC_START ,VMALLOC_END , node, + gfp_mask); }/* Caller must hold vmlist_lock */
@@ -471,7 +475,7 @@if (!size || (size >>PAGE_SHIFT ) > num_physpages)return NULL ; - area =get_vm_area_node (size,VM_ALLOC , node); + area =get_vm_area_node (size,VM_ALLOC , node, gfp_mask);if (!area)return NULL ;
Quoted 9 lines · Nick Piggin
Quoted 4 lines · Giridhar Pemmasani
If
__vmallocis called in atomic context withGFP_ATOMICflags,__get_vm_area_nodeis called, which callskmalloc_nodewithGFP_KERNELflags. This causes 'sleeping function called from invalid context atmm/slab.c:2729' with 2.6.16-rc4 kernel. A simple solution is to useI can't see what would cause this in either 2.6.16-rc4 or 2.6.17-rc4. What is the line?
Quoted 8 lines
Quoted 1 line
proper flags in
__get_vm_area_node, depending on the context:I don't think that always works, you might pass in
GFP_ATOMICdue to having hold of a spinlock, for example.Also,
vmlist_lockisn't interrupt safe, so it still kind of goes against the spirit ofGFP_ATOMIC(which is to allow allocation from interrupt context).
That's not the only problem. Allocating page table entries or flushing TLBs from an atomic context is just not supported by the low level architecture code.
-Andi
Quoted 17 lines · Andi Kleen
Quoted 15 lines · Nick Piggin
Giridhar Pemmasani wrote: > If
__vmallocis called in atomic context withGFP_ATOMICflags, >__get_vm_area_nodeis called, which callskmalloc_nodewithGFP_KERNEL> flags. This causes 'sleeping function called from invalid context at >mm/slab.c:2729' with 2.6.16-rc4 kernel. A simple solution is to useI can't see what would cause this in either 2.6.16-rc4 or 2.6.17-rc4. What is the line?
Quoted 1 line
proper flags in
__get_vm_area_node, depending on the context:I don't think that always works, you might pass in
GFP_ATOMICdue to having hold of a spinlock, for example.
Quoted 7 lines
Quoted 3 lines
Also,
vmlist_lockisn't interrupt safe, so it still kind of goes against the spirit ofGFP_ATOMIC(which is to allow allocation from interrupt context).That's not the only problem. Allocating page table entries or flushing TLBs from an atomic context is just not supported by the low level architecture code.
I looked through __vmalloc implementation and the call tree. Nowhere do I see a problem with calling __vmalloc in atomic context (with GFP_ATOMIC flags, of course). Except for a few architectures (arm, m68k, sparc and xtensa), flusch_cache_all is a nop. I didn't look into all architectures, but at least for m68k, flush_cache_all seems to safe in atomic context. Please correct me if I am wrong.
To reiterate, __get_vm_area_node allocates space for 'struct vm_struct' with GFP_KERNEL irrespective of how its caller was called - if __vmalloc was called with GFP_ATOMIC, the node for that allocation should be allocated with the same flags. So the patch I suggested simply passes the flags from __vmalloc down to __get_vm_area_node.
If indeed it is not safe to call __vmalloc in atomic context (even with GFP_ATOMIC flags), perhaps we can add BUG_ON(in_atomic()) to __vmalloc?
Thanks,
Giri
Quoted 1 line · Giridhar Pemmasani
If
__vmallocis called in atomic context withGFP_ATOMICflags,
vmalloc is not safely callable in a non sleeping context. If you need a vmalloc buffer in an IRQ then pre-allocate it.
Alan