Skip to contentSkip to conversation

fbcon: Fix scrollback with logo issue immediately after boot

PATCH In review Jordan Crouse 3 participants 3 messages May 24, 2006 – May 25, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fbcon: Fix scrollback with logo issue immediately after boot

Greeting folks -

Sending on a patch against latest git that attempts to fix an issue with
the scrollback buffer in the fbcon immediately after boot. As always,
comments welcome.

Regards,
Jordan

PATCH: Fix scrollback with logo issue immediately after boot.

From: David Hollister <[email protected]>

After the system boots with the logo, if the first action is a scrollback, the screen may become garbled. This patch ensures that the softback_curr value is updated along with softback_in following the scrollback.

---

 drivers/video/console/fbcon.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/video/console/fbcon.c +1 -1
index ca02071..953eb8c 100644
@@ -2631,7 +2631,7 @@ static int fbcon_scrolldelta(struct vc_d
 					scr_memcpyw((u16 *) q, (u16 *) p,
 						    vc->vc_size_row);
 				}
-				softback_in = p;
+				softback_in = softback_curr = p;
 				update_region(vc, vc->vc_origin,
 					      logo_lines * vc->vc_cols);
 			}
#1 lore raw
Quoted 5 lines · Jordan Crouse

Greeting folks -

Sending on a patch against latest git that attempts to fix an issue with
the scrollback buffer in the fbcon immediately after boot. As always,
comments welcome.

Looks sane. Does this patch fix the problem mentioned here?

http://marc.theaimsgroup.com/?l=linux-kernel&m=114821885109864&w=2

Tony

-------------------------------------------------------
All the advantages of Linux Managed Hosting--Without the Cost and Risk! Fully trained technicians. The highest number of Red Hat certifications in the hosting industry. Fanatical Support. Click to learn more
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=107521&bid=248729&dat=121642

#2 lore raw

Hi Antonino,

That sounds exactly like what I was seeing. Oddly enough, as that post explains, the problem did not manifest at all resolutions. The short answer is yes, I believe this patch will fix the issue referenced below.

David

Quoted 7 lines · Antonino A. Daplas
Quoted 5 lines · Jordan Crouse

Greeting folks -

Sending on a patch against latest git that attempts to fix an issue with
the scrollback buffer in the fbcon immediately after boot. As always,
comments welcome.

Quoted 8 lines

Looks sane. Does this patch fix the problem mentioned here?

http://marc.theaimsgroup.com/?l=linux-kernel&m=114821885109864&w=2

Tony

-------------------------------------------------------
All the advantages of Linux Managed Hosting--Without the Cost and Risk! Fully trained technicians. The highest number of Red Hat certifications in the hosting industry. Fanatical Support. Click to learn more
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=107521&bid=248729&dat=121642