Problems with fh_fsid_type=3 exports (device minor id > 255)
Subsystems (2)
I having a problem with the 2.6.9 kernel and mounting file systems with a minor device id > 255 where the mount fails. It seems like the file handle is never cached. We are able to proceed if fsid is specified in /etc/exports. nfs-utils version is 1.0.6.
Have others seen this problem and is there a fix in a later kernel?
I've been trying to follow the fh_compose and fh_verify code to understand this, but I don't see where there's a difference between type 3 file handles and type 1 file handles (fsid specified in /etc/exports) that could cause a problem. When I add a little bit of debug messages, I see that expkey_parse is being called as a result of a system call for the type 1 handles, but not for the type 3 handles.
Thanks
Frank Filz
-------------------------------------------------------
All the advantages of Linux Managed Hosting--Without the Cost and Risk! Fully trained technicians. The highest number of Red Hat certifications in the hosting industry. Fanatical Support. Click to learn more
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=107521&bid=248729&dat=121642
_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs
Quoted 5 lines · Frank Filz
I having a problem with the 2.6.9 kernel and mounting file systems with a minor device id > 255 where the mount fails. It seems like the file handle is never cached. We are able to proceed if fsid is specified in
/etc/exports. nfs-utils version is 1.0.6.
Quoted 8 lines
Have others seen this problem and is there a fix in a later kernel?
I've been trying to follow the
fh_composeandfh_verifycode to understand this, but I don't see where there's a difference between type 3 file handles and type 1 file handles (fsid specified in/etc/exports) that could cause a problem. When I add a little bit of debug messages, I see thatexpkey_parseis being called as a result of a system call for the type 1 handles, but not for the type 3 handles.
I've trudged my way through the code, and I think I've found the problem. The problem seems to be the way the kernel and nfs-utils expect the fsid to be coded. The kernel uses this code to encode:
unsigned major = MAJOR(dev); unsigned minor = MINOR(dev); return (minor & 0xff) | (major << 8) | ((minor & ~0xff) << 12);
The user space uses this code to decode:
memcpy(&dev, fsid, 4); memcpy(&inode, fsid+4, 4); major = (dev & 0xfff00) >> 8; minor = (dev & 0xff) | ((dev >> 12) & 0xfff00);
I think when the entry is exported into the kernel, the fsid is also going to be wrong.
The question I have is should I fix this in the kernel or in nfs-utils?
Thanks
Frank Filz
-------------------------------------------------------
All the advantages of Linux Managed Hosting--Without the Cost and Risk! Fully trained technicians. The highest number of Red Hat certifications in the hosting industry. Fanatical Support. Click to learn more
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=107521&bid=248729&dat=121642
_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs
Quoted 23 lines · Frank Filz
Quoted 5 lines · Frank Filz
I having a problem with the 2.6.9 kernel and mounting file systems with a minor device id > 255 where the mount fails. It seems like the file handle is never cached. We are able to proceed if fsid is specified in
/etc/exports. nfs-utils version is 1.0.6.Quoted 8 lines
Have others seen this problem and is there a fix in a later kernel?
I've been trying to follow the
fh_composeandfh_verifycode to understand this, but I don't see where there's a difference between type 3 file handles and type 1 file handles (fsid specified in/etc/exports) that could cause a problem. When I add a little bit of debug messages, I see thatexpkey_parseis being called as a result of a system call for the type 1 handles, but not for the type 3 handles.I've trudged my way through the code, and I think I've found the problem. The problem seems to be the way the kernel and nfs-utils expect the fsid to be coded. The kernel uses this code to encode:
unsigned major = MAJOR(dev); unsigned minor = MINOR(dev); return (minor & 0xff) | (major << 8) | ((minor & ~0xff) << 12);
Quoted 6 lines
The user space uses this code to decode:
memcpy(&dev, fsid, 4); memcpy(&inode, fsid+4, 4); major = (dev & 0xfff00) >> 8; minor = (dev & 0xff) | ((dev >> 12) & 0xfff00);
Oops, I'm horribly confused... The above code actually is right, well mostly, I think it actually should be:
Quoted 2 lines
major = (dev & 0xff00) >> 8; minor = (dev & 0xff) | ((dev >> 12) & 0xfff00);
The bug I'm chasing is because the install is using nfs-utils 1.0.6 which does not handle type 3 file handles at all.
Frank
-------------------------------------------------------
All the advantages of Linux Managed Hosting--Without the Cost and Risk! Fully trained technicians. The highest number of Red Hat certifications in the hosting industry. Fanatical Support. Click to learn more
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=107521&bid=248729&dat=121642
_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs
Quoted 2 lines · On Wednesday May 31, [email protected] wrote:
Oops, I'm horribly confused... The above code actually is right, well
:-) I'm glad you got your problem sorted!
Quoted 5 lines
mostly, I think it actually should be:
Quoted 2 lines
major = (dev & 0xff00) >> 8; minor = (dev & 0xff) | ((dev >> 12) & 0xfff00);
No, major is 12 bits, minor is 20 bits. So the original code is correct.
NeilBrown
Quoted 8 lines
The bug I'm chasing is because the install is using nfs-utils 1.0.6 which does not handle type 3 file handles at all.
Frank
Quoted 8 lines
-------------------------------------------------------
All the advantages of Linux Managed Hosting--Without the Cost and Risk! Fully trained technicians. The highest number of Red Hat certifications in the hosting industry. Fanatical Support. Click to learn more
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=107521&bid=248729&dat=121642
_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs
-------------------------------------------------------
All the advantages of Linux Managed Hosting--Without the Cost and Risk! Fully trained technicians. The highest number of Red Hat certifications in the hosting industry. Fanatical Support. Click to learn more
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=107521&bid=248729&dat=121642
_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs
Quoted 6 lines · Neil Brown
Quoted 2 lines · On Wednesday May 31, [email protected] wrote:
Oops, I'm horribly confused... The above code actually is right, well
:-) I'm glad you got your problem sorted!
Quoted 8 lines
Quoted 5 lines
mostly, I think it actually should be:
Quoted 2 lines
major = (dev & 0xff00) >> 8; minor = (dev & 0xff) | ((dev >> 12) & 0xfff00);No, major is 12 bits, minor is 20 bits. So the original code is correct.
With a bit more sleep, I see that now. Thanks.
What version of nfs-utils did this show up in? It looks like the situation is just a mis-match of nfs-utils and kernel.
Thanks
Frank Filz
-------------------------------------------------------
All the advantages of Linux Managed Hosting--Without the Cost and Risk! Fully trained technicians. The highest number of Red Hat certifications in the hosting industry. Fanatical Support. Click to learn more
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=107521&bid=248729&dat=121642
_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs
PATCH 1/1 expkey_parse doesn't handle type 3 exports (was Re: [NFS] Problems with fh_fsid_type=3 exports (device minor id > 255))
Quoted 13 lines · Frank Filz
Quoted 12 lines · Neil Brown
Quoted 2 lines · On Wednesday May 31, [email protected] wrote:
Oops, I'm horribly confused... The above code actually is right, well
:-) I'm glad you got your problem sorted!
Quoted 5 lines
mostly, I think it actually should be:
Quoted 2 lines
major = (dev & 0xff00) >> 8; minor = (dev & 0xff) | ((dev >> 12) & 0xfff00);
Quoted 7 lines
Quoted 2 lines
No, major is 12 bits, minor is 20 bits. So the original code is correct.
With a bit more sleep, I see that now. Thanks.
What version of nfs-utils did this show up in? It looks like the situation is just a mis-match of nfs-utils and kernel.
I tried the 1.0.8 version of rpc.mountd, and things almost worked, but the mount still failed. I looked at expkey_parse, and discovered it doesn't handle type 3 exports. The following patch fixes the problem:
fs/nfsd/export.c +1 -1
@@ -132,7 +132,7 @@ static int expkey_parse(struct cache_detif (*ep) goto out;dprintk ("found fsidtype %d\n" , fsidtype); -if (fsidtype >2 ) +if (fsidtype >3 ) goto out;if ((len=qword_get (&mesg, buf,PAGE_SIZE )) <=0 ) goto out;
-------------------------------------------------------
All the advantages of Linux Managed Hosting--Without the Cost and Risk! Fully trained technicians. The highest number of Red Hat certifications in the hosting industry. Fanatical Support. Click to learn more
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=107521&bid=248729&dat=121642
_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs
Re: [PATCH] expkey_parse doesn't handle type 3 exports (was Re: Problems with fh_fsid_type=3 exports (device minor id > 255))
Quoted 12 lines · On Thursday June 1, [email protected] wrote:
I tried the 1.0.8 version of rpc.mountd, and things almost worked, but the mount still failed. I looked at
expkey_parse, and discovered it doesn't handle type 3 exports. The following patch fixes the problem:Signed-off-by Frank Filz <[email protected]>
fs/nfsd/export.c static int expkey_parse(struct cache_det · line 138
Quoted 8 lines
fs/nfsd/export.c +1
-1@@ -132,7 +132,7 @@ static int expkey_parse(struct cache_detif (*ep) goto out;dprintk ("found fsidtype %d\n" , fsidtype); -if (fsidtype >2 ) +if (fsidtype >3 ) goto out;if ((len=qword_get (&mesg, buf,PAGE_SIZE )) <=0 ) goto out;
Thanks!
I'll make it
if (key_len(fsidtype)==0)
to reduce the chance of the same mistake happening again.
NeilBrown
_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs