Add support for Yamaha AICA sound on SEGA Dreamcast
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 5 lines · Adrian McMenamin
This adds sound for the Yamaha AICA "Super Intelligent Sound Processor" (PCM) device on the SEGA Dreamcast
Signed off by Adrian McMenamin <[email protected]>
I've had no comments back on this - I am thinking of committing to the linux-sh cvs, though it really belongs in ALSA.
Any reason why I shouldn't?
Quoted 5 lines · Adrian McMenamin
This adds sound for the Yamaha AICA "Super Intelligent Sound Processor" (PCM) device on the SEGA Dreamcast
Signed off by Adrian McMenamin <[email protected]>
I've had no comments back on this - I am thinking of committing to the linux-sh cvs, though it really belongs in ALSA.
Any reason why I shouldn't?
Quoted 11 lines · Adrian McMenamin
Quoted 5 lines · Adrian McMenamin
This adds sound for the Yamaha AICA "Super Intelligent Sound Processor" (PCM) device on the SEGA Dreamcast
Signed off by Adrian McMenamin <[email protected]>
I've had no comments back on this - I am thinking of committing to the linux-sh cvs, though it really belongs in ALSA.
Any reason why I shouldn't?
Did you fix all of the issues that were raised by Paul and Takashi-san?
Lee
Quoted 10 lines · Lee Revell
Quoted 9 lines · Adrian McMenamin
Quoted 5 lines · Adrian McMenamin
This adds sound for the Yamaha AICA "Super Intelligent Sound Processor" (PCM) device on the SEGA Dreamcast
Signed off by Adrian McMenamin <[email protected]>
I've had no comments back on this - I am thinking of committing to the linux-sh cvs, though it really belongs in ALSA.
Quoted 6 lines
Quoted 2 lines
Any reason why I shouldn't?
Did you fix all of the issues that were raised by Paul and Takashi-san?
Lee
Those ones that were fixable, yes. At least I think so :)
Quoted 10 lines · Lee Revell
Quoted 9 lines · Adrian McMenamin
Quoted 5 lines · Adrian McMenamin
This adds sound for the Yamaha AICA "Super Intelligent Sound Processor" (PCM) device on the SEGA Dreamcast
Signed off by Adrian McMenamin <[email protected]>
I've had no comments back on this - I am thinking of committing to the linux-sh cvs, though it really belongs in ALSA.
Quoted 6 lines
Quoted 2 lines
Any reason why I shouldn't?
Did you fix all of the issues that were raised by Paul and Takashi-san?
Lee
Those ones that were fixable, yes. At least I think so :)
At Sat, 03 Jun 2006 12:39:48 +0100,
Quoted 9 lines · Adrian McMenamin
Quoted 5 lines · Adrian McMenamin
This adds sound for the Yamaha AICA "Super Intelligent Sound Processor" (PCM) device on the SEGA Dreamcast
Signed off by Adrian McMenamin <[email protected]>
I've had no comments back on this - I am thinking of committing to the linux-sh cvs, though it really belongs in ALSA.
Sorry for the delay. I've had a long weekend.
Quoted 1 line
Any reason why I shouldn't?
As Paul already pointed, the platform_device things must be fixed. Also, better to clean up the code directly accessing hardcoded addresses.
Another big concern is that spu_dma_work is initialized/rewritten dynamically in spu_begin_dma() and aica_period_elapsed() via INIT_WORK() and PREPARE_WOR(). This looks pretty strange and may be racy.
Takashi
At Sat, 03 Jun 2006 12:39:48 +0100,
Quoted 9 lines · Adrian McMenamin
Quoted 5 lines · Adrian McMenamin
This adds sound for the Yamaha AICA "Super Intelligent Sound Processor" (PCM) device on the SEGA Dreamcast
Signed off by Adrian McMenamin <[email protected]>
I've had no comments back on this - I am thinking of committing to the linux-sh cvs, though it really belongs in ALSA.
Sorry for the delay. I've had a long weekend.
Quoted 1 line
Any reason why I shouldn't?
As Paul already pointed, the platform_device things must be fixed. Also, better to clean up the code directly accessing hardcoded addresses.
Another big concern is that spu_dma_work is initialized/rewritten dynamically in spu_begin_dma() and aica_period_elapsed() via INIT_WORK() and PREPARE_WOR(). This looks pretty strange and may be racy.
Takashi
Quoted 4 lines · Takashi Iwai
As Paul already pointed, the
platform_devicethings must be fixed. Also, better to clean up the code directly accessing hardcoded addresses.
Working on that, some new code in my personal CVS now - but I suspect it will be the weekend before that gets fully fixed.
Quoted 5 lines
Another big concern is that
spu_dma_workis initialized/rewritten dynamically inspu_begin_dma()andaica_period_elapsed()viaINIT_WORK()andPREPARE_WOR(). This looks pretty strange and may be racy.
Actually, the two macros INIT_WORK and PREPARE_WORK use the same work queue but ask it to schedule the execution of two different (if very similar) functions start_spu_dma() - which does the initial transfer and more_spu_dma - which tops up the dma transfers.
So I think I've got that right.
At Wed, 07 Jun 2006 00:10:48 +0100,
Quoted 8 lines · Adrian McMenamin
Quoted 4 lines · Takashi Iwai
Another big concern is that
spu_dma_workis initialized/rewritten dynamically inspu_begin_dma()andaica_period_elapsed()viaINIT_WORK()andPREPARE_WOR(). This looks pretty strange and may be racy.
Quoted 6 lines
Actually, the two macros
INIT_WORKandPREPARE_WORKuse the same work queue but ask it to schedule the execution of two different (if very similar) functionsstart_spu_dma()- which does the initial transfer andmore_spu_dma- which tops up the dma transfers.So I think I've got that right.
What's wrong with using two individual work struct so that you initialize them only once?
I wonder it because you already have unused fields work and work2...
Takashi
Quoted 15 lines · Takashi Iwai
At Wed, 07 Jun 2006 00:10:48 +0100,
Quoted 13 lines · Adrian McMenamin
Quoted 4 lines · Takashi Iwai
Another big concern is that
spu_dma_workis initialized/rewritten dynamically inspu_begin_dma()andaica_period_elapsed()viaINIT_WORK()andPREPARE_WOR(). This looks pretty strange and may be racy.Actually, the two macros
INIT_WORKandPREPARE_WORKuse the same work queue but ask it to schedule the execution of two different (if very similar) functionsstart_spu_dma()- which does the initial transfer andmore_spu_dma- which tops up the dma transfers.
Quoted 6 lines
Quoted 1 line
So I think I've got that right.
What's wrong with using two individual work struct so that you initialize them only once?
I wonder it because you already have unused fields work and work2...
They've gone actually.
I need to initialise them because every call is a discrete processing job - ie I send one thing to go, then when a period has elapsed I schedule another transfer to run on the kernel thread.
Isn't this the way it is meant to work?
Quoted 15 lines · Takashi Iwai
At Wed, 07 Jun 2006 00:10:48 +0100,
Quoted 13 lines · Adrian McMenamin
Quoted 4 lines · Takashi Iwai
Another big concern is that
spu_dma_workis initialized/rewritten dynamically inspu_begin_dma()andaica_period_elapsed()viaINIT_WORK()andPREPARE_WOR(). This looks pretty strange and may be racy.Actually, the two macros
INIT_WORKandPREPARE_WORKuse the same work queue but ask it to schedule the execution of two different (if very similar) functionsstart_spu_dma()- which does the initial transfer andmore_spu_dma- which tops up the dma transfers.
Quoted 6 lines
Quoted 1 line
So I think I've got that right.
What's wrong with using two individual work struct so that you initialize them only once?
I wonder it because you already have unused fields work and work2...
They've gone actually.
I need to initialise them because every call is a discrete processing job - ie I send one thing to go, then when a period has elapsed I schedule another transfer to run on the kernel thread.
Isn't this the way it is meant to work?
At Wed, 07 Jun 2006 19:16:42 +0100,
Quoted 23 lines · Adrian McMenamin
Quoted 15 lines · Takashi Iwai
At Wed, 07 Jun 2006 00:10:48 +0100,
Quoted 13 lines · Adrian McMenamin
Quoted 4 lines · Takashi Iwai
Another big concern is that
spu_dma_workis initialized/rewritten dynamically inspu_begin_dma()andaica_period_elapsed()viaINIT_WORK()andPREPARE_WOR(). This looks pretty strange and may be racy.Actually, the two macros
INIT_WORKandPREPARE_WORKuse the same work queue but ask it to schedule the execution of two different (if very similar) functionsstart_spu_dma()- which does the initial transfer andmore_spu_dma- which tops up the dma transfers.Quoted 6 lines
Quoted 1 line
So I think I've got that right.
What's wrong with using two individual work struct so that you initialize them only once?
I wonder it because you already have unused fields work and work2...
Quoted 7 lines
They've gone actually.
I need to initialise them because every call is a discrete processing job - ie I send one thing to go, then when a period has elapsed I schedule another transfer to run on the kernel thread.
Isn't this the way it is meant to work?
It's uncoventional that a work struct is re-initialized on the fly.
IMO, it's better to introduce a flag indicating the stream is already running and use a single function/work struct. For example,
static void do_first_event(struct stream *str)
{
...
str->running = 1;
}
static void do_more_event(struct stream *str)
{
...
}
static void work_event(void *data)
{
struct stream *str = data;
if (str->running)
do_more_event(str);
else
do_first_event(str);
}
trigger_start()
{
queue_work(queue, &this_work);
}
interrupt_handler()
{
...
queue_work(queue, &this_work);
...
}
initialization()
{
...
queue = create_workqueue("xxx");
INIT_WORK(&this_work, work_event, str);
...
} Quoted 5 lines · Takashi Iwai
It's uncoventional that a work struct is re-initialized on the fly.
IMO, it's better to introduce a flag indicating the stream is already running and use a single function/work struct. For example,
Yes, I've did this sort of thing last night :)
At Wed, 07 Jun 2006 00:10:48 +0100,
Quoted 8 lines · Adrian McMenamin
Quoted 4 lines · Takashi Iwai
Another big concern is that
spu_dma_workis initialized/rewritten dynamically inspu_begin_dma()andaica_period_elapsed()viaINIT_WORK()andPREPARE_WOR(). This looks pretty strange and may be racy.
Quoted 6 lines
Actually, the two macros
INIT_WORKandPREPARE_WORKuse the same work queue but ask it to schedule the execution of two different (if very similar) functionsstart_spu_dma()- which does the initial transfer andmore_spu_dma- which tops up the dma transfers.So I think I've got that right.
What's wrong with using two individual work struct so that you initialize them only once?
I wonder it because you already have unused fields work and work2...
Takashi
Quoted 21 lines · Adrian McMenamin
obj-y += last.odiff -ruN
a/linux-2.6.16.14/sound/sh/aica.cb/linux-2.6.16.14/sound/sh/aica.clinux-2.6.16.14/sound/sh/aica.c +16
-0@@ -0,0 +1,692 @@ +/* +* This code is licenced under +* the General Public Licence +* version 2 +* +* Copyright Adrian McMenamin 2005, 2006 +* <[email protected]> +* See also http://newgolddream.dyndns.info/cgi-bin/cvsweb +* +* +* This program is free software; you can redistribute it and/or modify +* it under the terms of version 2 of the GNU General Public License as published by +* the Free Software Foundation. +* +* This program is distributed in the hope that it will be useful, +* but WITHOUT ANY WARRANTY; without even the implied warranty of
linux-2.6.16.14/sound/sh/aica.c line 26
Quoted 10 lines
linux-2.6.16.14/sound/sh/aica.c +10
-0+* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +* GNU General Public License for more details. +* +* You should have received a copy of the GNU General Public License +* along with this program; if not, write to the Free Software +* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA +* +*/ + +
Superfluous whitespace still..
Quoted 7 lines
linux-2.6.16.14/sound/sh/aica.c +7
-0+/* Simple platform device */ +static struct platform_device *pd; +static struct resource aica_memory_space[2 ] = { + { + .name ="AICA ARM CONTROL" , + .start =ARM_RESET_REGISTER , + .flags =IORESOURCE_MEM ,
linux-2.6.16.14/sound/sh/aica.c line 43
Quoted 10 lines
linux-2.6.16.14/sound/sh/aica.c +10
-0+ .end = ARM_RESET_REGISTER + 3, + }, + { + .name = "AICA Sound RAM", + .start = SPU_MEMORY_BASE, + .flags = IORESOURCE_MEM, + .end = SPU_MEMORY_BASE + 0x200000 - 1, + }, +}; +
This is still a bit broken. These resources should be part of the platform device defined by the board-specific dreamcast code (see for example what things like microdev do for smc91x for an example), incase there are other AICA users in the future.
Quoted 20 lines
linux-2.6.16.14/sound/sh/aica.c +20
-0+/* SPU specific functions */ +/* spu_write_wait - wait for G2-SH FIFO to clear */ +static inline void spu_write_wait (void ) +{ +int time_count; + time_count =0 ; +while (1 ) { +if (!(readl (G2_FIFO ) &0x11 )) +break ; +/* To ensure hardware failure doesn't wedge kernel */ + time_count++; +if (time_count >0x10000 ) +break ; + } +} + +/* spu_memset - write to memory in SPU address space */ +static void spu_memset (uint32_t toi,uint32_t what,int length) +{ +int i;
linux-2.6.16.14/sound/sh/aica.c line 73
Quoted 10 lines
linux-2.6.16.14/sound/sh/aica.c +10
-0+snd_assert (length %4 ==0 , return); +spu_write_wait (); +for (i =0 ; i < length; i++) { +writel (what, toi +SPU_MEMORY_BASE ); + toi++; +if (i && !(i %8 )) +spu_write_wait (); + } +} +
You should not have the memory base hardcoded as you can already fetch it from the memory resource. You should have an IORESOURCE_IO for the control registers, and an IORESOURCE_MEM for the SPU RAM, then fetch those from the platform device resources accordingly so that these remain configurable from the board-specific code.
linux-2.6.16.14/sound/sh/aica.c line 79
Quoted 6 lines
linux-2.6.16.14/sound/sh/aica.c +6
-0+/* spu_memload - write to SPU address space */ +static void spu_memload (uint32_t toi,void __iomem * from,int length) +{ +uint32_t __iomem *froml = from; +uint32_t __iomem *to = + (uint32_t __iomem *) (SPU_MEMORY_BASE + toi);
Same here. Again, you really want your own spu_readl()/spu_writel() that hides this for you.
linux-2.6.16.14/sound/sh/aica.c line 89
Quoted 10 lines
linux-2.6.16.14/sound/sh/aica.c +10
-0+/* spu_disable - set spu registers to stop sound output */ +static void spu_disable (void ) +{ +int i; +uint32_t regval; +spu_write_wait (); + regval =readl (ARM_RESET_REGISTER ); + regval |=1 ; +spu_write_wait (); +writel (regval,ARM_RESET_REGISTER );
Same thing here..
linux-2.6.16.14/sound/sh/aica.c line 96
Quoted 7 lines
linux-2.6.16.14/sound/sh/aica.c +7
-0+for (i =0 ; i <64 ; i++) { +spu_write_wait (); + regval =readl (SPU_REGISTER_BASE + (i *0x80 )); + regval = (regval & ~0x4000 ) |0x8000 ; +spu_write_wait (); +writel (regval,SPU_REGISTER_BASE + (i *0x80 )); + }
And here..
linux-2.6.16.14/sound/sh/aica.c line 101
Quoted 5 lines
linux-2.6.16.14/sound/sh/aica.c +5
-0+/* Halt the sound processor, +clear the memory, +load some default ARM7 code, +and then restart ARM7 +*/
Please use more conventional commenting styles, as opposed to inventing your own.
linux-2.6.16.14/sound/sh/aica.c line 102
Quoted 1 line
linux-2.6.16.14/sound/sh/aica.c +1
-0+static void spu_init (void )
This can probably be inlined..
Quoted 6 lines
linux-2.6.16.14/sound/sh/aica.c +6
-0+/* aica_chn_start - write to spu to start playback */ +static void aica_chn_start (void ) +{ +spu_write_wait (); +writel (AICA_CMD_KICK |AICA_CMD_START , + (uint32_t *)AICA_CONTROL_POINT );
linux-2.6.16.14/sound/sh/aica.c line 118
Quoted 10 lines
linux-2.6.16.14/sound/sh/aica.c +10
-0+} + +/* aica_chn_halt - write to spu to halt playback */ +static void aica_chn_halt (void ) +{ +spu_write_wait (); +writel (AICA_CMD_KICK |AICA_CMD_STOP , + (uint32_t *)AICA_CONTROL_POINT ); +} +
These too.
linux-2.6.16.14/sound/sh/aica.c line 127
Quoted 9 lines
linux-2.6.16.14/sound/sh/aica.c +9
-0+static void startup_aica (struct snd_card_aica *dreamcastcard) +{ +spu_memload (AICA_CHANNEL0_CONTROL_OFFSET , + (uint8_t *) dreamcastcard->channel, +sizeof (struct aica_channel )); +aica_chn_start (); +return ; +} +
Pointless return.
linux-2.6.16.14/sound/sh/aica.c line 138
Quoted 11 lines
linux-2.6.16.14/sound/sh/aica.c +11
-0+/* TO DO: set up to handle more than one pcm instance */ +static int __init snd_aicapcmchip (struct snd_card_aica + *dreamcastcard,int pcm_index) +{ +struct snd_pcm *pcm; +int err; +/* AICA has no capture ability */ +if ((err = +snd_pcm_new (dreamcastcard->card,"AICA PCM" , pcm_index,1 ,0 , + &pcm)) <0 ) +return err;
Again, move the assignment out of the if context.
linux-2.6.16.14/sound/sh/aica.c line 150
Quoted 12 lines
linux-2.6.16.14/sound/sh/aica.c +12
-0+static int aica_pcmvolume_put (struct snd_kcontrol *kcontrol, +struct snd_ctl_elem_value *ucontrol) +{ +struct snd_card_aica *dreamcastcard; + dreamcastcard = kcontrol->private_data; +if (unlikely (!dreamcastcard->channel)) { +return -ETXTBSY ;/* too soon */ + }else +if (unlikely (dreamcastcard->channel->vol == + ucontrol->value.integer.value[0 ])) +return 0 ; +else {
This if/else mess is still painful to read, and your indentation level is broken, which doesn't make it any easier to follow. If you're returning anyways, then just kill the else in both cases.
linux-2.6.16.14/sound/sh/aica.c line 159
Quoted 9 lines
linux-2.6.16.14/sound/sh/aica.c +9
-0+/* Fill up the members of the embedded device structure */ +static void populate_dreamcastaicadev (struct device *dev) +{ + dev->bus = &platform_bus_type; + dev->driver = &aica_driver; +driver_register (dev->driver); +device_bind_driver (dev); +} +
This is still not something you should be doing yourself, use the platform_driver instead.
linux-2.6.16.14/sound/sh/aica.c line 166
Quoted 7 lines
linux-2.6.16.14/sound/sh/aica.c +7
-0+static int __devinit add_aicamixer_controls (struct snd_card_aica + *dreamcastcard) +{ +int err; + err =snd_ctl_add + (dreamcastcard->card, +snd_ctl_new1 (&snd_aica_pcmvolume_control, dreamcastcard));
More mangled whitespace. indent may have been responsible for it, you're still the one submitting the patch.
linux-2.6.16.14/sound/sh/aica.c line 169
Quoted 3 lines
linux-2.6.16.14/sound/sh/aica.c +3
-0+return 0 ; + freepcm: + freedreamcast:
goto labels are still in bizzarely indented locations.
linux-2.6.16.14/sound/sh/aica.c line 177
Quoted 8 lines
linux-2.6.16.14/sound/sh/aica.c +8
-0+static void __exit aica_exit(void) +{ +struct device_driver *drv = (&pd->dev)->driver; +flush_workqueue (aica_queue); +destroy_workqueue (aica_queue); +device_release_driver (&pd->dev); +driver_unregister (drv); +platform_device_unregister (pd);
Your driver model handling really needs to be reworked a bit..
linux-2.6.16.14/sound/sh/aica.c line 179
Quoted 2 lines
linux-2.6.16.14/sound/sh/aica.c +2
-0+/* Kill any sound still playing and reset ARM7 to safe state */ +spu_init ();
Perhaps spu_reset() is a bit more sensible of a name, spu_init() is a bit non-sensical to call from an exit routine..
linux-2.6.16.14/sound/sh/Kconfig line 3
Quoted 7 lines
diff -ruN a/linux-2.6.16.14/sound/sh/Kconfig b/linux-2.6.16.14/sound/sh/Kconfig
linux-2.6.16.14/sound/sh/Kconfig +3
-0@@ -0,0 +1,15 @@ +menu "SH (Super-H) devices" + depends on SND!=n && SUPERH +
Please just use SuperH, it's not hyphenated, and it's more readable than just SH.
_______________________________________________
Alsa-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/alsa-devel
Quoted 13 lines · Paul Mundt
Quoted 1 line
+static void
spu_init(void)This can probably be inlined..
Quoted 9 lines
(quoted diff) +9
-0+/* aica_chn_start - write to spu to start playback */ +static void aica_chn_start(void) +{ + spu_write_wait(); + writel(AICA_CMD_KICK | AICA_CMD_START, + (uint32_t *) AICA_CONTROL_POINT); +} + +/* aica_chn_halt - write to spu to halt playback */
Quoted 9 lines
Review
Quoted 7 lines
(quoted diff) +7
-0+static void aica_chn_halt(void) +{ + spu_write_wait(); + writel(AICA_CMD_KICK | AICA_CMD_STOP, + (uint32_t *) AICA_CONTROL_POINT); +} +These too.
No point in inlining these as they all wait on a FIFO to clear - ie the benefit of inling will be tiny. I notice a stray inline still lurking from the code that can go...
Quoted 13 lines · Paul Mundt
Quoted 1 line
+static void
spu_init(void)This can probably be inlined..
Quoted 9 lines
(quoted diff) +9
-0+/* aica_chn_start - write to spu to start playback */ +static void aica_chn_start(void) +{ + spu_write_wait(); + writel(AICA_CMD_KICK | AICA_CMD_START, + (uint32_t *) AICA_CONTROL_POINT); +} + +/* aica_chn_halt - write to spu to halt playback */
Quoted 9 lines
Review
Quoted 7 lines
(quoted diff) +7
-0+static void aica_chn_halt(void) +{ + spu_write_wait(); + writel(AICA_CMD_KICK | AICA_CMD_STOP, + (uint32_t *) AICA_CONTROL_POINT); +} +These too.
No point in inlining these as they all wait on a FIFO to clear - ie the benefit of inling will be tiny. I notice a stray inline still lurking from the code that can go...