Skip to contentSkip to conversation

AHCI suspend/resume support -- take 2

PATCH In review zhao, forrest 2 participants 3 messages Jun 6, 2006 – Jun 22, 2006 libata

lore
Share & tools
lore
#0 lore raw

cover AHCI suspend/resume support -- take 2

Hello, all

This is the take 2 of AHCI suspend/resume patches.

This series of patches provide the support for AHCI suspend/resume. The patch works very well on Napa SDV in our lab.

The patch is against libata-dev #upstream
[ef2824073fba9def3cf122e89cc485f66dd71f70].

Compared with last version, the changes are:
1 Use ata_wait_register() to replace the code of waiting register bit to change
2 Replace mdelay(500) with at most waiting 1 second in ahci_start_fis_rx ()
3 Remove code for cold_presence_detection in ahci_port_spinup() 4 In ahci_port_standby(), refine the code and comments to make the logic correct
5 Remove the field 'dev_map' of struct ahci_host_priv{} and move the host interrupt enabling code into ahci_pci_device_resume()

Your comments and bug report are welcome.

Thanks,
Forrest

#1 lore raw
Quoted 2 lines · forrest

This is the take 2 of AHCI suspend/resume patches.

This no longer applies against 2.6.17-mm1. Do you have an updated version, or has the equivalent behaviour been merged into libata -> -mm now? Or should I just try and merge it?

Thanks,
J

#2 lore raw
Quoted 7 lines · Jeremy Fitzhardinge
Quoted 2 lines · forrest

This is the take 2 of AHCI suspend/resume patches.

This no longer applies against 2.6.17-mm1. Do you have an updated version, or has the equivalent behaviour been merged into libata -> -mm now? Or should I just try and merge it?

The patch was not for 2.6.17-mm1, it was against libata-#upstream. Now I'm waiting for Tejun's PM patch being accepted into libata- #upstream, after that I'll send out take 3 of AHCI suspend/resume patch.

Thanks,
Forrest