mmc: correct the HS400 initialization process
PATCH v2 1/1 mmc: correct the HS400 initialization process
After the commit b9a2a0e2e9c0 ("mmc: Add support for downgrading HS200/HS400 to HS mode"), it add a parameter in mmc_set_card_speed() which indicates that the HS200/HS400 to HS downgrade is happening.
During the HS400 initialization, first select to HS200, and config the related clock rate, then downgrade to HS mode. So here also need to config the downgrade value to be true for two reasons. First, make sure in the function mmc_set_card_speed(), after switch to HS mode, first config the clock rate, then read the EXT_CSD, avoid receiving data of EXT_CSD in HS mode at 200MHz. Second, after issue the MMC_CMD_SWITCH command, it need to wait a bit then switch bus properties.
Test on i.MX8QM MEK board, some Micron eMMC will stuck in transfer mode in this case, and USDHC will never get data transfer complete status, cause the uboot hang.
--- drivers/mmc/mmc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/mmc/mmc.c +1 -2
@@ -1892,8 +1892,7 @@ static int mmc_select_hs400(struct mmc *mmc) }/* Set back to HS */ -mmc_set_card_speed (mmc,MMC_HS , false); -mmc_set_clock (mmc,mmc_mode2freq (mmc,MMC_HS ), false); +mmc_set_card_speed (mmc,MMC_HS , true); err =mmc_switch (mmc,EXT_CSD_CMD_SET_NORMAL ,EXT_CSD_BUS_WIDTH ,EXT_CSD_BUS_WIDTH_8 |EXT_CSD_DDR_FLAG );
Signature · 1 line
2.17.1
PATCH v2 1/1 mmc: correct the HS400 initialization process
Quoted 13 lines · BOUGH CHEN
After the commit
b9a2a0e2e9c0("mmc: Add support for downgrading HS200/HS400 to HS mode"), it add a parameter inmmc_set_card_speed()which indicates that the HS200/HS400 to HS downgrade is happening.During the HS400 initialization, first select to HS200, and config the related clock rate, then downgrade to HS mode. So here also need to config the downgrade value to be true for two reasons. First, make sure in the function
mmc_set_card_speed(), after switch to HS mode, first config the clock rate, then read theEXT_CSD, avoid receiving data ofEXT_CSDin HS mode at 200MHz. Second, after issue theMMC_CMD_SWITCHcommand, it need to wait a bit then switch bus properties.
Quoted 5 lines
Test on i.MX8QM MEK board, some Micron eMMC will stuck in transfer mode in this case, and USDHC will never get data transfer complete status, cause the uboot hang.
Signed-off-by Haibo Chen <[email protected]>
Quoted 19 lines
--- drivers/mmc/mmc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)drivers/mmc/mmc.c +1
-2@@ -1892,8 +1892,7 @@ static int mmc_select_hs400(struct mmc *mmc) }/* Set back to HS */ -mmc_set_card_speed (mmc,MMC_HS , false); -mmc_set_clock (mmc,mmc_mode2freq (mmc,MMC_HS ), false); +mmc_set_card_speed (mmc,MMC_HS , true); err =mmc_switch (mmc,EXT_CSD_CMD_SET_NORMAL ,EXT_CSD_BUS_WIDTH ,EXT_CSD_BUS_WIDTH_8 |EXT_CSD_DDR_FLAG );
Signature · 2 lines
Best regards, Marek Vasut
PATCH v2 1/1 mmc: correct the HS400 initialization process
In reply to BOUGH CHENQuoted 13 lines · BOUGH CHEN
After the commit
b9a2a0e2e9c0("mmc: Add support for downgrading HS200/HS400 to HS mode"), it add a parameter inmmc_set_card_speed()which indicates that the HS200/HS400 to HS downgrade is happening.During the HS400 initialization, first select to HS200, and config the related clock rate, then downgrade to HS mode. So here also need to config the downgrade value to be true for two reasons. First, make sure in the function
mmc_set_card_speed(), after switch to HS mode, first config the clock rate, then read theEXT_CSD, avoid receiving data ofEXT_CSDin HS mode at 200MHz. Second, after issue theMMC_CMD_SWITCHcommand, it need to wait a bit then switch bus properties.
Quoted 6 lines
Test on i.MX8QM MEK board, some Micron eMMC will stuck in transfer mode in this case, and USDHC will never get data transfer complete status, cause the uboot hang.
Signed-off-by Haibo Chen <[email protected]>Acked-by Marek Vasut <[email protected]>
Applied to u-boot/master, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190329/19e9d608/attachment.sig>