Skip to contentSkip to conversation

Replace kmalloc and memset in get_undo_list with kzalloc

PATCH Matt Helsley 1 participant 1 message Jun 13, 2006

lore
Share & tools
lore
#0 lore raw

This patch simplifies get_undo_list() by dropping the unnecessary cast, removing the size variable, and switching to kzalloc() instead of a kmalloc() followed by a memset().

This cleanup was split then modified from Jes Sorenson's Task Notifiers patches.

--

Compiles, boots.

 ipc/sem.c |    5 +----
 1 files changed, 1 insertion(+), 4 deletions(-)
ipc/sem.c +1 -4
Index: linux-2.6.17-rc6/ipc/sem.c
===================================================================
@@ -1002,19 +1002,16 @@ static inline void unlock_semundo(void)
  * This can block, so callers must hold no locks.
  */
 static inline int get_undo_list(struct sem_undo_list **undo_listp)
 {
 	struct sem_undo_list *undo_list;
-	int size;
 
 	undo_list = current->sysvsem.undo_list;
 	if (!undo_list) {
-		size = sizeof(struct sem_undo_list);
-		undo_list = (struct sem_undo_list *) kmalloc(size, GFP_KERNEL);
+		undo_list = kzalloc(sizeof(*undo_list), GFP_KERNEL);
 		if (undo_list == NULL)
 			return -ENOMEM;
-		memset(undo_list, 0, size);
 		spin_lock_init(&undo_list->lock);
 		atomic_set(&undo_list->refcnt, 1);
 		current->sysvsem.undo_list = undo_list;
 	}
 	*undo_listp = undo_list;