pam_namespace : allow use of X and gdm while polyinstantiating /tmp
PATCH 1/1 pam_namespace : allow use of X and gdm while polyinstantiating /tmp
This patch updates pam_namespace to allow the use of graphical display manager while polyinstantiating /tmp. It applies on top of the 06/15/06 version of pam_namespace in rawhide.
Changes since the last version:
- Execute instance initialization script at each instance setup
- Properly obtain exit status from a child process that executes the instance initialization script
- Example script for using X while polyinstantiating /tmp
- Update Makefile.am to make sure that the instance initialization script gets installed with execute permission
- Update man pages and README to reflect above changes
---
Makefile.am | 3 ++- README | 2 +- namespace.conf.5.xml | 2 +- namespace.init | 21 +++++++++++++++++++++ pam_namespace.8.xml | 36 ++++++++++++++++++++++++------------ pam_namespace.c | 32 ++++++++++++++++++++++++-------- 6 files changed, 73 insertions(+), 23 deletions(-)
modules/pam_namespace/Makefile.am +2 -1
@@ -33,5 +33,6 @@ if HAVE_UNSHARE securelib_LTLIBRARIES = pam_namespace.la pam_namespace_la_SOURCES = pam_namespace.c md5.c md5.h -secureconf_DATA = namespace.conf namespace.init +secureconf_DATA = namespace.conf +secureconf_SCRIPT = namespace.init endif
modules/pam_namespace/README +1 -1
@@ -11,7 +11,7 @@ and users' home directory. If an executable script /etc/security/namespace.init exists, it is used to initialize the namespace every time a new instance directory -is created. The script receives the polyinstantiated directory path +is setup. The script receives the polyinstantiated directory path and the instance directory path as its arguments. Each line in namespace.conf describes a limit for a user in the form:
modules/pam_namespace/namespace.conf.5.xml +1 -1
@@ -25,7 +25,7 @@ or, in the case of SELinux, user name, security context or both. If an executable script <filename>/etc/security/namespace.init</filename> exists, it is used to initialize the namespace every time a new instance - directory is created. The script receives the polyinstantiated + directory is setup. The script receives the polyinstantiated directory path and the instance directory path as its arguments. </para>
modules/pam_namespace/namespace.init +21 -0
@@ -1,3 +1,24 @@ #!/bin/sh # This is only a boilerplate for the instance initialization script. # It receives polydir path as $1 and the instance path as $2. +# +# If you intend to polyinstantiate /tmp and you also want to use the X windows +# environment, you will have to use this script to bind mount the socket that +# is used by the X server to communicate with its clients. X server places +# this socket in /tmp/.X11-unix directory, which will get obscured by +# polyinstantiation. Uncommenting the following lines will bind mount +# relevant the directory at an alternative location (/.tmp/.X11-unix) such +# that the X server, window manager and X clients, can still find the +# socket X0 at the polyinstanted /tmp/.X11-unix. +# +#if [ $1 = /tmp ]; then +# if [ ! -f /.tmp/.X11-unix ]; then +# mkdir -p /.tmp/.X11-unix +# fi +# mount --bind /tmp/.X11-unix /.tmp/.X11-unix +# cp -fp /tmp/.X0-lock $2/.X0-lock +# mkdir $2/.X11-unix +# ln -fs /.tmp/.X11-unix/X0 $2/.X11-unix/X0 +#fi + +exit 0
modules/pam_namespace/pam_namespace.8.xml +24 -12
@@ -56,7 +56,7 @@ using SELinux, user name, security context or both. If an executable script <filename>/etc/security/namespace.init</filename> exists, it is used to initialize the namespace every time a new instance - directory is created. The script receives the polyinstantiated + directory is setup. The script receives the polyinstantiated directory path and the instance directory path as its arguments. </para>
@@ -255,22 +255,34 @@ <para> This allows gdm to restart after each session and appropriately adjust - namesapces of display manager and the X server. If polyinstantiation of - /tmp is desired along with the graphical environment, then addtional + namesapces of display manager and the X server. If polyinstantiation + of /tmp is desired along with the graphical environment, then additional configuration changes are needed to address the interaction of X server - and font server namespaces with their use of /tmp to create communication - sockets. Perform the following changes to use graphical environment - with polyinstantiation of /tmp: + and font server namespaces with their use of /tmp to create + communication sockets. Please use the initialization script + <filename>/etc/security/namespace.init</filename> to ensure that + the X server and its clients can appropirately access the + communication socket X0. Please refer to the sample instructions + provided in the comment section of the instance initalization script + <filename>/etc/security/namespace.init</filename>. In addition, + perform the following changes to use graphical environment with + polyinstantiation of /tmp: </para> <para> <literallayout> - 1. Setup default init state to 3, by modifying /etc/inittab - 2. Disable the use of font server by commenting out "FontPath" - line in /etc/X11/xorg.conf. - 3. Ensure that the login service is setup to use pam_namespace, - as described above, by modifying /etc/pam.d/login. - 4. Use the "startx" command after a successful terminal login. + 1. Disable the use of font server by commenting out "FontPath" + line in /etc/X11/xorg.conf. If you do want to use the font server + then you will have to augment the instance initialization + script to appropriately provide /tmp/.font-unix from the + polyinstantiated /tmp. + 2. Ensure that the gdm service is setup to use pam_namespace, + as described above, by modifying /etc/pam.d/gdm. + 3. Ensure that the display manager is configured to restart X server + with each new session. This default setup can be verified by + making sure that /usr/share/gdm/defaults.conf contains + "AlwaysRestartServer=true", and it is not overriden by + /etc/gdm/custom.conf. </literallayout> </para>
modules/pam_namespace/pam_namespace.c +24 -8
@@ -632,8 +632,10 @@ static int create_dirs(const struct poly#endif {struct stat statbuf, newstatbuf, instpbuf; -int fd, pid, status; +int fd, status;char *inst_parent, *trailing_slash; +pid_t rc, pid; +sighandler_t osighand =NULL ;/* * stat the directory to polyinstantiate, so its owner-group-mode
@@ -705,7 +707,7 @@ static int create_dirs(const struct poly*/ if (mkdir (ipath,S_IRUSR ) <0 ) {if (errno ==EEXIST ) -return PAM_SUCCESS ; + goto inst_init;else {pam_syslog (idata->pamh,LOG_ERR ,"Error creating %s, %m" , ipath);
@@ -776,12 +778,19 @@ static int create_dirs(const struct poly* directory as arguments. */ +inst_init: + osighand =signal (SIGCHLD ,SIG_DFL ); +if (osighand ==NULL ) { +pam_syslog (idata->pamh,LOG_ERR ,"Cannot set signal value" ); +return PAM_SESSION_ERR ; + } +if (access (NAMESPACE_INIT_SCRIPT ,F_OK ) ==0 ) {if (access (NAMESPACE_INIT_SCRIPT ,X_OK ) <0 ) {if (idata->flags &PAMNS_DEBUG )pam_syslog (idata->pamh,LOG_ERR ,"Namespace init script not executable" ); -rmdir (ipath); + (void )signal (SIGCHLD , osighand);return PAM_SESSION_ERR ; }else { pid =fork ();
@@ -796,22 +805,29 @@ static int create_dirs(const struct poly polyptr->dir, ipath, (char *)NULL) < 0)exit (1 ); }else if (pid >0 ) { -while (waitpid (pid, &status,0 ) != pid); -if (!WIFEXITED (status) ||WEXITSTATUS (status) >0 ) { +while (((rc =waitpid (pid, &status,0 )) == (pid_t)-1 ) && + (errno ==EINTR )); +if (rc == (pid_t)-1 ) { +pam_syslog (idata->pamh,LOG_ERR ,"waitpid failed- %m" ); + (void )signal (SIGCHLD , osighand); +return PAM_SESSION_ERR ; + } +if (!WIFEXITED (status) ||WIFSIGNALED (status) >0 ) {pam_syslog (idata->pamh,LOG_ERR ,"Error initializing instance" ); -rmdir (ipath); + (void )signal (SIGCHLD , osighand);return PAM_SESSION_ERR ; } }else if (pid <0 ) {pam_syslog (idata->pamh,LOG_ERR ,"Cannot fork to run namespace init script, %m" ); -rmdir (ipath); + (void )signal (SIGCHLD , osighand);return PAM_SESSION_ERR ; } } } + (void )signal (SIGCHLD , osighand);return PAM_SUCCESS ; }
@@ -894,7 +910,7 @@ static int ns_setup(const struct polydir#ifdef WITH_SELINUX if ((idata->flags &PAMNS_DEBUG ) && (idata->flags &PAMNS_SELINUX_ENABLED )) -pam_syslog (idata->pamh,LOG_DEBUG ,"Inst context %s Orig context %s" , +pam_syslog (idata->pamh,LOG_DEBUG ,"Inst ctxt %s Orig ctxt %s" , instcontext, origcontext);#endif }
--
This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to [email protected] with the words "unsubscribe selinux" without quotes as the message.
Quoted 13 lines · Janak Desai
This patch updates
pam_namespaceto allow the use of graphical display manager while polyinstantiating /tmp. It applies on top of the 06/15/06 version ofpam_namespacein rawhide.Changes since the last version:
- Execute instance initialization script at each instance setup
- Properly obtain exit status from a child process that executes the instance initialization script
- Example script for using X while polyinstantiating /tmp
- Update Makefile.am to make sure that the instance initialization script gets installed with execute permission
- Update man pages and README to reflect above changes
Quoted 1 line
Signed-off-by Janak Desai <[email protected]>
Hi Janak,
Just some nits...
Quoted 50 lines
---
Makefile.am | 3 ++- README | 2 +- namespace.conf.5.xml | 2 +- namespace.init | 21 +++++++++++++++++++++ pam_namespace.8.xml | 36 ++++++++++++++++++++++++------------ pam_namespace.c | 32 ++++++++++++++++++++++++-------- 6 files changed, 73 insertions(+), 23 deletions(-)diff -Naurp pam_namespace0615/modules/pam_namespace/Makefile.am pam_namespace0615+patch/modules/pam_namespace/Makefile.am
modules/pam_namespace/Makefile.am +2
-1@@ -33,5 +33,6 @@ if HAVE_UNSHARE securelib_LTLIBRARIES = pam_namespace.la pam_namespace_la_SOURCES = pam_namespace.c md5.c md5.h -secureconf_DATA = namespace.conf namespace.init +secureconf_DATA = namespace.conf +secureconf_SCRIPT = namespace.init endifdiff -Naurp pam_namespace0615/modules/pam_namespace/README pam_namespace0615+patch/modules/pam_namespace/README
modules/pam_namespace/README +1
-1@@ -11,7 +11,7 @@ and users' home directory. If an executable script /etc/security/namespace.init exists, it is used to initialize the namespace every time a new instance directory -is created. The script receives the polyinstantiated directory path +is setup. The script receives the polyinstantiated directory path and the instance directory path as its arguments. Each line in namespace.conf describes a limit for a user in the form:diff -Naurp
pam_namespace0615/modules/pam_namespace/namespace.conf.5.xmlpam_namespace0615+patch/modules/pam_namespace/namespace.conf.5.xmlmodules/pam_namespace/namespace.conf.5.xml +1
-1@@ -25,7 +25,7 @@ or, in the case of SELinux, user name, security context or both. If an executable script <filename>/etc/security/namespace.init</filename> exists, it is used to initialize the namespace every time a new instance - directory is created. The script receives the polyinstantiated + directory is setup. The script receives the polyinstantiated directory path and the instance directory path as its arguments. </para>diff -Naurp pam_namespace0615/modules/pam_namespace/namespace.init pam_namespace0615+patch/modules/pam_namespace/namespace.init
modules/pam_namespace/namespace.init line 10
Quoted 10 lines
modules/pam_namespace/namespace.init +7
-0@@ -1,3 +1,24 @@ #!/bin/sh # This is only a boilerplate for the instance initialization script. # It receives polydir path as $1 and the instance path as $2. +# +# If you intend to polyinstantiate /tmp and you also want to use the X windows +# environment, you will have to use this script to bind mount the socket that +# is used by the X server to communicate with its clients. X server places +# this socket in /tmp/.X11-unix directory, which will get obscured by +# polyinstantiation. Uncommenting the following lines will bind mount +# relevant the directory at an alternative location (/.tmp/.X11-unix) such
The use of the word "relevant" here makes the sentence awkward... If this was intended, perhaps:
Uncommenting the following lines will bind mount, relevant the directory, at an alternative location...
Not sure.
[..]
Quoted 4 lines
modules/pam_namespace/namespace.init +4
-0+# that the X server, window manager and X clients, can still find the +# socket X0 at the polyinstanted /tmp/.X11-unix. +# +#if [ $1 = /tmp ]; then
modules/pam_namespace/namespace.init line 24
Quoted 10 lines
modules/pam_namespace/namespace.init +10
-0+# if [ ! -f /.tmp/.X11-unix ]; then +# mkdir -p /.tmp/.X11-unix +# fi +# mount --bind /tmp/.X11-unix /.tmp/.X11-unix +# cp -fp /tmp/.X0-lock $2/.X0-lock +# mkdir $2/.X11-unix +# ln -fs /.tmp/.X11-unix/X0 $2/.X11-unix/X0 +#fi + +exit 0
Should you not check arguments? For instance,
if [ ! -d $2 ]; then
echo "$2 is not a directory."
exit 1
fi
[..]
Quoted 13 lines
diff -Naurp
pam_namespace0615/modules/pam_namespace/pam_namespace.8.xmlpam_namespace0615+patch/modules/pam_namespace/pam_namespace.8.xmlmodules/pam_namespace/pam_namespace.8.xml +1
-1@@ -56,7 +56,7 @@ using SELinux, user name, security context or both. If an executable script <filename>/etc/security/namespace.init</filename> exists, it is used to initialize the namespace every time a new instance - directory is created. The script receives the polyinstantiated + directory is setup. The script receives the polyinstantiated directory path and the instance directory path as its arguments. </para>
modules/pam_namespace/pam_namespace.8.xml line 258
Quoted 6 lines
modules/pam_namespace/pam_namespace.8.xml +1
-2@@ -255,22 +255,34 @@ <para> This allows gdm to restart after each session and appropriately adjust - namesapces of display manager and the X server. If polyinstantiation of - /tmp is desired along with the graphical environment, then addtional + namesapces of display manager and the X server. If polyinstantiation
Probably a good idea to just correct this spelling error, since you're changing the line anyway and you fixed "additional" below.
[..]
modules/pam_namespace/pam_namespace.8.xml line 264
Quoted 9 lines
modules/pam_namespace/pam_namespace.8.xml +5
-3+ of /tmp is desired along with the graphical environment, then additional configuration changes are needed to address the interaction of X server - and font server namespaces with their use of /tmp to create communication - sockets. Perform the following changes to use graphical environment - with polyinstantiation of /tmp: + and font server namespaces with their use of /tmp to create + communication sockets. Please use the initialization script + <filename>/etc/security/namespace.init</filename> to ensure that + the X server and its clients can appropirately access the
Another spelling error. It should be "appropriately".
[..]
modules/pam_namespace/pam_namespace.8.xml line 266
Quoted 2 lines
modules/pam_namespace/pam_namespace.8.xml +2
-0+ communication socket X0. Please refer to the sample instructions + provided in the comment section of the instance initalization script
Another spelling error. It should be "initialization".
[..]
Quoted 76 lines
modules/pam_namespace/pam_namespace.8.xml +15
-6+ <filename>/etc/security/namespace.init</filename>. In addition, + perform the following changes to use graphical environment with + polyinstantiation of /tmp: </para> <para> <literallayout> - 1. Setup default init state to 3, by modifying /etc/inittab - 2. Disable the use of font server by commenting out "FontPath" - line in /etc/X11/xorg.conf. - 3. Ensure that the login service is setup to use pam_namespace, - as described above, by modifying /etc/pam.d/login. - 4. Use the "startx" command after a successful terminal login. + 1. Disable the use of font server by commenting out "FontPath" + line in /etc/X11/xorg.conf. If you do want to use the font server + then you will have to augment the instance initialization + script to appropriately provide /tmp/.font-unix from the + polyinstantiated /tmp. + 2. Ensure that the gdm service is setup to use pam_namespace, + as described above, by modifying /etc/pam.d/gdm. + 3. Ensure that the display manager is configured to restart X server + with each new session. This default setup can be verified by + making sure that /usr/share/gdm/defaults.conf contains + "AlwaysRestartServer=true", and it is not overriden by + /etc/gdm/custom.conf. </literallayout> </para>diff -Naurp
pam_namespace0615/modules/pam_namespace/pam_namespace.cpam_namespace0615+patch/modules/pam_namespace/pam_namespace.cmodules/pam_namespace/pam_namespace.c +12
-3@@ -632,8 +632,10 @@ static int create_dirs(const struct poly#endif {struct stat statbuf, newstatbuf, instpbuf; -int fd, pid, status; +int fd, status;char *inst_parent, *trailing_slash; +pid_t rc, pid; +sighandler_t osighand =NULL ;/* * stat the directory to polyinstantiate, so its owner-group-mode @@ -705,7 +707,7 @@ static int create_dirs(const struct poly*/ if (mkdir (ipath,S_IRUSR ) <0 ) {if (errno ==EEXIST ) -return PAM_SUCCESS ; + goto inst_init;else {pam_syslog (idata->pamh,LOG_ERR ,"Error creating %s, %m" , ipath);@@ -776,12 +778,19 @@ static int create_dirs(const struct poly* directory as arguments. */ +inst_init: + osighand =signal (SIGCHLD ,SIG_DFL ); +if (osighand ==NULL ) { +pam_syslog (idata->pamh,LOG_ERR ,"Cannot set signal value" ); +return PAM_SESSION_ERR ; + } +if (access (NAMESPACE_INIT_SCRIPT ,F_OK ) ==0 ) {if (access (NAMESPACE_INIT_SCRIPT ,X_OK ) <0 ) {if (idata->flags &PAMNS_DEBUG )pam_syslog (idata->pamh,LOG_ERR ,"Namespace init script not executable" ); -rmdir (ipath); + (void )signal (SIGCHLD , osighand);return PAM_SESSION_ERR ; }else { pid =fork ();@@ -796,22 +805,29 @@ static int create_dirs(const struct poly polyptr->dir, ipath, (char *)NULL) < 0)exit (1 );
modules/pam_namespace/pam_namespace.c static int create_dirs(const struct poly · line 814
Quoted 10 lines
modules/pam_namespace/pam_namespace.c +7
-2}else if (pid >0 ) { -while (waitpid (pid, &status,0 ) != pid); -if (!WIFEXITED (status) ||WEXITSTATUS (status) >0 ) { +while (((rc =waitpid (pid, &status,0 )) == (pid_t)-1 ) && + (errno ==EINTR )); +if (rc == (pid_t)-1 ) { +pam_syslog (idata->pamh,LOG_ERR ,"waitpid failed- %m" ); + (void )signal (SIGCHLD , osighand); +return PAM_SESSION_ERR ; + }
White-space pollution? I see tabs for this closing bracket, but spaces for everything else?? Things aren't aligning correctly here... not familiar with this code though.
[..]
Quoted 23 lines
modules/pam_namespace/pam_namespace.c +4
-2+if (!WIFEXITED (status) ||WIFSIGNALED (status) >0 ) {pam_syslog (idata->pamh,LOG_ERR ,"Error initializing instance" ); -rmdir (ipath); + (void )signal (SIGCHLD , osighand);return PAM_SESSION_ERR ; } }else if (pid <0 ) {pam_syslog (idata->pamh,LOG_ERR ,"Cannot fork to run namespace init script, %m" ); -rmdir (ipath); + (void )signal (SIGCHLD , osighand);return PAM_SESSION_ERR ; } } } + (void )signal (SIGCHLD , osighand);return PAM_SUCCESS ; }
modules/pam_namespace/pam_namespace.c static int ns_setup(const struct polydir · line 916
Quoted 8 lines
modules/pam_namespace/pam_namespace.c +1
-1@@ -894,7 +910,7 @@ static int ns_setup(const struct polydir#ifdef WITH_SELINUX if ((idata->flags &PAMNS_DEBUG ) && (idata->flags &PAMNS_SELINUX_ENABLED )) -pam_syslog (idata->pamh,LOG_DEBUG ,"Inst context %s Orig context %s" , +pam_syslog (idata->pamh,LOG_DEBUG ,"Inst ctxt %s Orig ctxt %s" , instcontext, origcontext);#endif }
--
This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to [email protected] with the words "unsubscribe selinux" without quotes as the message.
Quoted 269 lines · Timothy R. Chavez
Quoted 13 lines · Janak Desai
This patch updates
pam_namespaceto allow the use of graphical display manager while polyinstantiating /tmp. It applies on top of the 06/15/06 version ofpam_namespacein rawhide.Changes since the last version:
- Execute instance initialization script at each instance setup
- Properly obtain exit status from a child process that executes the instance initialization script
- Example script for using X while polyinstantiating /tmp
- Update Makefile.am to make sure that the instance initialization script gets installed with execute permission
- Update man pages and README to reflect above changesQuoted 1 line
Signed-off-by Janak Desai <[email protected]>Hi Janak,
Just some nits...
Quoted 50 lines
---
Makefile.am | 3 ++- README | 2 +- namespace.conf.5.xml | 2 +- namespace.init | 21 +++++++++++++++++++++ pam_namespace.8.xml | 36 ++++++++++++++++++++++++------------ pam_namespace.c | 32 ++++++++++++++++++++++++-------- 6 files changed, 73 insertions(+), 23 deletions(-)diff -Naurp pam_namespace0615/modules/pam_namespace/Makefile.am pam_namespace0615+patch/modules/pam_namespace/Makefile.am
modules/pam_namespace/Makefile.am +2
-1@@ -33,5 +33,6 @@ if HAVE_UNSHARE securelib_LTLIBRARIES = pam_namespace.la pam_namespace_la_SOURCES = pam_namespace.c md5.c md5.h -secureconf_DATA = namespace.conf namespace.init +secureconf_DATA = namespace.conf +secureconf_SCRIPT = namespace.init endifdiff -Naurp pam_namespace0615/modules/pam_namespace/README pam_namespace0615+patch/modules/pam_namespace/README
modules/pam_namespace/README +1
-1@@ -11,7 +11,7 @@ and users' home directory. If an executable script /etc/security/namespace.init exists, it is used to initialize the namespace every time a new instance directory -is created. The script receives the polyinstantiated directory path +is setup. The script receives the polyinstantiated directory path and the instance directory path as its arguments. Each line in namespace.conf describes a limit for a user in the form:diff -Naurp
pam_namespace0615/modules/pam_namespace/namespace.conf.5.xmlpam_namespace0615+patch/modules/pam_namespace/namespace.conf.5.xmlmodules/pam_namespace/namespace.conf.5.xml +1
-1@@ -25,7 +25,7 @@ or, in the case of SELinux, user name, security context or both. If an executable script <filename>/etc/security/namespace.init</filename> exists, it is used to initialize the namespace every time a new instance - directory is created. The script receives the polyinstantiated + directory is setup. The script receives the polyinstantiated directory path and the instance directory path as its arguments. </para>diff -Naurp pam_namespace0615/modules/pam_namespace/namespace.init pam_namespace0615+patch/modules/pam_namespace/namespace.init
modules/pam_namespace/namespace.init line 10
Quoted 10 lines
modules/pam_namespace/namespace.init +7
-0@@ -1,3 +1,24 @@ #!/bin/sh # This is only a boilerplate for the instance initialization script. # It receives polydir path as $1 and the instance path as $2. +# +# If you intend to polyinstantiate /tmp and you also want to use the X windows +# environment, you will have to use this script to bind mount the socket that +# is used by the X server to communicate with its clients. X server places +# this socket in /tmp/.X11-unix directory, which will get obscured by +# polyinstantiation. Uncommenting the following lines will bind mount +# relevant the directory at an alternative location (/.tmp/.X11-unix) suchThe use of the word "relevant" here makes the sentence awkward... If this was intended, perhaps:
Uncommenting the following lines will bind mount, relevant the directory, at an alternative location...
Not sure.
[..]
Quoted 4 lines
modules/pam_namespace/namespace.init +4
-0+# that the X server, window manager and X clients, can still find the +# socket X0 at the polyinstanted /tmp/.X11-unix. +# +#if [ $1 = /tmp ]; thenmodules/pam_namespace/namespace.init line 24
Quoted 10 lines
modules/pam_namespace/namespace.init +10
-0+# if [ ! -f /.tmp/.X11-unix ]; then +# mkdir -p /.tmp/.X11-unix +# fi +# mount --bind /tmp/.X11-unix /.tmp/.X11-unix +# cp -fp /tmp/.X0-lock $2/.X0-lock +# mkdir $2/.X11-unix +# ln -fs /.tmp/.X11-unix/X0 $2/.X11-unix/X0 +#fi + +exit 0Should you not check arguments? For instance,
if [ ! -d $2 ]; then
echo "$2 is not a directory."
exit 1
fi[..]
Quoted 13 lines
diff -Naurp
pam_namespace0615/modules/pam_namespace/pam_namespace.8.xmlpam_namespace0615+patch/modules/pam_namespace/pam_namespace.8.xmlmodules/pam_namespace/pam_namespace.8.xml +1
-1@@ -56,7 +56,7 @@ using SELinux, user name, security context or both. If an executable script <filename>/etc/security/namespace.init</filename> exists, it is used to initialize the namespace every time a new instance - directory is created. The script receives the polyinstantiated + directory is setup. The script receives the polyinstantiated directory path and the instance directory path as its arguments. </para>modules/pam_namespace/pam_namespace.8.xml line 258
Quoted 6 lines
modules/pam_namespace/pam_namespace.8.xml +1
-2@@ -255,22 +255,34 @@ <para> This allows gdm to restart after each session and appropriately adjust - namesapces of display manager and the X server. If polyinstantiation of - /tmp is desired along with the graphical environment, then addtional + namesapces of display manager and the X server. If polyinstantiationProbably a good idea to just correct this spelling error, since you're changing the line anyway and you fixed "additional" below.
[..]
modules/pam_namespace/pam_namespace.8.xml line 264
Quoted 9 lines
modules/pam_namespace/pam_namespace.8.xml +5
-3+ of /tmp is desired along with the graphical environment, then additional configuration changes are needed to address the interaction of X server - and font server namespaces with their use of /tmp to create communication - sockets. Perform the following changes to use graphical environment - with polyinstantiation of /tmp: + and font server namespaces with their use of /tmp to create + communication sockets. Please use the initialization script + <filename>/etc/security/namespace.init</filename> to ensure that + the X server and its clients can appropirately access theAnother spelling error. It should be "appropriately".
[..]
modules/pam_namespace/pam_namespace.8.xml line 266
Quoted 2 lines
modules/pam_namespace/pam_namespace.8.xml +2
-0+ communication socket X0. Please refer to the sample instructions + provided in the comment section of the instance initalization scriptAnother spelling error. It should be "initialization".
[..]
Quoted 76 lines
modules/pam_namespace/pam_namespace.8.xml +15
-6+ <filename>/etc/security/namespace.init</filename>. In addition, + perform the following changes to use graphical environment with + polyinstantiation of /tmp: </para> <para> <literallayout> - 1. Setup default init state to 3, by modifying /etc/inittab - 2. Disable the use of font server by commenting out "FontPath" - line in /etc/X11/xorg.conf. - 3. Ensure that the login service is setup to use pam_namespace, - as described above, by modifying /etc/pam.d/login. - 4. Use the "startx" command after a successful terminal login. + 1. Disable the use of font server by commenting out "FontPath" + line in /etc/X11/xorg.conf. If you do want to use the font server + then you will have to augment the instance initialization + script to appropriately provide /tmp/.font-unix from the + polyinstantiated /tmp. + 2. Ensure that the gdm service is setup to use pam_namespace, + as described above, by modifying /etc/pam.d/gdm. + 3. Ensure that the display manager is configured to restart X server + with each new session. This default setup can be verified by + making sure that /usr/share/gdm/defaults.conf contains + "AlwaysRestartServer=true", and it is not overriden by + /etc/gdm/custom.conf. </literallayout> </para>diff -Naurp
pam_namespace0615/modules/pam_namespace/pam_namespace.cpam_namespace0615+patch/modules/pam_namespace/pam_namespace.cmodules/pam_namespace/pam_namespace.c +12
-3@@ -632,8 +632,10 @@ static int create_dirs(const struct poly#endif {struct stat statbuf, newstatbuf, instpbuf; -int fd, pid, status; +int fd, status;char *inst_parent, *trailing_slash; +pid_t rc, pid; +sighandler_t osighand =NULL ;/* * stat the directory to polyinstantiate, so its owner-group-mode @@ -705,7 +707,7 @@ static int create_dirs(const struct poly*/ if (mkdir (ipath,S_IRUSR ) <0 ) {if (errno ==EEXIST ) -return PAM_SUCCESS ; + goto inst_init;else {pam_syslog (idata->pamh,LOG_ERR ,"Error creating %s, %m" , ipath);@@ -776,12 +778,19 @@ static int create_dirs(const struct poly* directory as arguments. */ +inst_init: + osighand =signal (SIGCHLD ,SIG_DFL ); +if (osighand ==NULL ) { +pam_syslog (idata->pamh,LOG_ERR ,"Cannot set signal value" ); +return PAM_SESSION_ERR ; + } +if (access (NAMESPACE_INIT_SCRIPT ,F_OK ) ==0 ) {if (access (NAMESPACE_INIT_SCRIPT ,X_OK ) <0 ) {if (idata->flags &PAMNS_DEBUG )pam_syslog (idata->pamh,LOG_ERR ,"Namespace init script not executable" ); -rmdir (ipath); + (void )signal (SIGCHLD , osighand);return PAM_SESSION_ERR ; }else { pid =fork ();@@ -796,22 +805,29 @@ static int create_dirs(const struct poly polyptr->dir, ipath, (char *)NULL) < 0)exit (1 );modules/pam_namespace/pam_namespace.c static int create_dirs(const struct poly · line 814
Quoted 10 lines
modules/pam_namespace/pam_namespace.c +7
-2}else if (pid >0 ) { -while (waitpid (pid, &status,0 ) != pid); -if (!WIFEXITED (status) ||WEXITSTATUS (status) >0 ) { +while (((rc =waitpid (pid, &status,0 )) == (pid_t)-1 ) && + (errno ==EINTR )); +if (rc == (pid_t)-1 ) { +pam_syslog (idata->pamh,LOG_ERR ,"waitpid failed- %m" ); + (void )signal (SIGCHLD , osighand); +return PAM_SESSION_ERR ; + }White-space pollution? I see tabs for this closing bracket, but spaces for everything else?? Things aren't aligning correctly here... not familiar with this code though.
[..]
Quoted 21 lines
modules/pam_namespace/pam_namespace.c +4
-2+if (!WIFEXITED (status) ||WIFSIGNALED (status) >0 ) {pam_syslog (idata->pamh,LOG_ERR ,"Error initializing instance" ); -rmdir (ipath); + (void )signal (SIGCHLD , osighand);return PAM_SESSION_ERR ; } }else if (pid <0 ) {pam_syslog (idata->pamh,LOG_ERR ,"Cannot fork to run namespace init script, %m" ); -rmdir (ipath); + (void )signal (SIGCHLD , osighand);return PAM_SESSION_ERR ; } } } + (void )signal (SIGCHLD , osighand);return PAM_SUCCESS ; }
Quoted 12 lines
modules/pam_namespace/pam_namespace.c static int ns_setup(const struct polydir · line 916
Quoted 10 lines
modules/pam_namespace/pam_namespace.c +1
-1@@ -894,7 +910,7 @@ static int ns_setup(const struct polydir#ifdef WITH_SELINUX if ((idata->flags &PAMNS_DEBUG ) && (idata->flags &PAMNS_SELINUX_ENABLED )) -pam_syslog (idata->pamh,LOG_DEBUG ,"Inst context %s Orig context %s" , +pam_syslog (idata->pamh,LOG_DEBUG ,"Inst ctxt %s Orig ctxt %s" , instcontext, origcontext);#endif }
Thanks Tim. I will clean this up and send out an updated patch by Monday.
-Janak
--
This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to [email protected] with the words "unsubscribe selinux" without quotes as the message.
BTW, I talked to the X-Windows developers here and they are looking into getting rid of the /tmp requirement all together for X-Windows.
Dan
--
This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to [email protected] with the words "unsubscribe selinux" without quotes as the message.
Quoted 4 lines · --- Daniel J Walsh
BTW, I talked to the X-Windows developers here and they are looking into
getting rid of the /tmp requirement all together for X-Windows.
You might want to see if they're still using
any of the shared memory transports that cropped
up in the mid 90's.
Casey Schaufler
[email protected]
--
This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to [email protected] with the words "unsubscribe selinux" without quotes as the message.
Quoted 2 lines · Daniel J Walsh
BTW, I talked to the X-Windows developers here and they are looking into getting rid of the /tmp requirement all together for X-Windows.
What exactly do you mean? Do you mean moving it somewhere else such as /var/run or do you mean using TCP instead?
Signature · 9 lines
http://www.coker.com.au/selinux/ My NSA Security Enhanced Linux packages http://www.coker.com.au/bonnie++/ Bonnie++ hard drive benchmark http://www.coker.com.au/postal/ Postal SMTP/POP benchmark http://www.coker.com.au/~russell/ My home page -- This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to [email protected] with the words "unsubscribe selinux" without quotes as the message.
Quoted 9 lines · Russell Coker
Quoted 3 lines · Daniel J Walsh
BTW, I talked to the X-Windows developers here and they are looking into getting rid of the /tmp requirement all together for X-Windows.
What exactly do you mean? Do you mean moving it somewhere else such as
/var/runor do you mean using TCP instead?
They are talking about using abstract namespaces.
Dan
--
This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to [email protected] with the words "unsubscribe selinux" without quotes as the message.
Quoted 4 lines · Daniel J Walsh
Quoted 2 lines
What exactly do you mean? Do you mean moving it somewhere else such as
/var/runor do you mean using TCP instead?They are talking about using abstract namespaces.
What exactly do you mean? Do you mean having the X server or the XDM program create PI directories?
Signature · 10 lines
http://www.coker.com.au/selinux/ My NSA Security Enhanced Linux packages http://www.coker.com.au/bonnie++/ Bonnie++ hard drive benchmark http://www.coker.com.au/postal/ Postal SMTP/POP benchmark http://www.coker.com.au/~russell/ My home page -- This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to [email protected] with the words "unsubscribe selinux" without quotes as the message.
Quoted 11 lines · Russell Coker
Quoted 5 lines · Daniel J Walsh
Quoted 3 lines
What exactly do you mean? Do you mean moving it somewhere else such as
/var/runor do you mean using TCP instead?They are talking about using abstract namespaces.
What exactly do you mean? Do you mean having the X server or the XDM program create PI directories?
That is all I know.
They are looking at having the XServer listen on abstract sockets.
I think Bill Crawford (OgreBoy) wrote a patch to do this and they are investigating it.
Nothing may come of this, but they are considering it.
--
This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to [email protected] with the words "unsubscribe selinux" without quotes as the message.
Quoted 7 lines · Russell Coker
Quoted 4 lines · Daniel J Walsh
Quoted 2 lines
What exactly do you mean? Do you mean moving it somewhere else such as
/var/runor do you mean using TCP instead?They are talking about using abstract namespaces.
What exactly do you mean?
man 7 unix
Signature · 1 line
James Antill <[email protected]>
Quoted 269 lines · Timothy R. Chavez
Quoted 13 lines · Janak Desai
This patch updates
pam_namespaceto allow the use of graphical display manager while polyinstantiating /tmp. It applies on top of the 06/15/06 version ofpam_namespacein rawhide.Changes since the last version:
- Execute instance initialization script at each instance setup
- Properly obtain exit status from a child process that executes the instance initialization script
- Example script for using X while polyinstantiating /tmp
- Update Makefile.am to make sure that the instance initialization script gets installed with execute permission
- Update man pages and README to reflect above changesQuoted 1 line
Signed-off-by Janak Desai <[email protected]>Hi Janak,
Just some nits...
Quoted 50 lines
---
Makefile.am | 3 ++- README | 2 +- namespace.conf.5.xml | 2 +- namespace.init | 21 +++++++++++++++++++++ pam_namespace.8.xml | 36 ++++++++++++++++++++++++------------ pam_namespace.c | 32 ++++++++++++++++++++++++-------- 6 files changed, 73 insertions(+), 23 deletions(-)diff -Naurp pam_namespace0615/modules/pam_namespace/Makefile.am pam_namespace0615+patch/modules/pam_namespace/Makefile.am
modules/pam_namespace/Makefile.am +2
-1@@ -33,5 +33,6 @@ if HAVE_UNSHARE securelib_LTLIBRARIES = pam_namespace.la pam_namespace_la_SOURCES = pam_namespace.c md5.c md5.h -secureconf_DATA = namespace.conf namespace.init +secureconf_DATA = namespace.conf +secureconf_SCRIPT = namespace.init endifdiff -Naurp pam_namespace0615/modules/pam_namespace/README pam_namespace0615+patch/modules/pam_namespace/README
modules/pam_namespace/README +1
-1@@ -11,7 +11,7 @@ and users' home directory. If an executable script /etc/security/namespace.init exists, it is used to initialize the namespace every time a new instance directory -is created. The script receives the polyinstantiated directory path +is setup. The script receives the polyinstantiated directory path and the instance directory path as its arguments. Each line in namespace.conf describes a limit for a user in the form:diff -Naurp
pam_namespace0615/modules/pam_namespace/namespace.conf.5.xmlpam_namespace0615+patch/modules/pam_namespace/namespace.conf.5.xmlmodules/pam_namespace/namespace.conf.5.xml +1
-1@@ -25,7 +25,7 @@ or, in the case of SELinux, user name, security context or both. If an executable script <filename>/etc/security/namespace.init</filename> exists, it is used to initialize the namespace every time a new instance - directory is created. The script receives the polyinstantiated + directory is setup. The script receives the polyinstantiated directory path and the instance directory path as its arguments. </para>diff -Naurp pam_namespace0615/modules/pam_namespace/namespace.init pam_namespace0615+patch/modules/pam_namespace/namespace.init
modules/pam_namespace/namespace.init line 10
Quoted 10 lines
modules/pam_namespace/namespace.init +7
-0@@ -1,3 +1,24 @@ #!/bin/sh # This is only a boilerplate for the instance initialization script. # It receives polydir path as $1 and the instance path as $2. +# +# If you intend to polyinstantiate /tmp and you also want to use the X windows +# environment, you will have to use this script to bind mount the socket that +# is used by the X server to communicate with its clients. X server places +# this socket in /tmp/.X11-unix directory, which will get obscured by +# polyinstantiation. Uncommenting the following lines will bind mount +# relevant the directory at an alternative location (/.tmp/.X11-unix) suchThe use of the word "relevant" here makes the sentence awkward... If this was intended, perhaps:
Uncommenting the following lines will bind mount, relevant the directory, at an alternative location...
Not sure.
[..]
Quoted 4 lines
modules/pam_namespace/namespace.init +4
-0+# that the X server, window manager and X clients, can still find the +# socket X0 at the polyinstanted /tmp/.X11-unix. +# +#if [ $1 = /tmp ]; thenmodules/pam_namespace/namespace.init line 24
Quoted 10 lines
modules/pam_namespace/namespace.init +10
-0+# if [ ! -f /.tmp/.X11-unix ]; then +# mkdir -p /.tmp/.X11-unix +# fi +# mount --bind /tmp/.X11-unix /.tmp/.X11-unix +# cp -fp /tmp/.X0-lock $2/.X0-lock +# mkdir $2/.X11-unix +# ln -fs /.tmp/.X11-unix/X0 $2/.X11-unix/X0 +#fi + +exit 0Should you not check arguments? For instance,
if [ ! -d $2 ]; then
echo "$2 is not a directory."
exit 1
fi[..]
Quoted 13 lines
diff -Naurp
pam_namespace0615/modules/pam_namespace/pam_namespace.8.xmlpam_namespace0615+patch/modules/pam_namespace/pam_namespace.8.xmlmodules/pam_namespace/pam_namespace.8.xml +1
-1@@ -56,7 +56,7 @@ using SELinux, user name, security context or both. If an executable script <filename>/etc/security/namespace.init</filename> exists, it is used to initialize the namespace every time a new instance - directory is created. The script receives the polyinstantiated + directory is setup. The script receives the polyinstantiated directory path and the instance directory path as its arguments. </para>modules/pam_namespace/pam_namespace.8.xml line 258
Quoted 6 lines
modules/pam_namespace/pam_namespace.8.xml +1
-2@@ -255,22 +255,34 @@ <para> This allows gdm to restart after each session and appropriately adjust - namesapces of display manager and the X server. If polyinstantiation of - /tmp is desired along with the graphical environment, then addtional + namesapces of display manager and the X server. If polyinstantiationProbably a good idea to just correct this spelling error, since you're changing the line anyway and you fixed "additional" below.
[..]
modules/pam_namespace/pam_namespace.8.xml line 264
Quoted 9 lines
modules/pam_namespace/pam_namespace.8.xml +5
-3+ of /tmp is desired along with the graphical environment, then additional configuration changes are needed to address the interaction of X server - and font server namespaces with their use of /tmp to create communication - sockets. Perform the following changes to use graphical environment - with polyinstantiation of /tmp: + and font server namespaces with their use of /tmp to create + communication sockets. Please use the initialization script + <filename>/etc/security/namespace.init</filename> to ensure that + the X server and its clients can appropirately access theAnother spelling error. It should be "appropriately".
[..]
modules/pam_namespace/pam_namespace.8.xml line 266
Quoted 2 lines
modules/pam_namespace/pam_namespace.8.xml +2
-0+ communication socket X0. Please refer to the sample instructions + provided in the comment section of the instance initalization scriptAnother spelling error. It should be "initialization".
[..]
Quoted 76 lines
modules/pam_namespace/pam_namespace.8.xml +15
-6+ <filename>/etc/security/namespace.init</filename>. In addition, + perform the following changes to use graphical environment with + polyinstantiation of /tmp: </para> <para> <literallayout> - 1. Setup default init state to 3, by modifying /etc/inittab - 2. Disable the use of font server by commenting out "FontPath" - line in /etc/X11/xorg.conf. - 3. Ensure that the login service is setup to use pam_namespace, - as described above, by modifying /etc/pam.d/login. - 4. Use the "startx" command after a successful terminal login. + 1. Disable the use of font server by commenting out "FontPath" + line in /etc/X11/xorg.conf. If you do want to use the font server + then you will have to augment the instance initialization + script to appropriately provide /tmp/.font-unix from the + polyinstantiated /tmp. + 2. Ensure that the gdm service is setup to use pam_namespace, + as described above, by modifying /etc/pam.d/gdm. + 3. Ensure that the display manager is configured to restart X server + with each new session. This default setup can be verified by + making sure that /usr/share/gdm/defaults.conf contains + "AlwaysRestartServer=true", and it is not overriden by + /etc/gdm/custom.conf. </literallayout> </para>diff -Naurp
pam_namespace0615/modules/pam_namespace/pam_namespace.cpam_namespace0615+patch/modules/pam_namespace/pam_namespace.cmodules/pam_namespace/pam_namespace.c +12
-3@@ -632,8 +632,10 @@ static int create_dirs(const struct poly#endif {struct stat statbuf, newstatbuf, instpbuf; -int fd, pid, status; +int fd, status;char *inst_parent, *trailing_slash; +pid_t rc, pid; +sighandler_t osighand =NULL ;/* * stat the directory to polyinstantiate, so its owner-group-mode @@ -705,7 +707,7 @@ static int create_dirs(const struct poly*/ if (mkdir (ipath,S_IRUSR ) <0 ) {if (errno ==EEXIST ) -return PAM_SUCCESS ; + goto inst_init;else {pam_syslog (idata->pamh,LOG_ERR ,"Error creating %s, %m" , ipath);@@ -776,12 +778,19 @@ static int create_dirs(const struct poly* directory as arguments. */ +inst_init: + osighand =signal (SIGCHLD ,SIG_DFL ); +if (osighand ==NULL ) { +pam_syslog (idata->pamh,LOG_ERR ,"Cannot set signal value" ); +return PAM_SESSION_ERR ; + } +if (access (NAMESPACE_INIT_SCRIPT ,F_OK ) ==0 ) {if (access (NAMESPACE_INIT_SCRIPT ,X_OK ) <0 ) {if (idata->flags &PAMNS_DEBUG )pam_syslog (idata->pamh,LOG_ERR ,"Namespace init script not executable" ); -rmdir (ipath); + (void )signal (SIGCHLD , osighand);return PAM_SESSION_ERR ; }else { pid =fork ();@@ -796,22 +805,29 @@ static int create_dirs(const struct poly polyptr->dir, ipath, (char *)NULL) < 0)exit (1 );modules/pam_namespace/pam_namespace.c static int create_dirs(const struct poly · line 814
Quoted 10 lines
modules/pam_namespace/pam_namespace.c +7
-2}else if (pid >0 ) { -while (waitpid (pid, &status,0 ) != pid); -if (!WIFEXITED (status) ||WEXITSTATUS (status) >0 ) { +while (((rc =waitpid (pid, &status,0 )) == (pid_t)-1 ) && + (errno ==EINTR )); +if (rc == (pid_t)-1 ) { +pam_syslog (idata->pamh,LOG_ERR ,"waitpid failed- %m" ); + (void )signal (SIGCHLD , osighand); +return PAM_SESSION_ERR ; + }White-space pollution? I see tabs for this closing bracket, but spaces for everything else?? Things aren't aligning correctly here... not familiar with this code though.
[..]
Quoted 21 lines
modules/pam_namespace/pam_namespace.c +4
-2+if (!WIFEXITED (status) ||WIFSIGNALED (status) >0 ) {pam_syslog (idata->pamh,LOG_ERR ,"Error initializing instance" ); -rmdir (ipath); + (void )signal (SIGCHLD , osighand);return PAM_SESSION_ERR ; } }else if (pid <0 ) {pam_syslog (idata->pamh,LOG_ERR ,"Cannot fork to run namespace init script, %m" ); -rmdir (ipath); + (void )signal (SIGCHLD , osighand);return PAM_SESSION_ERR ; } } } + (void )signal (SIGCHLD , osighand);return PAM_SUCCESS ; }
Quoted 12 lines
modules/pam_namespace/pam_namespace.c static int ns_setup(const struct polydir · line 916
Quoted 10 lines
modules/pam_namespace/pam_namespace.c +1
-1@@ -894,7 +910,7 @@ static int ns_setup(const struct polydir#ifdef WITH_SELINUX if ((idata->flags &PAMNS_DEBUG ) && (idata->flags &PAMNS_SELINUX_ENABLED )) -pam_syslog (idata->pamh,LOG_DEBUG ,"Inst context %s Orig context %s" , +pam_syslog (idata->pamh,LOG_DEBUG ,"Inst ctxt %s Orig ctxt %s" , instcontext, origcontext);#endif }
Tim,
I have made above changes in the patch that I just posted. I did not include the argument checking in the script example, because the script will be called from the namespace module with two existing directories as arguments.
-Janak
Quoted 5 lines
--
This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to [email protected] with the words "unsubscribe selinux" without quotes as the message.
--
This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to [email protected] with the words "unsubscribe selinux" without quotes as the message.
Quoted 10 lines · Janak Desai
Changes since the last version:
- Execute instance initialization script at each instance setup
- Properly obtain exit status from a child process that executes the instance initialization script
- Example script for using X while polyinstantiating /tmp
- Update Makefile.am to make sure that the instance initialization script gets installed with execute permission
- Update man pages and README to reflect above changesSigned-off-by Janak Desai <[email protected]>
Minor nit....
modules/pam_namespace/Makefile.am if HAVE_UNSHARE · line 38
Quoted 11 lines
diff -Naurp pam_namespace0615/modules/pam_namespace/Makefile.am pam_namespace0615+patch/modules/pam_namespace/Makefile.am
modules/pam_namespace/Makefile.am +2
-1@@ -33,5 +33,6 @@ if HAVE_UNSHARE securelib_LTLIBRARIES = pam_namespace.la pam_namespace_la_SOURCES = pam_namespace.c md5.c md5.h -secureconf_DATA = namespace.conf namespace.init +secureconf_DATA = namespace.conf +secureconf_SCRIPT = namespace.init endif
This chokes on an 'rpmbuild', because namespace.init doesn't get installed. The problem is that there's supporting stuff in the Makefile that gets produces to install the secoreconf_DATA (see the install-secureconfDATA target), but there's no matching install-secureconfSCRIPT target to get the script installed to make rpmbuild happy.... Nuking that one part gets an RPM that packages /etc/security/namespace.init.
I'll post later about whether the sample namespace.init actually works when you uncomment the X11 support code..