Skip to contentSkip to conversation

Remove useless check in drivers/net/pcmcia/xirc2ps_cs.c

PATCH New Eric Sesterhenn 1 participant 1 message Jun 21, 2006 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Remove useless check in drivers/net/pcmcia/xirc2ps_cs.c

hi,

coverity choked at this check (id #223), assuming that skb might be NULL and used anyways later. Since start_hard_xmit() always gets called with a valid skb, the check is useless and this patch removes it.

drivers/net/pcmcia/xirc2ps_cs.c renamed from drivers/net/pcmcia/xirc2ps_cs.c.orig +1 -1
@@ -1359,7 +1359,7 @@ do_start_xmit(struct sk_buff *skb, struc
     kio_addr_t ioaddr = dev->base_addr;
     int okay;
     unsigned freespace;
-    unsigned pktlen = skb? skb->len : 0;
+    unsigned pktlen = skb->len;
 
     DEBUG(1, "do_start_xmit(skb=%p, dev=%p) len=%u\n",
 	  skb, dev, pktlen);