Skip to contentSkip to conversation

Array overrun in drivers/net/tokenring/3c359.c

PATCH New Eric Sesterhenn 1 participant 1 message Jun 21, 2006 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Array overrun in drivers/net/tokenring/3c359.c

hi,

this was spotted by coverity (#id 502)
the xl_laa[] array has only 6 entries, since the else case uses i-10 as array index to dev->dev_addr[] i guess thats what should be done here too

drivers/net/tokenring/3c359.c renamed from drivers/net/tokenring/3c359.c.orig +1 -1
@@ -764,7 +764,7 @@ static int xl_open_hw(struct net_device 
 	if (xl_priv->xl_laa[0]) {  /* If using a LAA address */
 		for (i=10;i<16;i++) { 
 			writel( (MEM_BYTE_WRITE | 0xD0000 | xl_priv->srb) + i, xl_mmio + MMIO_MAC_ACCESS_CMD) ; 
-			writeb(xl_priv->xl_laa[i],xl_mmio + MMIO_MACDATA) ; 
+			writeb(xl_priv->xl_laa[i-10],xl_mmio + MMIO_MACDATA) ; 
 		}
 		memcpy(dev->dev_addr,xl_priv->xl_laa,dev->addr_len) ; 
 	} else { /* Regular hardware address */