Skip to contentSkip to conversation

Memory leak in drivers/net/irda/via-ircc.c

PATCH New Eric Sesterhenn 1 participant 1 message Jun 21, 2006 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Memory leak in drivers/net/irda/via-ircc.c

hi,

this was spotted by coverity (id #653). whenever (len-4<2) we leak the allocated skb.

drivers/net/irda/via-ircc.c renamed from drivers/net/irda/via-ircc.c.orig +6 -1
@@ -1220,8 +1220,13 @@ static int upload_rxdata(struct via_ircc
 
 	IRDA_DEBUG(2, "%s(): len=%x\n", __FUNCTION__, len);
 
+	if ((len - 4) < 2 ) {
+		self->stats.rx_dropped++;
+		return FALSE;
+	}
+
 	skb = dev_alloc_skb(len + 1);
-	if ((skb == NULL) || ((len - 4) < 2)) {
+	if (skb == NULL) {
 		self->stats.rx_dropped++;
 		return FALSE;
 	}