Memory leak in drivers/net/irda/via-ircc.c
PATCH 1/1 Memory leak in drivers/net/irda/via-ircc.c
hi,
this was spotted by coverity (id #653). whenever (len-4<2) we leak the allocated skb.
Signed-off-by Eric Sesterhenn <[email protected]>
drivers/net/irda/via-ircc.c renamed from drivers/net/irda/via-ircc.c.orig +6 -1
@@ -1220,8 +1220,13 @@ static int upload_rxdata(struct via_irccIRDA_DEBUG (2 ,"%s(): len=%x\n" , __FUNCTION__, len); +if ((len -4 ) <2 ) { + self->stats.rx_dropped++; +return FALSE; + } + skb =dev_alloc_skb (len +1 ); -if ((skb ==NULL ) || ((len -4 ) <2 )) { +if (skb ==NULL ) { self->stats.rx_dropped++;return FALSE; }