Skip to contentSkip to conversation

Missing statement in drivers/media/dvb/frontends/cx22700.c

PATCH New Eric Sesterhenn 1 participant 1 message Jun 27, 2006 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Missing statement in drivers/media/dvb/frontends/cx22700.c

hi,

stumbled over this because of coverity (id #492), seems like we are missing a return statement here and fail to do proper bounds checking. If this assumption is false we should at least change the identation to make it clear

drivers/media/dvb/frontends/cx22700.c renamed from drivers/media/dvb/frontends/cx22700.c.orig +1 -0
@@ -134,6 +134,7 @@ static int cx22700_set_tps (struct cx227
 		return -EINVAL;
 
 	if (p->code_rate_LP < FEC_1_2 || p->code_rate_LP > FEC_7_8)
+		return -EINVAL;
 
 	if (p->code_rate_HP == FEC_4_5 || p->code_rate_LP == FEC_4_5)
 		return -EINVAL;