sound skips on 2.6.16.17
A message that is not in the archive (sent off-list or not yet received): [email protected]
A message that is not in the archive (sent off-list or not yet received): [email protected]
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 6 lines · Hugo Vanwoerkom
Quoted 5 lines · ocilent1 wrote:
You don't happen to use a VIA chipset do you? For PCLinuxOS kernels, I found that a few people with VIA based mobos started experiencing sound problems (skipping / stuttering) once we hit 2.6.16.17. Backing out the following 2 patches added in 2.6.16.17 seem to fix the problems.
Quoted 8 lines
Quoted 6 lines
1) PCI-VIA-quirk-fixup-additional-PCI-IDs.patch
2) PCI-quirk-VIA-IRQ-fixup-should-only-run-for-VIA-southbridges.patchI have attached some patches you might want to try that reverse out the above patches. You will need to apply the patches in the correct order (as above)
Works like a charm. End of the sound skips.
Not sure if this has been reported to lkml so I'm cc'ing it here and the stable maintainer.
Signature · 1 line
-ck
Quoted 1 line · Con Kolivas
Quoted 1 line
Quoted 1 line
1) PCI-VIA-quirk-fixup-additional-PCI-IDs.patch
that shouldn't break things, if it does I *really* want to know
Quoted 2 lines
Quoted 1 line
Quoted 1 line
2)
PCI-quirk-VIA-IRQ-fixup-should-only-run-for-VIA-southbridges.patch
nor should that, so again i would like to know if this is the one that makes a difference
Quoted 1 line
Quoted 1 line
Works like a charm. End of the sound skips.
what cpu/mainboard/etc
Quoted 7 lines · Chris Wedgwood
Quoted 1 line · Con Kolivas
Quoted 1 line
Quoted 1 line
1) PCI-VIA-quirk-fixup-additional-PCI-IDs.patch
that shouldn't break things, if it does I *really* want to know
Quoted 2 lines
Quoted 1 line
Quoted 1 line
2)
Quoted 8 lines
Quoted 1 line
PCI-quirk-VIA-IRQ-fixup-should-only-run-for-VIA-southbridges.patch
nor should that, so again i would like to know if this is the one that makes a difference
Quoted 1 line
Quoted 1 line
Works like a charm. End of the sound skips.
what cpu/mainboard/etc
It is the 2nd patch (PCI-quirk-VIA-IRQ-fixup-should-only-run-for-VIA-southbridges.patch) that is causing the sound stuttering/skipping problems for our users with VIA chipsets. Backing out the first patch alone did not fix the problem (PCI-VIA-quirk-fixup-additional-PCI-IDs.patch) but to back out the 2nd patch, you need to have initially backed out the first patch, due to the way the patches apply in series.
Because I was too lazy to make a new patch which backs out only the 2nd patch (PCI-quirk-VIA-IRQ-fixup-should-only-run-for-VIA-southbridges.patch) changes, I still have not confirmed if its the 2nd patch alone that is causing breakage, or if its a combination of both of them.
It took me a long time to track down this problem, as I was spending all my time looking at alsa related stuff, but then we finally found that it was infact anything above the 2.6.16.17 stable release that was breaking things. The obvious first target was to backout the VIA related changes made in the 2.6.16.17 release and bingo.... my testers with VIA chipsets were happy again....
Signature · 1 line
*ocilent1
Quoted 6 lines · On Sun, Jun 18, 2006 at 12:04:29PM +0800, ocilent1 wrote:
(PCI-quirk-VIA-IRQ-fixup-should-only-run-for-VIA-southbridges.patch) that is causing the sound stuttering/skipping problems for our users with VIA chipsets. Backing out the first patch alone did not fix the problem (PCI-VIA-quirk-fixup-additional-PCI-IDs.patch) but to back out the 2nd patch, you need to have initially backed out the first patch, due to the way the patches apply in series.
what mainboard/CPU do you have there?
what does 'lspci -n' say?
Quoted 11 lines · Chris Wedgwood
Quoted 6 lines · On Sun, Jun 18, 2006 at 12:04:29PM +0800, ocilent1 wrote:
(PCI-quirk-VIA-IRQ-fixup-should-only-run-for-VIA-southbridges.patch) that is causing the sound stuttering/skipping problems for our users with VIA chipsets. Backing out the first patch alone did not fix the problem (PCI-VIA-quirk-fixup-additional-PCI-IDs.patch) but to back out the 2nd patch, you need to have initially backed out the first patch, due to the way the patches apply in series.
what mainboard/CPU do you have there?
what does 'lspci -n' say?
I personally don't have any via mb's.... I just package the kernels... I will try and get some more detailed info from my testers for you....
Signature · 1 line
*ocilent1
Quoted 11 lines · Chris Wedgwood
Quoted 7 lines · On Sun, Jun 18, 2006 at 12:04:29PM +0800, ocilent1 wrote:
(PCI-quirk-VIA-IRQ-fixup-should-only-run-for-VIA-southbridges.patch) that is causing the sound stuttering/skipping problems for our users with VIA chipsets. Backing out the first patch alone did not fix the problem (PCI-VIA-quirk-fixup-additional-PCI-IDs.patch) but to back out the 2nd patch, you need to have initially backed out the first patch, due to the way the patches apply in series.
Quoted 5 lines
what mainboard/CPU do you have there?
what does 'lspci -n' say?
/home/hugoSun Jun 18-06:08:30HDC1# lspci -n 0000:00:00.0 0600: 1106:0269 0000:00:00.1 0600: 1106:1269 0000:00:00.2 0600: 1106:2269 0000:00:00.3 0600: 1106:3269 0000:00:00.4 0600: 1106:4269 0000:00:00.7 0600: 1106:7269 0000:00:01.0 0604: 1106:b198 0000:00:0a.0 0300: 10de:0181 (rev a2) 0000:00:0b.0 0104: 1095:3112 (rev 02) 0000:00:0c.0 0401: 1102:0007 0000:00:0f.0 0101: 1106:0571 (rev 06) 0000:00:10.0 0c03: 1106:3038 (rev 81) 0000:00:10.1 0c03: 1106:3038 (rev 81) 0000:00:10.2 0c03: 1106:3038 (rev 81) 0000:00:10.3 0c03: 1106:3038 (rev 81) 0000:00:10.4 0c03: 1106:3104 (rev 86) 0000:00:11.0 0601: 1106:3227 0000:00:11.5 0401: 1106:3059 (rev 60) 0000:00:12.0 0200: 1106:3065 (rev 78) 0000:01:00.0 0300: 10de:0185 (rev c1)
Quoted 31 lines · --- Hugo Vanwoerkom
Quoted 11 lines · Chris Wedgwood
Quoted 7 lines · On Sun, Jun 18, 2006 at 12:04:29PM +0800, ocilent1 wrote:
(PCI-quirk-VIA-IRQ-fixup-should-only-run-for-VIA-southbridges.patch) that is causing the sound stuttering/skipping problems for our users with VIA chipsets. Backing out the first patch alone did not fix the problem (PCI-VIA-quirk-fixup-additional-PCI-IDs.patch) but to back out the 2nd patch, you need to have initially backed out the first patch, due to the way the patches apply in series.
Quoted 5 lines
what mainboard/CPU do you have there?
what does 'lspci -n' say?
/home/hugoSunJun 18-06:08:30HDC1# lspci -n 0000:00:00.0 0600: 1106:0269 0000:00:00.1 0600: 1106:1269 0000:00:00.2 0600: 1106:2269 0000:00:00.3 0600: 1106:3269 0000:00:00.4 0600: 1106:4269 0000:00:00.7 0600: 1106:7269 0000:00:01.0 0604: 1106:b198 0000:00:0a.0 0300: 10de:0181 (rev a2) 0000:00:0b.0 0104: 1095:3112 (rev 02) 0000:00:0c.0 0401: 1102:0007 0000:00:0f.0 0101: 1106:0571 (rev 06) 0000:00:10.0 0c03: 1106:3038 (rev 81)
Quoted 9 lines
0000:00:10.1 0c03: 1106:3038 (rev 81) 0000:00:10.2 0c03: 1106:3038 (rev 81) 0000:00:10.3 0c03: 1106:3038 (rev 81) 0000:00:10.4 0c03: 1106:3104 (rev 86) 0000:00:11.0 0601: 1106:3227 0000:00:11.5 0401: 1106:3059 (rev 60) 0000:00:12.0 0200: 1106:3065 (rev 78) 0000:01:00.0 0300: 10de:0185 (rev c1)
had sound skipping here too with likely the same southbridge:
(AMD64 K8T800 mobo)
# lspci -n 00:00.0 0600: 1106:0282 00:00.1 0600: 1106:1282 00:00.2 0600: 1106:2282 00:00.3 0600: 1106:3282 00:00.4 0600: 1106:4282 00:00.7 0600: 1106:7282 00:01.0 0604: 1106:b188 00:0b.0 0200: 10ec:8169 (rev 10) 00:0f.0 0101: 1106:0571 (rev 06) 00:10.0 0c03: 1106:3038 (rev 81) 00:10.1 0c03: 1106:3038 (rev 81) 00:10.2 0c03: 1106:3038 (rev 81) 00:10.3 0c03: 1106:3038 (rev 81) 00:10.4 0c03: 1106:3104 (rev 86) 00:11.0 0601: 1106:3227 00:11.5 0401: 1106:3059 (rev 60) 00:18.0 0600: 1022:1100 00:18.1 0600: 1022:1101 00:18.2 0600: 1022:1102 00:18.3 0600: 1022:1103 01:00.0 0300: 10de:0185 (rev c1)
backing out above patches didn't help.
Enabling variable samplerate support by loading
snd-via82xx like this:
# rmmod snd-via82xx # modprobe snd-via82xx dxs_support=5 made the difference here.
Also I completely disabled PCI-quirk-VIA-IRQ-fixup here without any negative impact.
When active, it reports nonsense here:
"PCI: VIA IRQ fixup for 0000:00:0f.0, from 255 to 0" "PCI: VIA IRQ fixup for 0000:00:10.0, from 11 to 3"
Karsten
___________________________________________________________
Telefonate ohne weitere Kosten vom PC zum PC: http://messenger.yahoo.de
Quoted 11 lines · Chris Wedgwood
Quoted 6 lines · On Sun, Jun 18, 2006 at 12:04:29PM +0800, ocilent1 wrote:
(PCI-quirk-VIA-IRQ-fixup-should-only-run-for-VIA-southbridges.patch) that is causing the sound stuttering/skipping problems for our users with VIA chipsets. Backing out the first patch alone did not fix the problem (PCI-VIA-quirk-fixup-additional-PCI-IDs.patch) but to back out the 2nd patch, you need to have initially backed out the first patch, due to the way the patches apply in series.
what mainboard/CPU do you have there?
what does 'lspci -n' say?
It is a compaq presario with KM266 mobo AMD XP2200+
[root@localhost ~]# lspci -n
00:00.0 0600: 1106:3116
00:01.0 0604: 1106:b091
00:0b.0 0200: 10ec:8139 (rev 10)
00:10.0 0c03: 1106:3038 (rev 80)
00:10.1 0c03: 1106:3038 (rev 80)
00:10.2 0c03: 1106:3038 (rev 80)
00:10.3 0c03: 1106:3104 (rev 82)
00:11.0 0601: 1106:3177
00:11.1 0101: 1106:0571 (rev 06)
00:11.5 0401: 1106:3059 (rev 50)
01:00.0 0300: 10de:002d (rev 15)
[root@localhost ~]# lspci -m
00:00.0 "Host bridge" "VIA Technologies, Inc." "VT8375 [KM266/KL266] Host Bridge" "FIRST INTERNATIONAL Computer Inc" "Unknown device 9012" 00:01.0 "PCI bridge" "VIA Technologies, Inc." "VT8633 [Apollo Pro266 AGP]" "" ""
00:0b.0 "Ethernet controller" "Realtek Semiconductor Co., Ltd." "RTL-8139/8139C/8139C+" -r10 "FIRST INTERNATIONAL Computer Inc" "Unknown device 9012"
00:10.0 "USB Controller" "VIA Technologies, Inc." "VT82xxxxx UHCI USB 1.1 Controller" -r80 "FIRST INTERNATIONAL Computer Inc" "Unknown device 9012"
00:10.1 "USB Controller" "VIA Technologies, Inc." "VT82xxxxx UHCI USB 1.1 Controller" -r80 "FIRST INTERNATIONAL Computer Inc" "Unknown device 9012"
00:10.2 "USB Controller" "VIA Technologies, Inc." "VT82xxxxx UHCI USB 1.1 Controller" -r80 "FIRST INTERNATIONAL Computer Inc" "Unknown device 9012"
00:10.3 "USB Controller" "VIA Technologies, Inc." "USB 2.0" -r82 -p20 "FIRST INTERNATIONAL Computer Inc" "Unknown device 9012"
00:11.0 "ISA bridge" "VIA Technologies, Inc." "VT8235 ISA Bridge" "FIRST INTERNATIONAL Computer Inc" "Unknown device 9012"
00:11.1 "IDE interface" "VIA Technologies, Inc." "VT82C586A/B/VT82C686/A/B/VT823x/A/C PIPC Bus Master IDE" -r06 -p8a "FIRST INTERNATIONAL Computer Inc" "Unknown device 9012"
00:11.5 "Multimedia audio controller" "VIA Technologies, Inc." "VT8233/A/8235/8237 AC97 Audio Controller" -r50 "FIRST INTERNATIONAL Computer Inc" "Unknown device 9012"
01:00.0 "VGA compatible controller" "nVidia Corporation" "NV5M64 [RIVA TNT2 Model 64/Model 64 Pro]" -r15 "" ""
Signature · 1 line
*ocilent1
Quoted 9 lines · On Mon, 2006-06-19 at 11:54 +0800, ocilent1 wrote:
Quoted 8 lines · Chris Wedgwood
Quoted 6 lines · On Sun, Jun 18, 2006 at 12:04:29PM +0800, ocilent1 wrote:
(PCI-quirk-VIA-IRQ-fixup-should-only-run-for-VIA-southbridges.patch) that is causing the sound stuttering/skipping problems for our users with VIA chipsets. Backing out the first patch alone did not fix the problem (PCI-VIA-quirk-fixup-additional-PCI-IDs.patch) but to back out the 2nd patch, you need to have initially backed out the first patch, due to the way the patches apply in series.
Quoted 6 lines
Quoted 3 lines
what mainboard/CPU do you have there?
what does 'lspci -n' say?
It is a compaq presario with KM266 mobo AMD XP2200+
Here is lspci -n output from another user on the ALSA lists who is afflicted by this bug:
00:00.0 Class 0600: 1106:0204 00:00.1 Class 0600: 1106:1204 00:00.2 Class 0600: 1106:2204 00:00.3 Class 0600: 1106:3204 00:00.4 Class 0600: 1106:4204 00:00.7 Class 0600: 1106:7204 00:01.0 Class 0604: 1106:b188 00:0a.0 Class 0200: 10ec:8139 (rev 10) 00:0f.0 Class 0101: 1106:0571 (rev 06) 00:10.0 Class 0c03: 1106:3038 (rev 81) 00:10.1 Class 0c03: 1106:3038 (rev 81) 00:10.2 Class 0c03: 1106:3038 (rev 81) 00:10.3 Class 0c03: 1106:3038 (rev 81) 00:10.4 Class 0c03: 1106:3104 (rev 86) 00:11.0 Class 0601: 1106:3227 00:11.5 Class 0401: 1106:3059 (rev 60) 00:18.0 Class 0600: 1022:1100 00:18.1 Class 0600: 1022:1101 00:18.2 Class 0600: 1022:1102 00:18.3 Class 0600: 1022:1103 01:00.0 Class 0300: 1002:4151 01:00.1 Class 0380: 1002:4171
Is it likely to be fixed in 2.6.17.1?
Lee
Quoted 1 line · Lee Revell
Is it likely to be fixed in 2.6.17.1?
I think clearly we'll have to do something.
Quoted 5 lines · Chris Wedgwood
Quoted 1 line · Lee Revell
Is it likely to be fixed in 2.6.17.1?
I think clearly we'll have to do something.
I see that no fix made it into 2.6.17.1 or 2.6.16.22.
What is the downside of simply reverting the patch that introduced the regression?
Lee
Quoted 1 line · Lee Revell
I see that no fix made it into 2.6.17.1 or 2.6.16.22.
both came out very quickly and i was waiting on the results from a couple of people
Quoted 2 lines
What is the downside of simply reverting the patch that introduced the regression?
it breaks for some other people, it's not clear what the 'right' fix here should be, but it might end up being the lesser of two evils
it would be *really* nice if someone from VIA could weigh in here
Quoted 20 lines · Chris Wedgwood
Quoted 1 line · Lee Revell
I see that no fix made it into 2.6.17.1 or 2.6.16.22.
both came out very quickly and i was waiting on the results from a couple of people
Quoted 2 lines
What is the downside of simply reverting the patch that introduced the regression?
it breaks for some other people, it's not clear what the 'right' fix here should be, but it might end up being the lesser of two evils
it would be *really* nice if someone from VIA could weigh in here -
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Quoted 7 lines · Chris Wedgwood
Quoted 1 line · Lee Revell
I see that no fix made it into 2.6.17.1 or 2.6.16.22.
both came out very quickly and i was waiting on the results from a couple of people
Quoted 7 lines
Quoted 2 lines
What is the downside of simply reverting the patch that introduced the regression?
it breaks for some other people, it's not clear what the 'right' fix here should be, but it might end up being the lesser of two evils
it would be *really* nice if someone from VIA could weigh in here
Any progress on this? I don't see a fix in 2.6.17.2.
Lee
Quoted 1 line · Lee Revell
Any progress on this? I don't see a fix in 2.6.17.2.
i'm still trying to get details on why ACPI suffices for some people but not all
i'm hoping to avoid something gross like a whitelist where we avoid the quirk and do it otherwise but that might be the best option right now
Quoted 10 lines · Chris Wedgwood
Quoted 1 line · Lee Revell
Any progress on this? I don't see a fix in 2.6.17.2.
i'm still trying to get details on why ACPI suffices for some people but not all
i'm hoping to avoid something gross like a whitelist where we avoid the quirk and do it otherwise but that might be the best option right now
Two more reports possibly related to this bug:
https://bugtrack.alsa-project.org/alsa-bug/view.php?id=2248
https://bugtrack.alsa-project.org/alsa-bug/view.php?id=2263
Lee
Quoted 4 lines · Lee Revell
Two more reports possibly related to this bug:
https://bugtrack.alsa-project.org/alsa-bug/view.php?id=2248
https://bugtrack.alsa-project.org/alsa-bug/view.php?id=2263
One is definately affected by this.
Can we get an lspci -n from both of these if we haven't seen them before?
Quoted 11 lines · Chris Wedgwood
Quoted 4 lines · Lee Revell
Two more reports possibly related to this bug:
https://bugtrack.alsa-project.org/alsa-bug/view.php?id=2248
https://bugtrack.alsa-project.org/alsa-bug/view.php?id=2263One is definately affected by this.
Can we get an lspci -n from both of these if we haven't seen them before?
#2248 has lspci output attached already, and I requested it for #2263.
Lee
Quoted 10 lines · Chris Wedgwood
Quoted 4 lines · Lee Revell
Two more reports possibly related to this bug:
https://bugtrack.alsa-project.org/alsa-bug/view.php?id=2248
https://bugtrack.alsa-project.org/alsa-bug/view.php?id=2263One is definately affected by this.
Can we get an lspci -n from both of these if we haven't seen them before?
Hows progress on this bug? Don't suppose we have got an official fix for this somewhere on the horizon?
Signature · 1 line
*ocilent1
Quoted 2 lines · On Wed, Jul 19, 2006 at 02:03:25PM +0800, ocilent1 wrote:
Hows progress on this bug? Don't suppose we have got an official fix for this somewhere on the horizon?
Daniel Drake posted this recently, I've not had a chance to look over it in detail but it's probably the best tested suggestion thus far.
Does it work for you?
[PATCH] PCI quirk_via_irq behaviour change
The most recent VIA IRQ quirk changes have broken various VIA devices for some users. We are not able to add these devices to the blacklist as they are also available in PCI-card form, and running the quirk on these devices brings us back to square one (running the VIA quirk on non-VIA boards where the quirk is not needed).
This patch, based on suggestions from Sergey Vlasov, implements a scheme similar to but more restrictive than the scheme we had in 2.6.16 and earlier. It runs the quirk on all VIA hardware, but only if a VIA southbridge was detected on the system.
There is still a downside to this patch: if the user inserts a VIA PCI card into a VIA-based motherboard, the quirk will also run on the VIA PCI card. This corner case is hard to avoid.
However, I think this patch should be applied because:
- The quirk won't run on Chris's non-VIA system, which was the cause of change in the first place.
- Affected sata_via users will be able to boot again
- Nobody really has a full understanding of the problem and the issues, so I think this "compromise solution" should be acceptable for now.
drivers/pci/quirks.c +28 -7
@@ -648,10 +648,37 @@ DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_V* Some of the on-chip devices are actually '586 devices' so they are * listed here. */ + +static int via_irq_fixup_needed =-1 ; + +/* +* As some VIA hardware is available in PCI-card form, we need to restrict +* this quirk to VIA PCI hardware built onto VIA-based motherboards only. +* We try to locate a VIA southbridge before deciding whether the quirk +* should be applied. +*/ +static const struct pci_device_id via_irq_fixup_tbl[] = { + { + .vendor =PCI_VENDOR_ID_VIA , + .device =PCI_ANY_ID , + .subvendor =PCI_ANY_ID , + .subdevice =PCI_ANY_ID , + .class =PCI_CLASS_BRIDGE_ISA <<8 , + .class_mask =0xffff00 , + }, + {0 , }, +}; +static void quirk_via_irq (struct pci_dev *dev) {u8 irq, new_irq; +if (via_irq_fixup_needed ==-1 ) + via_irq_fixup_needed =pci_dev_present (via_irq_fixup_tbl); + +if (!via_irq_fixup_needed) +return ; + new_irq = dev->irq &0xf ;pci_read_config_byte (dev,PCI_INTERRUPT_LINE , &irq);if (new_irq != irq) {
@@ -661,13 +688,7 @@ static void quirk_via_irq(struct pci_devpci_write_config_byte (dev,PCI_INTERRUPT_LINE , new_irq); } } -DECLARE_PCI_FIXUP_ENABLE (PCI_VENDOR_ID_VIA ,PCI_DEVICE_ID_VIA_82C586_0 , quirk_via_irq); -DECLARE_PCI_FIXUP_ENABLE (PCI_VENDOR_ID_VIA ,PCI_DEVICE_ID_VIA_82C586_1 , quirk_via_irq); -DECLARE_PCI_FIXUP_ENABLE (PCI_VENDOR_ID_VIA ,PCI_DEVICE_ID_VIA_82C586_2 , quirk_via_irq); -DECLARE_PCI_FIXUP_ENABLE (PCI_VENDOR_ID_VIA ,PCI_DEVICE_ID_VIA_82C586_3 , quirk_via_irq); -DECLARE_PCI_FIXUP_ENABLE (PCI_VENDOR_ID_VIA ,PCI_DEVICE_ID_VIA_82C686 , quirk_via_irq); -DECLARE_PCI_FIXUP_ENABLE (PCI_VENDOR_ID_VIA ,PCI_DEVICE_ID_VIA_82C686_4 , quirk_via_irq); -DECLARE_PCI_FIXUP_ENABLE (PCI_VENDOR_ID_VIA ,PCI_DEVICE_ID_VIA_82C686_5 , quirk_via_irq); +DECLARE_PCI_FIXUP_ENABLE (PCI_VENDOR_ID_VIA ,PCI_ANY_ID , quirk_via_irq);/* * VIA VT82C598 has its device ID settable and many BIOSes
Quoted 10 lines · Chris Wedgwood
Quoted 2 lines · On Wed, Jul 19, 2006 at 02:03:25PM +0800, ocilent1 wrote:
Hows progress on this bug? Don't suppose we have got an official fix for this somewhere on the horizon?
Daniel Drake posted this recently, I've not had a chance to look over it in detail but it's probably the best tested suggestion thus far.
Does it work for you?
Thanks for the heads up. I'll build a kernel for one of my affected users to test.
Cheers!
Signature · 1 line
*ocilent1
Quoted 14 lines · Chris Wedgwood
Quoted 3 lines · On Wed, Jul 19, 2006 at 02:03:25PM +0800, ocilent1 wrote:
Hows progress on this bug? Don't suppose we have got an official fix for this somewhere on the horizon?
Daniel Drake posted this recently, I've not had a chance to look over it in detail but it's probably the best tested suggestion thus far.
Does it work for you?
<snip>
I tried that on 2.6.17-ck1 with good results:
...
patching file drivers/pci/quirks.c
Hunk #1 succeeded at 638 (offset -10 lines).
Hunk #2 succeeded at 678 (offset -10 lines).
...
Regards,
Hugo
Quoted 20 lines · Hugo Vanwoerkom
Quoted 8 lines · Chris Wedgwood
Quoted 2 lines · On Wed, Jul 19, 2006 at 02:03:25PM +0800, ocilent1 wrote:
Hows progress on this bug? Don't suppose we have got an official fix for this somewhere on the horizon?
Daniel Drake posted this recently, I've not had a chance to look over it in detail but it's probably the best tested suggestion thus far.
Does it work for you?
<snip>
I tried that on 2.6.17-ck1 with good results:
...
patching filedrivers/pci/quirks.c
Hunk #1 succeeded at 638 (offset -10 lines).
Hunk #2 succeeded at 678 (offset -10 lines).
...
Quoted 3 lines
Regards,
Hugo
Yep, I can also report that my sacrificial test user also said the patch works well on his VIA system.
Cheers!
Signature · 1 line
*ocilent1
sound skips on 2.6.18-ck1
In reply to Hugo VanwoerkomHi,
I see that on 2.6.18-ck1 still some sort of quirks patch is needed for VIA chips.
I get plenty:
ALSA: underrun, at least 0ms.
and with 2.6.17-ck1 with the quirks.c.patch I did not. But the patch does not fit on 2.6.18 :-(
Strangely enough this time around I do *not* get underruns on vt's with mpg321 and I *do* get them on X. Last time around it was the reverse.
Is there a fix for 2.6.18 ?
Thanks!
Hugo
Re: sound skips on 2.6.18-ck1
Quoted 7 lines · Hugo Vanwoerkom
Hi,
I see that on 2.6.18-ck1 still some sort of quirks patch is needed for VIA chips.
I get plenty:
Quoted 8 lines
ALSA: underrun, at least 0ms.
and with 2.6.17-ck1 with the quirks.c.patch I did not. But the patch does not fit on 2.6.18 :-(
Strangely enough this time around I do *not* get underruns on vt's with mpg321 and I *do* get them on X. Last time around it was the reverse.
Is there a fix for 2.6.18 ?
Slight correction: I get underruns on X *and* vt's using the snd-via82xx card (builtin) and *not* using the snd_ca0106 (PCI SB live).
H
Re: sound skips on 2.6.18-ck1
In reply to Hugo VanwoerkomQuoted 11 lines · Hugo Vanwoerkom
Hi,
I see that on 2.6.18-ck1 still some sort of quirks patch is needed for VIA chips.
I get plenty:
ALSA: underrun, at least 0ms.
and with 2.6.17-ck1 with the quirks.c.patch I did not. But the patch does not fit on 2.6.18 :-(
Quoted 8 lines
Strangely enough this time around I do *not* get underruns on vt's with mpg321 and I *do* get them on X. Last time around it was the reverse.
Is there a fix for 2.6.18 ?
Thanks!
Hugo
I know nothing about quirks.c but I adapted the patch that worked (TM) under 2.6.17 to 2.6.18 and it solves the situation for me. I attach the reworked patch and my lspci.
Regards
Hugo
drivers/pci/quirks.c +28 -8
@@ -650,10 +650,37 @@* Some of the on-chip devices are actually '586 devices' so they are * listed here. */ + +static int via_irq_fixup_needed =-1 ; + +/* +* As some VIA hardware is available in PCI-card form, we need to restrict +* this quirk to VIA PCI hardware built onto VIA-based motherboards only. +* We try to locate a VIA southbridge before deciding whether the quirk +* should be applied. +*/ +static const struct pci_device_id via_irq_fixup_tbl[] = { + { + .vendor =PCI_VENDOR_ID_VIA , + .device =PCI_ANY_ID , + .subvendor =PCI_ANY_ID , + .subdevice =PCI_ANY_ID , + .class =PCI_CLASS_BRIDGE_ISA <<8 , + .class_mask =0xffff00 , + }, + {0 , }, +}; +static void quirk_via_irq (struct pci_dev *dev) {u8 irq, new_irq; +if (via_irq_fixup_needed ==-1 ) + via_irq_fixup_needed =pci_dev_present (via_irq_fixup_tbl); + +if (!via_irq_fixup_needed) +return ; + new_irq = dev->irq &0xf ;pci_read_config_byte (dev,PCI_INTERRUPT_LINE , &irq);if (new_irq != irq) {
@@ -663,14 +690,7 @@pci_write_config_byte (dev,PCI_INTERRUPT_LINE , new_irq); } } -DECLARE_PCI_FIXUP_ENABLE (PCI_VENDOR_ID_VIA ,PCI_DEVICE_ID_VIA_82C586_0 , quirk_via_irq); -DECLARE_PCI_FIXUP_ENABLE (PCI_VENDOR_ID_VIA ,PCI_DEVICE_ID_VIA_82C586_1 , quirk_via_irq); -DECLARE_PCI_FIXUP_ENABLE (PCI_VENDOR_ID_VIA ,PCI_DEVICE_ID_VIA_82C586_2 , quirk_via_irq); -DECLARE_PCI_FIXUP_ENABLE (PCI_VENDOR_ID_VIA ,PCI_DEVICE_ID_VIA_82C586_3 , quirk_via_irq); -DECLARE_PCI_FIXUP_ENABLE (PCI_VENDOR_ID_VIA ,PCI_DEVICE_ID_VIA_8235_USB_2 , quirk_via_irq); -DECLARE_PCI_FIXUP_ENABLE (PCI_VENDOR_ID_VIA ,PCI_DEVICE_ID_VIA_82C686 , quirk_via_irq); -DECLARE_PCI_FIXUP_ENABLE (PCI_VENDOR_ID_VIA ,PCI_DEVICE_ID_VIA_82C686_4 , quirk_via_irq); -DECLARE_PCI_FIXUP_ENABLE (PCI_VENDOR_ID_VIA ,PCI_DEVICE_ID_VIA_82C686_5 , quirk_via_irq); +DECLARE_PCI_FIXUP_ENABLE (PCI_VENDOR_ID_VIA ,PCI_ANY_ID , quirk_via_irq);/* * VIA VT82C598 has its device ID settable and many BIOSes
00:00.0 Host bridge: VIA Technologies, Inc. KT880 Host Bridge
00:00.1 Host bridge: VIA Technologies, Inc. KT880 Host Bridge
00:00.2 Host bridge: VIA Technologies, Inc. KT880 Host Bridge
00:00.3 Host bridge: VIA Technologies, Inc. KT880 Host Bridge
00:00.4 Host bridge: VIA Technologies, Inc. KT880 Host Bridge
00:00.7 Host bridge: VIA Technologies, Inc. KT880 Host Bridge
00:01.0 PCI bridge: VIA Technologies, Inc. VT8237 PCI Bridge
00:0a.0 VGA compatible controller: nVidia Corporation NV18 [GeForce4 MX 440 AGP 8x] (rev a2) 00:0b.0 RAID bus controller: Silicon Image, Inc. SiI 3112 [SATALink/SATARaid] Serial ATA Controller (rev 02) 00:0c.0 Multimedia audio controller: Creative Labs SB Audigy LS
00:0f.0 IDE interface: VIA Technologies, Inc. VT82C586A/B/VT82C686/A/B/VT823x/A/C PIPC Bus Master IDE (rev 06) 00:10.0 USB Controller: VIA Technologies, Inc. VT82xxxxx UHCI USB 1.1 Controller (rev 81) 00:10.1 USB Controller: VIA Technologies, Inc. VT82xxxxx UHCI USB 1.1 Controller (rev 81) 00:10.2 USB Controller: VIA Technologies, Inc. VT82xxxxx UHCI USB 1.1 Controller (rev 81) 00:10.3 USB Controller: VIA Technologies, Inc. VT82xxxxx UHCI USB 1.1 Controller (rev 81) 00:10.4 USB Controller: VIA Technologies, Inc. USB 2.0 (rev 86)
00:11.0 ISA bridge: VIA Technologies, Inc. VT8237 ISA bridge [KT600/K8T800/K8T890 South] 00:11.5 Multimedia audio controller: VIA Technologies, Inc. VT8233/A/8235/8237 AC97 Audio Controller (rev 60) 00:12.0 Ethernet controller: VIA Technologies, Inc. VT6102 [Rhine-II] (rev 78)
01:00.0 VGA compatible controller: nVidia Corporation NV18 [GeForce4 MX 4000 AGP 8x] (rev c1)
Re: [ck] Re: sound skips on 2.6.18-ck1
Hi,
Quoted 3 lines · Hugo Vanwoerkom
I know nothing about
quirks.cbut I adapted the patch that worked (TM) under 2.6.17 to 2.6.18 and it solves the situation for me. I attach the reworked patch and my lspci.
[...diff...]
Ah, right, that stuff.
IIRC that VIA on-board off-board on-again thing has still been rearing its ugly head after 2.6.17, with a longish recent discussion on LKML (~3 weeks ago?) where people were annoyed that it still had so many different ways of breaking no matter how hard you tried to find a generic mechanism that successfully applies to all devices out there.
As such I'm not surprised in the least that it's still not working for you.
Of course I don't know the thread by heart right now, but if you don't manage to find it, then I'll try to dig it up.
Andreas Mohr
Re: [ck] Re: sound skips on 2.6.18-ck1
Quoted 6 lines · Andreas Mohr
IIRC that VIA on-board off-board on-again thing has still been rearing its ugly head after 2.6.17, with a longish recent discussion on LKML (~3 weeks ago?) where people were annoyed that it still had so many different ways of breaking no matter how hard you tried to find a generic mechanism that successfully applies to all devices out there.
As such I'm not surprised in the least that it's still not working for you.
My most recent patch solves all the known issues to my knowledge. However, it is written with very little understanding of the reasons behind the quirk. Alan Cox posted some info but having just started a real job I haven't had time to go into this stuff in detail.
I think Greg has queued this patch for 2.6.19 but wouldn't be surprised if people object to it...
Daniel
Quoted 14 lines · Chris Wedgwood
Quoted 2 lines · Con Kolivas
Quoted 2 lines
Quoted 2 lines
1) PCI-VIA-quirk-fixup-additional-PCI-IDs.patch
that shouldn't break things, if it does I *really* want to know
Quoted 4 lines
Quoted 2 lines
Quoted 2 lines
2)
PCI-quirk-VIA-IRQ-fixup-should-only-run-for-VIA-southbridges.patch
Quoted 10 lines
nor should that, so again i would like to know if this is the one that makes a difference
Quoted 2 lines
Quoted 2 lines
Works like a charm. End of the sound skips.
what cpu/mainboard/etc
CPU: athlon thoroughbred xp 2700+
mobo: EP=8VTAI
Chipset: VIA AGPset: VIA KT880 + VT8237
Memory: 2x512MB DDR
BIOS: Award BIOS dated 11/24/2004
Quoted 7 lines · On Sat, 17 Jun 2006 19:41:30 -0700 Chris Wedgwood wrote:
Quoted 1 line · Con Kolivas
Quoted 1 line
Quoted 1 line
1) PCI-VIA-quirk-fixup-additional-PCI-IDs.patch
that shouldn't break things, if it does I *really* want to know
Quoted 1 line
Quoted 1 line
Quoted 1 line
2)
Quoted 8 lines
Quoted 1 line
PCI-quirk-VIA-IRQ-fixup-should-only-run-for-VIA-southbridges.patch
nor should that, so again i would like to know if this is the one that makes a difference
Quoted 1 line
Quoted 1 line
Works like a charm. End of the sound skips.
what cpu/mainboard/etc
Here I have ASUS A8V Deluxe (VIA K8T800Pro + VT8237), and cannot reproduce the problem in a "normal" way (even when booting with "acpi=off noapic"), but I have some evidence that a problem really exists.
VT8237 contains this AC97 controller:
0000:00:11.5 Multimedia audio controller: VIA Technologies, Inc. VT8233/A/8235/8237 AC97 Audio Controller (rev 60)
Subsystem: ASUSTeK Computer Inc. A8V Deluxe motherboard (Realtek ALC850 codec)
Control: I/O+ Mem- BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B-
Status: Cap+ 66Mhz- UDF- FastB2B- ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR-
Interrupt: pin C routed to IRQ 5
Region 0: I/O ports at d800
Capabilities: [c0] Power Management version 2
Flags: PMEClk- DSI- D1+ D2+ AuxCurrent=0mA PME(D0-,D1-,D2-,D3hot-,D3cold-)
Status: D0 PME-Enable- DSel=0 DScale=0 PME-
00: 06 11 59 30 01 00 10 02 60 00 01 04 00 00 00 00
10: 01 d8 00 00 00 00 00 00 00 00 00 00 00 00 00 00
20: 00 00 00 00 00 00 00 00 00 00 00 00 43 10 2a 81
30: 00 00 00 00 c0 00 00 00 00 00 00 00 05 03 00 00
40: 01 cc 00 00 10 00 00 00 00 00 00 00 00 00 00 00
50: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
60: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
70: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
80: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
90: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
a0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
b0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
c0: 01 00 02 06 00 00 00 00 00 00 00 00 00 00 00 00
d0: 01 00 02 00 00 00 00 00 00 00 00 00 00 00 00 00
e0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
f0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
The device ID is 1106:3059 - it is not included in the list for quirk_via_irq(). However, I have tried to boot with "noapic", and by trying to change the INTERRUPT_LINE register with setpci have confirmed that this register is used to set up interrupt routing. In APIC mode this register has no effect on VT8237.
We may just add 1106:3059 to the list of PCI IDs which need quirk_via_irq(). However, is this really a proper solution? What exactly was broken with the original quirk code, which was applied to all VIA devices - just a wrong printk, or some real breakage?