Skip to contentSkip to conversation

arch/x86-64: A few trivial spelling and grammar fixes

PATCH In review Adam Henley 7 participants 11 messages Jul 8, 2006 – Jul 10, 2006

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arch/x86-64: A few trivial spelling and grammar fixes

A few trivial spelling and grammar mistakes picked up in "arch/x86_64/aperture.c", "arch/x86_64/crash.c" and "arch/x86_64/apic.c". I think all are correct fixes but am ever aware of my fallibility :o) This is my first patch submission so all feedback is appreciated, esp. WRT CCing to Linus, Andi and [email protected], is this correct? And which is the most appropriate kernel version to diff against? If any.

Should apply cleanly to 2.6.18-rc1

- adam

arch/x86_64/kernel/aperture.c +0 -0
index 58af8e7..d5f6f56 100644
@@ -48,7 +48,7 @@ static u32 __init allocate_aperture(void
 
	/*
	 * Aperture has to be naturally aligned. This means an 2GB aperture won't

- * have much chances to find a place in the lower 4GB of memory.
+ * have much chance of finding a place in the lower 4GB of memory.
* Unfortunately we cannot move it up because that would make the
* IOMMU useless.
*/

arch/x86_64/kernel/apic.c +0 -0
index 2b8cef0..194b826 100644
@@ -400,7 +400,7 @@ void __cpuinit setup_local_APIC (void)
	value |= APIC_SPIV_APIC_ENABLED;

	/*

- * Some unknown Intel IO/APIC (or APIC) errata is biting us with
+ * Some unknown Intel IO/APIC (or APIC) errata are biting us with
* certain networking cards. If high frequency interrupts are
* happening on a particular IOAPIC pin, plus the IOAPIC routing
* entry is masked/unmasked at a high rate as well then sooner or
@@ -951,7 +951,7 @@ #endif
* We take the 'long' return path, and there every subsystem
* grabs the appropriate locks (kernel lock/ irq lock). *
- * we might want to decouple profiling from the 'long path',
+ * We might want to decouple profiling from the 'long path',
* and do the profiling totally in assembly.
*
* Currently this isn't too much of an issue (performance wise),

arch/x86_64/kernel/crash.c +0 -0
index d8d5750..324a5ed 100644
@@ -68,7 +68,7 @@ static void crash_save_this_cpu(struct p

* for the data I pass, and I need tags
* on the data to indicate what information I have
* squirrelled away. ELF notes happen to provide
- * all of that that no need to invent something new.
+ * all of that, no need to invent something new.

	 */

	buf = (u32*)per_cpu_ptr(crash_notes, cpu);
#1 lore raw

Ar Sad, 2006-07-08 am 18:27 +0100, ysgrifennodd Adam Henley:

Review

Quoted 4 lines
(quoted diff) +1 -1
-	 * have much chances to find a place in the lower 4GB of memory.
+	 * have much chance of finding a place in the lower 4GB of memory.
 	 * Unfortunately we cannot move it up because that would make the
 	 * IOMMU useless.

OK (just s/chance/chance/ is enough)

Review

Quoted 2 lines
(quoted diff) +1 -1
-	 * Some unknown Intel IO/APIC (or APIC) errata is biting us with
+	 * Some unknown Intel IO/APIC (or APIC) errata are biting us with

Yes

Review

Quoted 3 lines
(quoted diff) +1 -1
-	 * we might want to decouple profiling from the 'long path',
+	 * We might want to decouple profiling from the 'long path',
 	 * and do the profiling totally in assembly.

Yes

Review

Quoted 2 lines
(quoted diff) +1 -1
-	 * all of that that no need to invent something new.
+	 * all of that, no need to invent something new.

Yes (or that. There is no need)

Alan

#2 lore raw

Edited patch.

arch/x86_64/kernel/aperture.c +1 -1
index 58af8e7..d5f6f56 100644
@@ -48,7 +48,7 @@ static u32 __init allocate_aperture(void
 
      /*
       * Aperture has to be naturally aligned. This means an 2GB aperture won't
-        * have much chances to find a place in the lower 4GB of memory.
+        * have much chance to find a place in the lower 4GB of memory.
       * Unfortunately we cannot move it up because that would make the
       * IOMMU useless.
       */
arch/x86_64/kernel/apic.c +2 -2
index 2b8cef0..194b826 100644
@@ -400,7 +400,7 @@ void __cpuinit setup_local_APIC (void)
      value |= APIC_SPIV_APIC_ENABLED;
 
      /*
-        * Some unknown Intel IO/APIC (or APIC) errata is biting us with
+        * Some unknown Intel IO/APIC (or APIC) errata are biting us with
       * certain networking cards. If high frequency interrupts are
       * happening on a particular IOAPIC pin, plus the IOAPIC routing
       * entry is masked/unmasked at a high rate as well then sooner or
@@ -951,7 +951,7 @@ #endif
       * We take the 'long' return path, and there every subsystem
       * grabs the appropriate locks (kernel lock/ irq lock).
       *
-        * we might want to decouple profiling from the 'long path',
+        * We might want to decouple profiling from the 'long path',
       * and do the profiling totally in assembly.
       *
       * Currently this isn't too much of an issue (performance wise),
arch/x86_64/kernel/crash.c +1 -1
index d8d5750..324a5ed 100644
@@ -68,7 +68,7 @@ static void crash_save_this_cpu(struct p
       * for the data I pass, and I need tags
       * on the data to indicate what information I have
       * squirrelled away.  ELF notes happen to provide
-        * all of that that no need to invent something new.
+        * all of that. There is no need to invent something new.
       */
 
      buf = (u32*)per_cpu_ptr(crash_notes, cpu);
#3 lore raw
Quoted 1 line · Adam Henley

Edited patch.

What edited?

The white space seems worse than before. I already have the previous patch now.

Also when you resubmit a patch please always add a complete changelog

-Andi

#4 lore raw
Quoted 12 lines · Andi Kleen
Quoted 1 line · Adam Henley

Edited patch.

What edited?

The white space seems worse than before. I already have the previous patch now.

Also when you resubmit a patch please always add a complete changelog

-Andi

Apologies Andi, white-space munging is probably the fault of gmail, despite using plain text only, I'll try and use Thunderbird from now on. The changes to the patch were pursuant to Alan's suggestions:

Quoted 8 lines · Alan Cox

Ar Sad, 2006-07-08 am 18:27 +0100, ysgrifennodd Adam Henley:

arch/x86_64/kernel/aperture.c static u32 __init allocate_aperture(void · line 53

Quoted 4 lines
arch/x86_64/kernel/aperture.c +1 -1
-      * have much chances to find a place in the lower 4GB of memory.
+      * have much chance of finding a place in the lower 4GB of memory.
       * Unfortunately we cannot move it up because that would make the
       * IOMMU useless.

OK (just s/chance/chance/ is enough)

Quoted 10 lines

<snip>

Review

Quoted 2 lines
(quoted diff) +1 -1
-      * all of that that no need to invent something new.
+      * all of that, no need to invent something new.

Yes (or that. There is no need)

Alan

Would you like me to resubmit the patch with a complete changelog and correct whitespace? Sorry for wasting your time over what should have been such a simple patch.

Thanks,

-adam

#6 lore raw
Quoted 4 lines · Arjan van de Ven
Quoted 3 lines

Apologies Andi, white-space munging is probably the fault of gmail, despite using plain text only, I'll try and use Thunderbird from now on.

Quoted 8 lines

DOOOOOM

please read

http://mbligh.org/linuxdocs/Email/Clients/Thunderbird

before thinking that thunderbird is better than gmail ;-)

It's not that hopeless, I use thunderbird + gmail + an external editor (emacs). And it's not mangling the whitespaces, or so I hope :-)

Tony

#7 lore raw
Quoted 8 lines · On Mon, 10 Jul 2006 21:02:59 +0800 Antonino A. Daplas wrote:
Quoted 7 lines · Arjan van de Ven
Quoted 3 lines

Apologies Andi, white-space munging is probably the fault of gmail, despite using plain text only, I'll try and use Thunderbird from now on.

DOOOOOM

Quoted 8 lines
Quoted 5 lines

please read

http://mbligh.org/linuxdocs/Email/Clients/Thunderbird

before thinking that thunderbird is better than gmail ;-)

It's not that hopeless, I use thunderbird + gmail + an external editor (emacs). And it's not mangling the whitespaces, or so I hope :-)

Right, tbird is usable (although could be much better). I've done it and documented it several times.

---
~Randy

#8 lore raw
Quoted 11 lines · Randy.Dunlap
Quoted 9 lines · On Mon, 10 Jul 2006 21:02:59 +0800 Antonino A. Daplas wrote:
Quoted 8 lines · Arjan van de Ven
Quoted 3 lines

Apologies Andi, white-space munging is probably the fault of gmail, despite using plain text only, I'll try and use Thunderbird from now on.

DOOOOOM

please read

Quoted 9 lines
Quoted 5 lines
Quoted 3 lines

http://mbligh.org/linuxdocs/Email/Clients/Thunderbird

before thinking that thunderbird is better than gmail ;-)

It's not that hopeless, I use thunderbird + gmail + an external editor (emacs). And it's not mangling the whitespaces, or so I hope :-)

Right, tbird is usable (although could be much better). I've done it and documented it several times.

Getting the external editor extension makes using tbird much easier. When composing a message, just click on the external editor icon and your favorite text editor pops up.

http://globs.org/?lng=en

Tony

#9 lore raw
In reply to Adam Henley
Quoted 5 lines · Adam Henley

A few trivial spelling and grammar mistakes picked up in "arch/x86_64/aperture.c", "arch/x86_64/crash.c" and "arch/x86_64/apic.c". I think all are correct fixes but am ever aware of my fallibility :o) This is my first patch submission so all feedback is appreciated, esp.

Applied thanks.

Quoted 2 lines

WRT CCing to Linus, Andi and
[email protected], is this correct?

Me would have been enough in this case when there is an active maintainer.

Quoted 2 lines

And which is the most appropriate
kernel version to diff against? If any.

2.6.18rc1 is fine

-Andi

#10 lore raw
Quoted 7 lines · Andi Kleen
Quoted 5 lines · Adam Henley

A few trivial spelling and grammar mistakes picked up in "arch/x86_64/aperture.c", "arch/x86_64/crash.c" and "arch/x86_64/apic.c". I think all are correct fixes but am ever aware of my fallibility :o) This is my first patch submission so all feedback is appreciated, esp.

Quoted 7 lines

Applied thanks.

Quoted 2 lines

WRT CCing to Linus, Andi and
[email protected], is this correct?

Me would have been enough in this case when there is an active maintainer.
...

A Cc to [email protected] is never wrong for such patches - if a maintainer picks it up I'm simply deleting the patch.

Quoted 1 line

-Andi

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed