xen x86_64 and CONFIG_FLATMEM

Hi,
With CONFIG_SPARSEMEM on xen x86_64, you get an oops in mem_init where
it references mem_map; mem_map is only initialized with CONFIG_FLATMEM.

Suggest a Kconfig change like the one attached?

Cheers,
Mark.

diff -r ecb8ff1fcf1f linux-2.6-xen-sparse/arch/x86_64/Kconfig
@@ -330,7 +330,7 @@ config ARCH_DISCONTIGMEM_DEFAULT
 
 config ARCH_SPARSEMEM_ENABLE
 	def_bool y
-	depends on (NUMA || EXPERIMENTAL)
+	depends on (NUMA || EXPERIMENTAL) && !X86_64_XEN
 
 config ARCH_MEMORY_PROBE
 	def_bool y

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel

Perhaps better to forcibly disable CONFIG_NUMA if CONFIG_XEN is enabled? We can't (yet) pick up NUMA info from Xen anyway, and it probably enables a bunch of code that hasn't been much tested on Xen.

-- Keir

NUMA is already disabled if CONFIG_XEN is enabled. But SPARSEMEM can be
enabled even without NUMA:

config ARCH_SPARSEMEM_ENABLE
def_bool y

-       depends on (NUMA || EXPERIMENTAL)
+       depends on (NUMA || EXPERIMENTAL) && !X86_64_XEN

Cheers,
Mark.