fix PMU initialization on pseries lpar
PATCH 1/1 fix PMU initialization on pseries lpar
We should not be calling power4_enable_pmcs() in pseries_lpar_enable_pmcs(); just doing the hypercall is sufficient. Prior to 2.6.15 we did not call power4_enable_pmcs() for an lpar.
power4_enable_pmcs() tries to read the hid0 register which is no longer legal for an lpar in newer Power processors.
arch/powerpc/platforms/pseries/setup.c~pmcfix renamed from arch/powerpc/platforms/pseries/setup.c +0 -2
@@ -182,8 +182,6 @@ static void pseries_lpar_enable_pmcs(voi { unsigned long set, reset; - power4_enable_pmcs(); - set = 1UL << 63; reset = 0; plpar_hcall_norets(H_PERFMON, set, reset);
Quoted 6 lines · Sonny Rao
We should not be calling
power4_enable_pmcs()inpseries_lpar_enable_pmcs(); just doing the hypercall is sufficient. Prior to 2.6.15 we did not callpower4_enable_pmcs()for an lpar.
power4_enable_pmcs()tries to read the hid0 register which is no longer legal for an lpar in newer Power processors.
Argh, how did I miss that. Mea culpa.
cheers
Signature · 8 lines
Michael Ellerman IBM OzLabs wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 21183) We do not inherit the earth from our ancestors, we borrow it from our children. - S.M.A.R.T Person